Sign upLogin

ChaelCodes/HuntersKeepers

View on GitHub
Star
app/controllers/improvements_controller.rb

Summary

Maintainability
A
0 mins
Test Coverage

Method has too many lines. [12/10]
Wontfix

  def update
    respond_to do |format|
      if @improvement.update(improvement_params)
        format.html do
          redirect_to improvement_url(@improvement),
Severity: Minor
Found in app/controllers/improvements_controller.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method has too many lines. [11/10]
Wontfix

  def create
    @improvement = Improvement.new(improvement_params)
    authorize @improvement
    respond_to do |format|
      if @improvement.save
Severity: Minor
Found in app/controllers/improvements_controller.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Assignment Branch Condition size for create is too high. [15.17/15]
Open

  def create
    @improvement = Improvement.new(improvement_params)
    authorize @improvement
    respond_to do |format|
      if @improvement.save
Severity: Minor
Found in app/controllers/improvements_controller.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric and https://en.wikipedia.org/wiki/ABC_Software_Metric.

Similar blocks of code found in 2 locations. Consider refactoring.
Invalid

    respond_to do |format|
      if @improvement.save
        format.html { redirect_to improvement_url(@improvement), notice: 'Improvement was successfully created.' }
        format.json { render :show, status: :created, location: @improvement }
      else
Severity: Minor
Found in app/controllers/improvements_controller.rb and 1 other location - About 50 mins to fix
app/controllers/hunters_controller.rb on lines 49..55

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 42.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Invalid

      if @improvement.update(improvement_params)
        format.html do
          redirect_to improvement_url(@improvement),
                      notice: 'Improvement was successfully updated.'
        end
Severity: Minor
Found in app/controllers/improvements_controller.rb and 1 other location - About 45 mins to fix
app/controllers/hunters_controller.rb on lines 68..73

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 40.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Line is too long. [114/80]
Open

        format.html { redirect_to improvement_url(@improvement), notice: 'Improvement was successfully created.' }
Severity: Minor
Found in app/controllers/improvements_controller.rb by rubocop

Line is too long. [87/80]
Open

        format.json { render json: @improvement.errors, status: :unprocessable_entity }
Severity: Minor
Found in app/controllers/improvements_controller.rb by rubocop

Line is too long. [87/80]
Open

        format.json { render json: @improvement.errors, status: :unprocessable_entity }
Severity: Minor
Found in app/controllers/improvements_controller.rb by rubocop

Line is too long. [101/80]
Open

      format.html { redirect_to improvements_url, notice: 'Improvement was successfully destroyed.' }
Severity: Minor
Found in app/controllers/improvements_controller.rb by rubocop

There are no issues that match your filters.

Category
Status