Sign upLogin

CloudSlang/cloud-slang

View on GitHub
Star
cloudslang-compiler/src/main/java/io/cloudslang/lang/compiler/SlangCompilerImpl.java

Summary

Maintainability
D
2 days
Test Coverage

File SlangCompilerImpl.java has 421 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*******************************************************************************
 * (c) Copyright 2016 Hewlett-Packard Development Company, L.P.
 * All rights reserved. This program and the accompanying materials
 * are made available under the terms of the Apache License v2.0 which accompany this distribution.
 *
Severity: Minor
Found in cloudslang-compiler/src/main/java/io/cloudslang/lang/compiler/SlangCompilerImpl.java - About 6 hrs to fix

    SlangCompilerImpl has 36 methods (exceeds 20 allowed). Consider refactoring.
    Open

    public class SlangCompilerImpl implements SlangCompiler {

    public static final String NOT_A_VALID_SYSTEM_PROPERTY_FILE_ERROR_MESSAGE_SUFFIX =
            "is not a valid system property file.";
    public static final String ERROR_LOADING_PROPERTIES_FILE_MESSAGE =
    Severity: Minor
    Found in cloudslang-compiler/src/main/java/io/cloudslang/lang/compiler/SlangCompilerImpl.java - About 4 hrs to fix

      Method convertRawProperties has a Cognitive Complexity of 31 (exceeds 5 allowed). Consider refactoring.
      Open

          private List<Map<String, Object>> convertRawProperties(Object propertiesAsObject, SlangSource source,
                                                           List<RuntimeException> exceptions) {
        List<Map<String, Object>> convertedProperties = new ArrayList<>();
        if (propertiesAsObject != null) {
            if (propertiesAsObject instanceof List) {
      Severity: Minor
      Found in cloudslang-compiler/src/main/java/io/cloudslang/lang/compiler/SlangCompilerImpl.java - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method convertRawProperties has 48 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          private List<Map<String, Object>> convertRawProperties(Object propertiesAsObject, SlangSource source,
                                                           List<RuntimeException> exceptions) {
        List<Map<String, Object>> convertedProperties = new ArrayList<>();
        if (propertiesAsObject != null) {
            if (propertiesAsObject instanceof List) {
      Severity: Minor
      Found in cloudslang-compiler/src/main/java/io/cloudslang/lang/compiler/SlangCompilerImpl.java - About 1 hr to fix

        Method transformSystemProperty has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

            private SystemProperty transformSystemProperty(
            String rawNamespace,
            String key,
            Object rawValue,
            String description) {
        Severity: Minor
        Found in cloudslang-compiler/src/main/java/io/cloudslang/lang/compiler/SlangCompilerImpl.java - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method extractProperties has 26 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            private SystemPropertyModellingResult extractProperties(ParsedSlang parsedSlang, SlangSource source,
                                                            List<RuntimeException> exceptions) {
        Set<SystemProperty> modelledSystemProperties = new HashSet<>();
        Set<String> modelledSystemPropertyKeys = new HashSet<>();
        Severity: Minor
        Found in cloudslang-compiler/src/main/java/io/cloudslang/lang/compiler/SlangCompilerImpl.java - About 1 hr to fix

          Method transformSystemProperty has 26 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private SystemProperty transformSystemProperty(
            String rawNamespace,
            String key,
            Object rawValue,
            String description) {
          Severity: Minor
          Found in cloudslang-compiler/src/main/java/io/cloudslang/lang/compiler/SlangCompilerImpl.java - About 1 hr to fix

            Avoid deeply nested control flow statements.
            Open

                                    if (propertyAsMap.size() == 1) {
                            Map.Entry propertyAsEntry = (Map.Entry) propertyAsMap.entrySet().iterator().next();
                            Object propertyKeyAsObject = propertyAsEntry.getKey();
                            if (propertyKeyAsObject instanceof String) {
                                Map<String, Object> convertedProperty = new HashMap<>();
            Severity: Major
            Found in cloudslang-compiler/src/main/java/io/cloudslang/lang/compiler/SlangCompilerImpl.java - About 45 mins to fix

              Method extractProperties has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  private SystemPropertyModellingResult extractProperties(ParsedSlang parsedSlang, SlangSource source,
                                                            List<RuntimeException> exceptions) {
        Set<SystemProperty> modelledSystemProperties = new HashSet<>();
        Set<String> modelledSystemPropertyKeys = new HashSet<>();
              Severity: Minor
              Found in cloudslang-compiler/src/main/java/io/cloudslang/lang/compiler/SlangCompilerImpl.java - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Identical blocks of code found in 2 locations. Consider refactoring.
              Open

                          for (String modifierKey : modifiers.keySet()) {
                if (!knownModifierKeys.contains(modifierKey)) {
                    throw new RuntimeException(
                            "Artifact {" + key + "} has unrecognized tag {" + modifierKey + "}" +
                                    ". Please take a look at the supported features per versions link");
              Severity: Minor
              Found in cloudslang-compiler/src/main/java/io/cloudslang/lang/compiler/SlangCompilerImpl.java and 1 other location - About 40 mins to fix
              cloudslang-api-commons/src/main/java/io/cloudslang/lang/commons/services/impl/SlangSourceServiceImpl.java on lines 49..55

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 50.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status