Sign upLogin

CloudSlang/cloud-slang

View on GitHub
Star
cloudslang-compiler/src/main/java/io/cloudslang/lang/compiler/parser/utils/MetadataValidatorImpl.java

Summary

Maintainability
C
1 day
Test Coverage

Method processCommonRules has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

    private List<RuntimeException> processCommonRules(
            List<String> lines,
            ParsedDescriptionSection parsedDescriptionSection,
            boolean isStep) {
        List<RuntimeException> errors = new ArrayList<>();
Severity: Minor
Found in cloudslang-compiler/src/main/java/io/cloudslang/lang/compiler/parser/utils/MetadataValidatorImpl.java - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method processCommonRules has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private List<RuntimeException> processCommonRules(
            List<String> lines,
            ParsedDescriptionSection parsedDescriptionSection,
            boolean isStep) {
        List<RuntimeException> errors = new ArrayList<>();
Severity: Minor
Found in cloudslang-compiler/src/main/java/io/cloudslang/lang/compiler/parser/utils/MetadataValidatorImpl.java - About 1 hr to fix

    Method validateBeginWrapperLine has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        private void validateBeginWrapperLine(
            List<String> lines,
            boolean isStep,
            List<RuntimeException> errors,
            int startLineNumberZeroBased) {
    Severity: Minor
    Found in cloudslang-compiler/src/main/java/io/cloudslang/lang/compiler/parser/utils/MetadataValidatorImpl.java - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method validateEndingWrapperLine has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        private void validateEndingWrapperLine(
            List<String> lines,
            boolean isStep,
            List<RuntimeException> errors,
            int lineNrZeroBased) {
    Severity: Minor
    Found in cloudslang-compiler/src/main/java/io/cloudslang/lang/compiler/parser/utils/MetadataValidatorImpl.java - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method validateEmptyLine has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

                List<String> lines,
            List<RuntimeException> errors,
            String previousTag,
            int previousItemEndLineNumber,
            String currentTag) {
    Severity: Minor
    Found in cloudslang-compiler/src/main/java/io/cloudslang/lang/compiler/parser/utils/MetadataValidatorImpl.java - About 35 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          private void validateEndingWrapperLine(
            List<String> lines,
            boolean isStep,
            List<RuntimeException> errors,
            int lineNrZeroBased) {
      Severity: Major
      Found in cloudslang-compiler/src/main/java/io/cloudslang/lang/compiler/parser/utils/MetadataValidatorImpl.java and 1 other location - About 1 hr to fix
      cloudslang-compiler/src/main/java/io/cloudslang/lang/compiler/parser/utils/MetadataValidatorImpl.java on lines 187..215

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 107.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          private void validateBeginWrapperLine(
            List<String> lines,
            boolean isStep,
            List<RuntimeException> errors,
            int startLineNumberZeroBased) {
      Severity: Major
      Found in cloudslang-compiler/src/main/java/io/cloudslang/lang/compiler/parser/utils/MetadataValidatorImpl.java and 1 other location - About 1 hr to fix
      cloudslang-compiler/src/main/java/io/cloudslang/lang/compiler/parser/utils/MetadataValidatorImpl.java on lines 134..162

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 107.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                      if (variableLine) {
                    Pair<String, String> declaration =
                            descriptionPatternMatcher.getDescriptionVariableLineData(currentLine);
                    String[] declarationElements = descriptionPatternMatcher.splitDeclaration(declaration.getLeft());
                    currentTag = declarationElements[0];
      Severity: Minor
      Found in cloudslang-compiler/src/main/java/io/cloudslang/lang/compiler/parser/utils/MetadataValidatorImpl.java and 2 other locations - About 30 mins to fix
      cloudslang-compiler/src/main/java/io/cloudslang/lang/compiler/parser/utils/MetadataValidatorImpl.java on lines 103..108
      cloudslang-compiler/src/main/java/io/cloudslang/lang/compiler/parser/utils/MetadataValidatorImpl.java on lines 98..103

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 40.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                      } else {
                    Pair<String, String> declaration =
                            descriptionPatternMatcher.getDescriptionVariableLineDataDeclarationOnly(currentLine);
                    String[] declarationElements = descriptionPatternMatcher.splitDeclaration(declaration.getLeft());
                    currentTag = declarationElements[0];
      Severity: Minor
      Found in cloudslang-compiler/src/main/java/io/cloudslang/lang/compiler/parser/utils/MetadataValidatorImpl.java and 2 other locations - About 30 mins to fix
      cloudslang-compiler/src/main/java/io/cloudslang/lang/compiler/parser/utils/MetadataValidatorImpl.java on lines 98..103
      cloudslang-compiler/src/main/java/io/cloudslang/lang/compiler/parser/utils/MetadataValidatorImpl.java on lines 93..98

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 40.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

                      } else if (isGeneralLine) {
                    Pair<String, String> declaration =
                            descriptionPatternMatcher.getDescriptionGeneralLineData(currentLine);
                    String[] declarationElements = descriptionPatternMatcher.splitDeclaration(declaration.getLeft());
                    currentTag = declarationElements[0];
      Severity: Minor
      Found in cloudslang-compiler/src/main/java/io/cloudslang/lang/compiler/parser/utils/MetadataValidatorImpl.java and 2 other locations - About 30 mins to fix
      cloudslang-compiler/src/main/java/io/cloudslang/lang/compiler/parser/utils/MetadataValidatorImpl.java on lines 103..108
      cloudslang-compiler/src/main/java/io/cloudslang/lang/compiler/parser/utils/MetadataValidatorImpl.java on lines 93..98

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 40.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status