Sign upLogin

CloudSlang/cloud-slang

View on GitHub
Star
cloudslang-runtime/src/main/java/io/cloudslang/lang/runtime/bindings/scripts/ScriptEvaluator.java

Summary

Maintainability
C
1 day
Test Coverage

File ScriptEvaluator.java has 301 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*******************************************************************************
 * (c) Copyright 2016 Hewlett-Packard Development Company, L.P.
 * All rights reserved. This program and the accompanying materials
 * are made available under the terms of the Apache License v2.0 which accompany this distribution.
 *
Severity: Minor
Found in cloudslang-runtime/src/main/java/io/cloudslang/lang/runtime/bindings/scripts/ScriptEvaluator.java - About 3 hrs to fix

    Method doEvaluateExpressionPythonExecutor has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        private Value doEvaluateExpressionPythonExecutor(String expr,
                                                     Map<String, Value> context,
                                                     Set<SystemProperty> systemProperties,
                                                     Set<ScriptFunction> functionDependencies) {
        Map<String, Serializable> pythonContext = createExternalPythonContext(context);
    Severity: Minor
    Found in cloudslang-runtime/src/main/java/io/cloudslang/lang/runtime/bindings/scripts/ScriptEvaluator.java - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method doEvaluateExpressionPythonExecutor has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        private Value doEvaluateExpressionPythonExecutor(String expr,
                                                     Map<String, Value> context,
                                                     Set<SystemProperty> systemProperties,
                                                     Set<ScriptFunction> functionDependencies) {
        Map<String, Serializable> pythonContext = createExternalPythonContext(context);
    Severity: Minor
    Found in cloudslang-runtime/src/main/java/io/cloudslang/lang/runtime/bindings/scripts/ScriptEvaluator.java - About 1 hr to fix

      Method doTestJython has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          private Value doTestJython(String expr,
                               Map<String, Value> context,
                               Set<SystemProperty> systemProperties,
                               Set<ScriptFunction> functionDependencies,
                               long timeoutPeriod) {
      Severity: Minor
      Found in cloudslang-runtime/src/main/java/io/cloudslang/lang/runtime/bindings/scripts/ScriptEvaluator.java - About 35 mins to fix

        Method doTestExternalPython has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            private Value doTestExternalPython(String expr,
                                       Map<String, Value> context,
                                       Set<SystemProperty> systemProperties,
                                       Set<ScriptFunction> functionDependencies,
                                       long timeoutPeriod) {
        Severity: Minor
        Found in cloudslang-runtime/src/main/java/io/cloudslang/lang/runtime/bindings/scripts/ScriptEvaluator.java - About 35 mins to fix

          Method processJythonExpressionTesting has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              private Value processJythonExpressionTesting(String expr, Map<String, Serializable> jythonContext,
                                                 boolean systemPropertiesDefined,
                                                 Set<ScriptFunction> functionDependencies, long timeoutPeriod) {
          Severity: Minor
          Found in cloudslang-runtime/src/main/java/io/cloudslang/lang/runtime/bindings/scripts/ScriptEvaluator.java - About 35 mins to fix

            Method testExpr has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public Value testExpr(String expr, Map<String, Value> context, Set<SystemProperty> systemProperties,
                          Set<ScriptFunction> functionDependencies, long timeoutPeriod) {
            Severity: Minor
            Found in cloudslang-runtime/src/main/java/io/cloudslang/lang/runtime/bindings/scripts/ScriptEvaluator.java - About 35 mins to fix

              Method checkSensitivity has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  private boolean checkSensitivity(Collection<Serializable> values) {
        for (Serializable value : values) {
            if (value instanceof PyObjectValue) {
                PyObjectValue pyObjectValue = (PyObjectValue) value;
                if (pyObjectValue.isSensitive() && pyObjectValue.isAccessed()) {
              Severity: Minor
              Found in cloudslang-runtime/src/main/java/io/cloudslang/lang/runtime/bindings/scripts/ScriptEvaluator.java - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  private Map<String, Value> prepareSystemPropertiesForExternalPython(Set<SystemProperty> properties) {
        Map<String, Value> processedSystemProperties = new HashMap<>();
        for (SystemProperty property : properties) {
            processedSystemProperties.put(property.getFullyQualifiedName(),
                    ValueFactory.createPyObjectValueForExternalPython(property.getValue()));
              Severity: Minor
              Found in cloudslang-runtime/src/main/java/io/cloudslang/lang/runtime/bindings/scripts/ScriptEvaluator.java and 1 other location - About 35 mins to fix
              cloudslang-runtime/src/main/java/io/cloudslang/lang/runtime/bindings/scripts/ScriptEvaluator.java on lines 266..273

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 44.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  private Map<String, Value> prepareSystemPropertiesForJython(Set<SystemProperty> properties) {
        Map<String, Value> processedSystemProperties = new HashMap<>();
        for (SystemProperty property : properties) {
            processedSystemProperties.put(property.getFullyQualifiedName(),
                    ValueFactory.createPyObjectValueForJython(property.getValue()));
              Severity: Minor
              Found in cloudslang-runtime/src/main/java/io/cloudslang/lang/runtime/bindings/scripts/ScriptEvaluator.java and 1 other location - About 35 mins to fix
              cloudslang-runtime/src/main/java/io/cloudslang/lang/runtime/bindings/scripts/ScriptEvaluator.java on lines 257..264

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 44.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status