File AbstractExecutionData.java has 403 lines of code (exceeds 250 allowed). Consider refactoring. Open
/*******************************************************************************
* (c) Copyright 2016 Hewlett-Packard Development Company, L.P.
* All rights reserved. This program and the accompanying materials
* are made available under the terms of the Apache License v2.0 which accompany this distribution.
*AbstractExecutionData has 26 methods (exceeds 20 allowed). Consider refactoring. Open
public abstract class AbstractExecutionData {
@SafeVarargs
public static void fireEvent(ExecutionRuntimeServices runtimeServices,
RunEnvironment runEnvironment,Method handleEndLoopCondition has 10 arguments (exceeds 4 allowed). Consider refactoring. Open
protected static boolean handleEndLoopCondition(RunEnvironment runEnv,
ExecutionRuntimeServices executionRuntimeServices,
Long previousStepId,
List<String> breakOn,
String nodeName,Method throwEventOutputEnd has 9 arguments (exceeds 4 allowed). Consider refactoring. Open
protected static void throwEventOutputEnd(RunEnvironment runEnv,
ExecutionRuntimeServices executionRuntimeServices,
String nodeName,
Map<String, Value> publishValues,
Long nextPosition,Method handleLoopStatement has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
protected static boolean handleLoopStatement(LoopStatement loop,
RunEnvironment runEnv,
String nodeName,
Long nextStepId,
Context flowContext,- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method fireEvent has 8 arguments (exceeds 4 allowed). Consider refactoring. Open
public static void fireEvent(ExecutionRuntimeServices runtimeServices,
RunEnvironment runEnvironment,
String type,
String description,
LanguageEventData.StepType stepType,Method fireEvent has 8 arguments (exceeds 4 allowed). Consider refactoring. Open
public static void fireEvent(ExecutionRuntimeServices runtimeServices,
String type,
String description,
String path,
LanguageEventData.StepType stepType,Method sendEndBindingInputsEvent has 8 arguments (exceeds 4 allowed). Consider refactoring. Open
public void sendEndBindingInputsEvent(List<Input> inputs,
final Map<String, Value> boundInputValues,
RunEnvironment runEnv,
ExecutionRuntimeServices executionRuntimeServices,
String desc,Method fireEvent has 8 arguments (exceeds 4 allowed). Consider refactoring. Open
public static void fireEvent(ExecutionRuntimeServices runtimeServices,
RunEnvironment runEnvironment,
String type,
String description,
LanguageEventData.StepType stepType,Method sendEndBindingArgumentsEvent has 7 arguments (exceeds 4 allowed). Consider refactoring. Open
List<Argument> arguments,
final Map<String, Value> boundInputs,
RunEnvironment runEnv,
ExecutionRuntimeServices executionRuntimeServices,
String description,Method sendStartBindingInputsEvent has 7 arguments (exceeds 4 allowed). Consider refactoring. Open
public void sendStartBindingInputsEvent(List<Input> inputs,
RunEnvironment runEnv,
ExecutionRuntimeServices executionRuntimeServices,
String desc,
LanguageEventData.StepType stepType,Method requestSwitchToRefExecutableExecutionPlan has 7 arguments (exceeds 4 allowed). Consider refactoring. Open
protected static void requestSwitchToRefExecutableExecutionPlan(RunEnvironment runEnv,
ExecutionRuntimeServices executionRuntimeServices,
Long runningExecutionPlanId,
String refId,
Long nextStepId,Method getLanguageEventData has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
private static LanguageEventData getLanguageEventData(ExecutionRuntimeServices runtimeServices,
String type,
String description,
String path,
LanguageEventData.StepType stepType,Method sendStartBindingArgumentsEvent has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
List<Argument> arguments,
RunEnvironment runEnv,
ExecutionRuntimeServices executionRuntimeServices,
String description,
String stepName,Method handleEndLoopCondition has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
protected static boolean handleEndLoopCondition(RunEnvironment runEnv,
ExecutionRuntimeServices executionRuntimeServices,
Long previousStepId,
List<String> breakOn,
String nodeName,- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method handleLoopStatement has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
protected static boolean handleLoopStatement(LoopStatement loop,
RunEnvironment runEnv,
String nodeName,
Long nextStepId,
Context flowContext,Method publishValuesMap has 6 arguments (exceeds 4 allowed). Consider refactoring. Open
protected static Map<String, Value> publishValuesMap(Set<SystemProperty> systemProperties,
List<Output> stepPublishValues,
boolean parallelLoop, Map<String, Value> aflResultMap,
ReadOnlyContextAccessor contextAccessor,
OutputsBinding outputsBinding) {Method updateCallArgumentsAndPushContextToStack has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
protected void updateCallArgumentsAndPushContextToStack(RunEnvironment runEnvironment,
Context currentContext,
Map<String, Value> callArguments,
Map<String, Prompt> prompts,
boolean pushContext) {Identical blocks of code found in 2 locations. Consider refactoring. Open
for (Input input : inputs) {
String inputName = input.getName();
Value inputValue = boundInputValues.get(inputName);
inputsForEvent.put(inputName, inputValue);
if (inputValue.isSensitive()) {- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 58.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Identical blocks of code found in 2 locations. Consider refactoring. Open
for (Argument argument : arguments) {
String argumentName = argument.getName();
Value argumentValue = boundInputs.get(argumentName);
argumentsForEvent.put(argumentName, argumentValue);
if (argumentValue.isSensitive()) {- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 58.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76