File StepExecutionData.java has 341 lines of code (exceeds 250 allowed). Consider refactoring.

Open

/*******************************************************************************
 * (c) Copyright 2016 Hewlett-Packard Development Company, L.P.
 * All rights reserved. This program and the accompanying materials
 * are made available under the terms of the Apache License v2.0 which accompany this distribution.
 *

Method getRoiValue has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.

Open

    private Double getRoiValue(String stepExecutableResult, List<NavigationOptions> stepNavigationOptions,
                               Map<String, Value> flowVariables) {
        if (isNotEmpty(stepExecutableResult) && stepNavigationOptions != null) {
            for (NavigationOptions navigationOptions : stepNavigationOptions) {
                if (navigationOptions.getName().equals(stepExecutableResult)) {

• Read up
  Read up

Method beginStep has 66 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    @SuppressWarnings("unused")
    public void beginStep(@Param(ScoreLangConstants.STEP_INPUTS_KEY) List<Argument> stepInputs,
                          @Param(ScoreLangConstants.WORKER_GROUP) WorkerGroupStatement workerGroup,
                          @Param(ScoreLangConstants.LOOP_KEY) LoopStatement loop,
                          @Param(ScoreLangConstants.RUN_ENV) RunEnvironment runEnv,

Method endStep has 63 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    @SuppressWarnings("unused")
    public void endStep(@Param(ScoreLangConstants.RUN_ENV) RunEnvironment runEnv,
                        @Param(ScoreLangConstants.STEP_PUBLISH_KEY) List<Output> stepPublishValues,
                        @Param(ScoreLangConstants.STEP_NAVIGATION_KEY)
                                Map<String, ResultNavigation> stepNavigationValues,

Method beginStep has 10 arguments (exceeds 4 allowed). Consider refactoring.

Open

    public void beginStep(@Param(ScoreLangConstants.STEP_INPUTS_KEY) List<Argument> stepInputs,
                          @Param(ScoreLangConstants.WORKER_GROUP) WorkerGroupStatement workerGroup,
                          @Param(ScoreLangConstants.LOOP_KEY) LoopStatement loop,
                          @Param(ScoreLangConstants.RUN_ENV) RunEnvironment runEnv,
                          @Param(EXECUTION_RUNTIME_SERVICES) ExecutionRuntimeServices executionRuntimeServices,

Method endStep has 8 arguments (exceeds 4 allowed). Consider refactoring.

Open

    public void endStep(@Param(ScoreLangConstants.RUN_ENV) RunEnvironment runEnv,
                        @Param(ScoreLangConstants.STEP_PUBLISH_KEY) List<Output> stepPublishValues,
                        @Param(ScoreLangConstants.STEP_NAVIGATION_KEY)
                                Map<String, ResultNavigation> stepNavigationValues,
                        @Param(EXECUTION_RUNTIME_SERVICES) ExecutionRuntimeServices executionRuntimeServices,

Method handleWorkerGroup has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.

Open

    private WorkerGroupMetadata handleWorkerGroup(WorkerGroupStatement workerGroup,
                                                  Context flowContext,
                                                  RunEnvironment runEnv,
                                                  ExecutionRuntimeServices execRuntimeServices) {
        WorkerGroupMetadata workerGroupVal = runEnv.getParentFlowStack().computeParentWorkerGroup();

• Read up
  Read up

Avoid deeply nested control flow statements.

Open

                        if (isNotEmpty(expr) && flowVariables.containsKey(expr)) {
                            roi = flowVariables.get(expr).get();
                        }

Method setWorkerGroupStep has 6 arguments (exceeds 4 allowed). Consider refactoring.

Open

            @Param(ScoreLangConstants.WORKER_GROUP) WorkerGroupStatement workerGroup,
            @Param(ScoreLangConstants.RUN_ENV) RunEnvironment runEnv,
            @Param(EXECUTION_RUNTIME_SERVICES) ExecutionRuntimeServices executionRuntimeServices,
            @Param(ScoreLangConstants.NODE_NAME_KEY) String nodeName,
            @Param(ScoreLangConstants.NEXT_STEP_ID_KEY) Long nextStepId,

Method computeWorkerValue has 5 arguments (exceeds 4 allowed). Consider refactoring.

Open

    private String computeWorkerValue(Set<ScriptFunction> scriptFunctionSet,
                                      Set<String> systemProperties,
                                      Context flowContext,
                                      RunEnvironment runEnv,
                                      String expression) {

Similar blocks of code found in 8 locations. Consider refactoring.

Open

        } catch (RuntimeException e) {
            logger.error("There was an error running the setWorkerGroupStep execution step of: \'" + nodeName +
                    "\'. Error is: " + e.getMessage());
            throw new RuntimeException("Error running: " + nodeName + ": " + e.getMessage(), e);
        }

• Read up
  Read up

Similar blocks of code found in 8 locations. Consider refactoring.

Open

        } catch (RuntimeException e) {
            logger.error("There was an error running the beginStep execution step of: \'" + nodeName +
                    "\'. Error is: " + e.getMessage());
            throw new RuntimeException("Error running: " + nodeName + ": " + e.getMessage(), e);
        }

• Read up
  Read up

Similar blocks of code found in 8 locations. Consider refactoring.

Open

        } catch (RuntimeException e) {
            logger.error("There was an error running the endStep execution step of: \'" + nodeName +
                    "\'. Error is: " + e.getMessage());
            throw new RuntimeException("Error running: \'" + nodeName + "\': " + e.getMessage(), e);
        }

• Read up
  Read up