Sign upLogin

CloudSlang/cloud-slang

View on GitHub
Star
cloudslang-runtime/src/main/resources/scripts/cs_extract_number.py

Summary

Maintainability
D
2 days
Test Coverage

Function validate_input has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

def validate_input(input_value, parameter_name, default_value):
    if type(input_value).__name__ == "NoneType":
        return default_value
    elif type(input_value).__name__ == "int":
        return input_value
Severity: Minor
Found in cloudslang-runtime/src/main/resources/scripts/cs_extract_number.py - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

        return convert_string_to_int(input_value.decode(), parameter_name, default_value)
Severity: Major
Found in cloudslang-runtime/src/main/resources/scripts/cs_extract_number.py - About 30 mins to fix

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

    def validate_input(input_value, parameter_name, default_value):
    if type(input_value).__name__ == "NoneType":
        return default_value
    elif type(input_value).__name__ == "int":
        return input_value
    Severity: Major
    Found in cloudslang-runtime/src/main/resources/scripts/cs_extract_number.py and 2 other locations - About 1 day to fix
    cloudslang-runtime/src/main/resources/scripts/cs_replace.py on lines 21..34
    cloudslang-runtime/src/main/resources/scripts/cs_substring.py on lines 18..31

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 196.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

    def check_bool_in_string(input_value, parameter_name):
    if input_value.lower() == 'true':
        return int(True)
    elif input_value.lower() == 'false':
        return int(False)
    Severity: Major
    Found in cloudslang-runtime/src/main/resources/scripts/cs_extract_number.py and 2 other locations - About 4 hrs to fix
    cloudslang-runtime/src/main/resources/scripts/cs_replace.py on lines 70..76
    cloudslang-runtime/src/main/resources/scripts/cs_substring.py on lines 67..73

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 80.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

    def convert_string_to_int(input_value, parameter_name, default_value):
    if is_string_of_type_int(input_value):
        return int(input_value)
    elif is_string_of_type_float(input_value):
        return int(float(input_value))
    Severity: Major
    Found in cloudslang-runtime/src/main/resources/scripts/cs_extract_number.py and 2 other locations - About 3 hrs to fix
    cloudslang-runtime/src/main/resources/scripts/cs_replace.py on lines 37..45
    cloudslang-runtime/src/main/resources/scripts/cs_substring.py on lines 34..42

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 64.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status