Sign upLogin

Cloudstek/mollie-php-api

View on GitHub
Star
src/Model/Base/ModelBase.php

Summary

Maintainability
B
4 hrs
Test Coverage

Function parseData has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    protected function parseData($name, $value)
    {
        if (!empty($value)) {
            if (preg_match('/.+(Datetime|Date)$/', $name)) {
                // ISO 8601 Date
Severity: Minor
Found in src/Model/Base/ModelBase.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method parseData has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function parseData($name, $value)
    {
        if (!empty($value)) {
            if (preg_match('/.+(Datetime|Date)$/', $name)) {
                // ISO 8601 Date
Severity: Minor
Found in src/Model/Base/ModelBase.php - About 1 hr to fix

    Avoid too many return statements within this method.
    Open

            return $value;
    Severity: Major
    Found in src/Model/Base/ModelBase.php - About 30 mins to fix

      The method parseData() has a Cyclomatic Complexity of 13. The configured cyclomatic complexity threshold is 10.
      Open

          protected function parseData($name, $value)
    {
        if (!empty($value)) {
            if (preg_match('/.+(Datetime|Date)$/', $name)) {
                // ISO 8601 Date
      Severity: Minor
      Found in src/Model/Base/ModelBase.php by phpmd

      CyclomaticComplexity

      Since: 0.1

      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

      Example

      // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

      Missing class import via use statement (line '80', column '32').
      Open

                          return new \DateInterval($value);
      Severity: Minor
      Found in src/Model/Base/ModelBase.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '75', column '31').
      Open

                          throw new \InvalidArgumentException("Property {$name} is not a valid date/time string: {$value}.");
      Severity: Minor
      Found in src/Model/Base/ModelBase.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '73', column '32').
      Open

                          return new \DateTime($value);
      Severity: Minor
      Found in src/Model/Base/ModelBase.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '46', column '23').
      Open

                  throw new \InvalidArgumentException("Model data should be an array, object or traversable object.");
      Severity: Minor
      Found in src/Model/Base/ModelBase.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '100', column '27').
      Open

                      throw new \InvalidArgumentException("Property {$name} is not an object, array or valid JSON string.");
      Severity: Minor
      Found in src/Model/Base/ModelBase.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '82', column '31').
      Open

                          throw new \InvalidArgumentException("Property {$name} is not a valid ISO 8601 duration string: {$value}.");
      Severity: Minor
      Found in src/Model/Base/ModelBase.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      There are no issues that match your filters.

      Category
      Status