Sign upLogin

Cloudstek/mollie-php-api

View on GitHub
Star
src/Resource/CustomerResource.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method update has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function update($name = null, $email = null, $metadata = null, $locale = null, $customerId = null)
    {
        // Check metadata type if given
        if (isset($metadata) && !is_object($metadata) && !is_array($metadata)) {
            throw new \InvalidArgumentException('Metadata argument must be of type array or object.');
Severity: Minor
Found in src/Resource/CustomerResource.php - About 1 hr to fix

    Method update has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function update($name = null, $email = null, $metadata = null, $locale = null, $customerId = null)
    Severity: Minor
    Found in src/Resource/CustomerResource.php - About 35 mins to fix

      Function update has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function update($name = null, $email = null, $metadata = null, $locale = null, $customerId = null)
    {
        // Check metadata type if given
        if (isset($metadata) && !is_object($metadata) && !is_array($metadata)) {
            throw new \InvalidArgumentException('Metadata argument must be of type array or object.');
      Severity: Minor
      Found in src/Resource/CustomerResource.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      The method update() has a Cyclomatic Complexity of 10. The configured cyclomatic complexity threshold is 10.
      Open

          public function update($name = null, $email = null, $metadata = null, $locale = null, $customerId = null)
    {
        // Check metadata type if given
        if (isset($metadata) && !is_object($metadata) && !is_array($metadata)) {
            throw new \InvalidArgumentException('Metadata argument must be of type array or object.');
      Severity: Minor
      Found in src/Resource/CustomerResource.php by phpmd

      CyclomaticComplexity

      Since: 0.1

      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

      Example

      // Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

      Missing class import via use statement (line '178', column '23').
      Open

                  throw new \BadMethodCallException("No customer ID was given");
      Severity: Minor
      Found in src/Resource/CustomerResource.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '100', column '23').
      Open

                  throw new \InvalidArgumentException("Name argument can't be an empty string.");
      Severity: Minor
      Found in src/Resource/CustomerResource.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '95', column '23').
      Open

                  throw new \InvalidArgumentException('Metadata argument must be of type array or object.');
      Severity: Minor
      Found in src/Resource/CustomerResource.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '105', column '23').
      Open

                  throw new \InvalidArgumentException("Email argument can't be an empty string.");
      Severity: Minor
      Found in src/Resource/CustomerResource.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '148', column '23').
      Open

                  throw new \BadMethodCallException("No customer ID was given");
      Severity: Minor
      Found in src/Resource/CustomerResource.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '128', column '23').
      Open

                  throw new \BadMethodCallException("No arguments supplied, please provide either name, email or metadata.");
      Severity: Minor
      Found in src/Resource/CustomerResource.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '64', column '23').
      Open

                  throw new \InvalidArgumentException('Metadata argument must be of type array or object.');
      Severity: Minor
      Found in src/Resource/CustomerResource.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      Missing class import via use statement (line '163', column '23').
      Open

                  throw new \BadMethodCallException("No customer ID was given");
      Severity: Minor
      Found in src/Resource/CustomerResource.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      There are no issues that match your filters.

      Category
      Status