CocktailJS/cocktail

View on GitHub

Showing 13 of 13 total issues

`` has 22 functions (exceeds 20 allowed). Consider refactoring.
Open

cocktail = {
    /**
     * @public
     * SEQUENCE is used to define an enumeration of priorities for annotations
     */
Severity: Minor
Found in lib/cocktail.js - About 2 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        process: function (subject) {
            var reqs = this.getParameter(), // always an []
                l = reqs.length,
                i;
    
    
    Severity: Major
    Found in lib/processor/annotation/Requires.js and 1 other location - About 1 hr to fix
    lib/processor/annotation/Talents.js on lines 18..26

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 72.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    Talents.prototype.process = function (subject) {
       var talents = this.getParameter(), // always an []
           l = talents.length,
           i;
    
    
    Severity: Major
    Found in lib/processor/annotation/Talents.js and 1 other location - About 1 hr to fix
    lib/processor/annotation/Requires.js on lines 34..42

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 72.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function process has 40 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        process: function (subject) {
            var parent = this.getParameter(),
                sp;
    
            subject.prototype = sp = Object.create(parent.prototype);
    Severity: Minor
    Found in lib/processor/annotation/Extends.js - About 1 hr to fix

      Function callSuper has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              sp.callSuper =(function() {
                  var _stack = [],
                      _idx   = 0,
                      mthdArgs;
                  
      Severity: Minor
      Found in lib/processor/annotation/Extends.js - About 1 hr to fix

        Function process has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            process: function (subject) {
                var parent = this.getParameter(),
                    sp;
        
                subject.prototype = sp = Object.create(parent.prototype);
        Severity: Minor
        Found in lib/processor/annotation/Extends.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function _configureProcessorsWith has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            _configureProcessorsWith: function (options) {
                var key, value, processor;
        
                this._cleanQueue();
        
        
        Severity: Minor
        Found in lib/cocktail.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            setParameter: function (value) {
                if (Object.prototype.toString.call(value) !== '[object Object]') {
                     throw new Error('@properties parameter should be an Object');
                }
                this._parameter = value;
        Severity: Major
        Found in lib/processor/annotation/Properties.js and 1 other location - About 1 hr to fix
        lib/processor/annotation/Static.js on lines 20..25

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 56.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            setParameter: function (value) {
                if (Object.prototype.toString.call(value) !== '[object Object]') {
                    throw new Error('@static parameter should be an Object');
                }
                this._parameter = value;
        Severity: Major
        Found in lib/processor/annotation/Static.js and 1 other location - About 1 hr to fix
        lib/processor/annotation/Properties.js on lines 19..24

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 56.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Function _applyIfNotExcluded has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

            _applyIfNotExcluded: function (key, excluded, aliases, subject, tp) {
        Severity: Minor
        Found in lib/processor/annotation/Traits.js - About 35 mins to fix

          Function _mergeDeep has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

              _mergeDeep: function (mine, their, strategy) {
                  this._doMerge(mine, their, function(key){
                      if (typeof their[key] === 'object') {
                          if (their[key] instanceof Array) {
                              mine[key] = [].concat(mine[key], their[key]);
          Severity: Minor
          Found in lib/processor/annotation/Merge.js - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function _isClassDefition has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              _isClassDefition: function (subject) {
                  var isClassDef = this._isSubjectDefinedAs(subject, 'class'),
                      definitionProps = ['constructor', '@extends', '@traits', '@requires', '@annotation'],
                      key;
          
          
          Severity: Minor
          Found in lib/cocktail.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function mix has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

              mix: function (subject, options) {
                  if (!options) {
                      if (this._isClassDefition(subject)) {
                          return this._processClassDefition(subject);
                      }
          Severity: Minor
          Found in lib/cocktail.js - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language