Sign upLogin

ComplianceAsCode/content

View on GitHub
Star
utils/refchecker.py

Summary

Maintainability
A
1 hr
Test Coverage

Function reference_check has 8 arguments (exceeds 4 allowed). Consider refactoring.
Open

def reference_check(env_yaml, rule_dirs, profile_path, product, product_yaml, reference,
Severity: Major
Found in utils/refchecker.py - About 1 hr to fix

    Function _process_controls_manager has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    def _process_controls_manager(controls_manager, env_yaml, product_yaml, profile, rule_dirs):
    Severity: Minor
    Found in utils/refchecker.py - About 35 mins to fix

      Function "reference_check" has 8 parameters, which is greater than the 7 authorized.
      Open

      def reference_check(env_yaml, rule_dirs, profile_path, product, product_yaml, reference,
                    excludes, controls_manager=None):
      Severity: Major
      Found in utils/refchecker.py by sonar-python

      A long parameter list can indicate that a new structure should be created to wrap the numerous parameters or that the function is doing too many things.

      Noncompliant Code Example

      With a maximum number of 4 parameters:

      def do_something(param1, param2, param3, param4, param5):
    ...

      Compliant Solution

      def do_something(param1, param2, param3, param4):
    ...

      There are no issues that match your filters.

      Category
      Status