CoolElvis/redlock_for_collection

View on GitHub
lib/redlock_for_collection.rb

Summary

Maintainability
A
0 mins
Test Coverage

RedlockForCollection::Manager has no descriptive comment
Open

  class Manager
Severity: Minor
Found in lib/redlock_for_collection.rb by reek

Classes and modules are the units of reuse and release. It is therefore considered good practice to annotate every class and module with a brief comment outlining its responsibilities.

Example

Given

class Dummy
  # Do things...
end

Reek would emit the following warning:

test.rb -- 1 warning:
  [1]:Dummy has no descriptive comment (IrresponsibleModule)

Fixing this is simple - just an explaining comment:

# The Dummy class is responsible for ...
class Dummy
  # Do things...
end

Missing top-level class documentation comment.
Open

  class Manager
Severity: Minor
Found in lib/redlock_for_collection.rb by rubocop

This cop checks for missing top-level documentation of classes and modules. Classes with no body are exempt from the check and so are namespace modules - modules that have nothing in their bodies except classes, other modules, or constant definitions.

The documentation requirement is annulled if the class or module has a "#:nodoc:" comment next to it. Likewise, "#:nodoc: all" does the same for all its children.

Example:

# bad
class Person
  # ...
end

# good
# Description/Explanation of Person class
class Person
  # ...
end

Line is too long. [83/80]
Open

      collection = Collection.new(objects_collection, options, @configuration.pool)
Severity: Minor
Found in lib/redlock_for_collection.rb by rubocop

Line is too long. [87/80]
Open

    # `:key_method` invoked on `object` of `objects_collection` to generate shared key.
Severity: Minor
Found in lib/redlock_for_collection.rb by rubocop

Use empty lines between method definitions.
Open

    def with_lock(objects_collection, options: {}, &block)
Severity: Minor
Found in lib/redlock_for_collection.rb by rubocop

This cop checks whether method definitions are separated by one empty line.

NumberOfEmptyLines can be and integer (e.g. 1 by default) or an array (e.g. [1, 2]) to specificy a minimum and a maximum of empty lines.

AllowAdjacentOneLineDefs can be used to configure is adjacent one line methods definitions are an offense

Example:

# bad
def a
end
def b
end

Example:

# good
def a
end

def b
end

Line is too long. [93/80]
Open

    # @param options [Hash], consist of `:key_prefix`, `:key_method`, `:min_validity`, `:ttl`
Severity: Minor
Found in lib/redlock_for_collection.rb by rubocop

1 trailing blank lines detected.
Open

Severity: Minor
Found in lib/redlock_for_collection.rb by rubocop

Line is too long. [88/80]
Open

    # `unlocked_objects` is unsuccessfully locked objects of collections for any reasons
Severity: Minor
Found in lib/redlock_for_collection.rb by rubocop

Extra blank line detected.
Open


    # @param objects_collection [#each]
Severity: Minor
Found in lib/redlock_for_collection.rb by rubocop

This cops checks for two or more consecutive blank lines.

Example:

# bad - It has two empty lines.
some_method
# one empty line
# two empty lines
some_method

# good
some_method
# one empty line
some_method

There are no issues that match your filters.

Category
Status