Covivo/mobicoop

ProposalRepository has 27 functions (exceeds 20 allowed). Consider refactoring.

Open

class ProposalRepository
{
    private $bearing_range;                   // if used, only accept proposal where the bearing direction (cape) is not at the opposite, more or less the range degrees
    // for example, if the bearing is 0 (s->n), the proposals where the bearing is between 170 and 190 (~ n->s) are excluded
    private $passenger_proportion;           // minimum passenger distance relative to the driver distance, eg passenger distance should be at least 30% of the driver distance

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            if ($this->use_bbox) {
                if ('' != $zoneDriverWhere) {
                    $zoneDriverWhere .= ' and ';
                }
                $zoneDriverWhere .= '(ST_INTERSECTS(dd.geoJsonBbox,ST_GeomFromText(\''.

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            if ($this->use_bbox) {
                if ('' != $zonePassengerWhere) {
                    $zonePassengerWhere .= ' and ';
                }
                $zonePassengerWhere .= '(ST_INTERSECTS(dp.geoJsonBbox,ST_GeomFromText(\''.

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    public function findRegularAdWithoutAskSinceXDays(?int $nbOfDays = null): ?array
    {
        $now = (new \DateTime('now'));
        $createdDate = $now->modify('-'.$nbOfDays.' days')->format('Y-m-d');

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    public function findPunctualAdWithoutAskSinceXDays(?int $nbOfDays = null): ?array
    {
        $now = (new \DateTime('now'));
        $createdDate = $now->modify('-'.$nbOfDays.' days')->format('Y-m-d');

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        foreach ($proposalsDriver as $proposalDriver) {
            // we have to check for an existing outward for a return proposal => we keep only outward
            if (Proposal::TYPE_RETURN == $proposalDriver->getType()) {
                $foundOutward = false;
                foreach ($proposalsDriver as $proposal) {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

        foreach ($proposalsPassenger as $proposalPassenger) {
            // we have to check for an existing outward for a return proposal => we keep only outward
            if (Proposal::TYPE_RETURN == $proposalPassenger->getType()) {
                $foundOutward = false;
                foreach ($proposalsPassenger as $proposal) {

• Read up
  Read up

Similar blocks of code found in 7 locations. Consider refactoring.

Open

                if ($proposal->getCriteria()->isFriCheck()) {
                    $regularFriDay = 'c.friCheck = 1';
                    $days .= '6,'; // used for punctual candidate
                    if ($proposal->getCriteria()->getFriTime()) {
                        if (!$driversOnly && $proposal->getCriteria()->isDriver() && $proposal->getCriteria()->isPassenger()) {

• Read up
  Read up

Similar blocks of code found in 7 locations. Consider refactoring.

Open

                if ($proposal->getCriteria()->isSatCheck()) {
                    $regularSatDay = 'c.satCheck = 1';
                    $days .= '7,'; // used for punctual candidate
                    if ($proposal->getCriteria()->getSatTime()) {
                        if (!$driversOnly && $proposal->getCriteria()->isDriver() && $proposal->getCriteria()->isPassenger()) {

• Read up
  Read up

Similar blocks of code found in 7 locations. Consider refactoring.

Open

                if ($proposal->getCriteria()->isSunCheck()) {
                    $regularSunDay = 'c.sunCheck = 1';
                    $days .= '1,'; // used for punctual candidate
                    if ($proposal->getCriteria()->getSunTime()) {
                        if (!$driversOnly && $proposal->getCriteria()->isDriver() && $proposal->getCriteria()->isPassenger()) {

• Read up
  Read up

Similar blocks of code found in 7 locations. Consider refactoring.

Open

                if ($proposal->getCriteria()->isMonCheck()) {
                    $regularMonDay = 'c.monCheck = 1';
                    $days .= '2,'; // used for punctual candidate
                    if ($proposal->getCriteria()->getMonTime()) {
                        if (!$driversOnly && $proposal->getCriteria()->isDriver() && $proposal->getCriteria()->isPassenger()) {

• Read up
  Read up

Similar blocks of code found in 7 locations. Consider refactoring.

Open

                if ($proposal->getCriteria()->isThuCheck()) {
                    $regularThuDay = 'c.thuCheck = 1';
                    $days .= '5,'; // used for punctual candidate
                    if ($proposal->getCriteria()->getThuTime()) {
                        if (!$driversOnly && $proposal->getCriteria()->isDriver() && $proposal->getCriteria()->isPassenger()) {

• Read up
  Read up

Similar blocks of code found in 7 locations. Consider refactoring.

Open

                if ($proposal->getCriteria()->isTueCheck()) {
                    $regularTueDay = 'c.tueCheck = 1';
                    $days .= '3,'; // used for punctual candidate
                    if ($proposal->getCriteria()->getTueTime()) {
                        if (!$driversOnly && $proposal->getCriteria()->isDriver() && $proposal->getCriteria()->isPassenger()) {

• Read up
  Read up

Similar blocks of code found in 7 locations. Consider refactoring.

Open

                if ($proposal->getCriteria()->isWedCheck()) {
                    $regularWedDay = 'c.wedCheck = 1';
                    $days .= '4,'; // used for punctual candidate
                    if ($proposal->getCriteria()->getWedTime()) {
                        if (!$driversOnly && $proposal->getCriteria()->isDriver() && $proposal->getCriteria()->isPassenger()) {

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            if ($this->use_bearing) {
                if ('' != $zonePassengerWhere) {
                    $zonePassengerWhere .= ' and ';
                }
                $range = $this->geoTools->getOppositeBearing($proposal->getCriteria()->getDirectionDriver()->getBearing(), $this->bearing_range);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

            if ($this->use_bearing && $proposal->getCriteria()->getDirectionPassenger()->getDistance() > 0) {
                if ('' != $zoneDriverWhere) {
                    $zoneDriverWhere .= ' and ';
                }
                $range = $this->geoTools->getOppositeBearing($proposal->getCriteria()->getDirectionPassenger()->getBearing(), $this->bearing_range);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    public function findInactiveAdsSinceXDays(int $numberOfDays): ?array
    {
        $now = new \DateTime();
        $toDate = $now->modify('-'.$numberOfDays.' days')->format('Y-m-d');

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    public function findSoonExpiredAds(int $numberOfDays): ?array
    {
        $now = new \DateTime();
        $toDate = $now->modify('+'.$numberOfDays.' days')->format('Y-m-d');

• Read up
  Read up