Sign upLogin

Dalphi/dalphi

View on GitHub
Star

Showing 1,441 of 1,441 total issues

%w-literals should be delimited by [ and ].
Open

    expect(interface.associated_problem_identifiers.sort).to eq(%w(ner super_ner).sort)
Severity: Minor
Found in spec/requests/interfaces/create_spec.rb by rubocop

This cop enforces the consistent usage of %-literal delimiters.

Specify the 'default' key to set all preferred delimiters at once. You can continue to specify individual preferred delimiters to override the default.

Example:

# Style/PercentLiteralDelimiters:
#   PreferredDelimiters:
#     default: '[]'
#     '%i':    '()'

# good
%w[alpha beta] + %i(gamma delta)

# bad
%W(alpha #{beta})

# bad
%I(alpha beta)

Use normalcase for variable numbers.
Open

      statistic_2 = Statistic.second
Severity: Minor
Found in spec/requests/api/v1/statistics_spec.rb by rubocop

This cop makes sure that all numbered variables use the configured style, snakecase, normalcase or noninteger, for their numbering.

Example: EnforcedStyle: snake_case

# bad

variable1 = 1

# good

variable_1 = 1

Example: EnforcedStyle: normalcase (default)

# bad

variable_1 = 1

# good

variable1 = 1

Example: EnforcedStyle: non_integer

# bad

variable1 = 1

variable_1 = 1

# good

variableone = 1

variable_one = 1

Line is too long. [94/80]
Open

    expect(response.header['Location'].gsub(/\?.*/, '')).to eq(edit_interface_url(@interface))
Severity: Minor
Found in spec/requests/interfaces/refresh_spec.rb by rubocop

Redundant curly braces around a hash parameter.
Open

      {
        'id' => statistic.id,
        'key' => statistic.key,
        'value' => statistic.value,
        'iteration_index' => statistic.iteration_index,
Severity: Minor
Found in spec/requests/api/v1/statistics_spec.rb by rubocop

This cop checks for braces around the last parameter in a method call if the last parameter is a hash. It supports braces, no_braces and context_dependent styles.

Example: EnforcedStyle: braces

# The `braces` style enforces braces around all method
# parameters that are hashes.

# bad
some_method(x, y, a: 1, b: 2)

# good
some_method(x, y, {a: 1, b: 2})

Example: EnforcedStyle: no_braces (default)

# The `no_braces` style checks that the last parameter doesn't
# have braces around it.

# bad
some_method(x, y, {a: 1, b: 2})

# good
some_method(x, y, a: 1, b: 2)

Example: EnforcedStyle: context_dependent

# The `context_dependent` style checks that the last parameter
# doesn't have braces around it, but requires braces if the
# second to last parameter is also a hash literal.

# bad
some_method(x, y, {a: 1, b: 2})
some_method(x, y, {a: 1, b: 2}, a: 1, b: 2)

# good
some_method(x, y, a: 1, b: 2)
some_method(x, y, {a: 1, b: 2}, {a: 1, b: 2})

Avoid comma after the last item of an array.
Open

        { filename: 'invalid2.bin', path: file_path_2 },
Severity: Minor
Found in spec/models/raw_datum_spec.rb by rubocop

This cop checks for trailing comma in array and hash literals.

Example: EnforcedStyleForMultiline: consistent_comma

# bad
a = [1, 2,]

# good
a = [
  1, 2,
  3,
]

# good
a = [
  1,
  2,
]

Example: EnforcedStyleForMultiline: comma

# bad
a = [1, 2,]

# good
a = [
  1,
  2,
]

Example: EnforcedStyleForMultiline: no_comma (default)

# bad
a = [1, 2,]

# good
a = [
  1,
  2
]

Useless assignment to variable - raw_datum.
Open

      raw_datum = FactoryGirl.create(:raw_datum)
Severity: Minor
Found in spec/requests/api/v1/annotation_documents_spec.rb by rubocop

This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

assigned but unused variable - foo

Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

Example:

# bad

def some_method
  some_var = 1
  do_something
end

Example:

# good

def some_method
  some_var = 1
  do_something(some_var)
end

Extra empty line detected at block body beginning.
Open


end
Severity: Minor
Found in spec/controllers/annotators_controller_spec.rb by rubocop

This cops checks if empty lines around the bodies of blocks match the configuration.

Example: EnforcedStyle: empty_lines

# good

foo do |bar|

  # ...

end

Example: EnforcedStyle: noemptylines (default)

# good

foo do |bar|
  # ...
end

Redundant curly braces around a hash parameter.
Open

      {
        'id' => statistic.id,
        'key' => statistic.key,
        'value' => statistic.value,
        'iteration_index' => statistic.iteration_index,
Severity: Minor
Found in spec/requests/api/v1/statistics_spec.rb by rubocop

This cop checks for braces around the last parameter in a method call if the last parameter is a hash. It supports braces, no_braces and context_dependent styles.

Example: EnforcedStyle: braces

# The `braces` style enforces braces around all method
# parameters that are hashes.

# bad
some_method(x, y, a: 1, b: 2)

# good
some_method(x, y, {a: 1, b: 2})

Example: EnforcedStyle: no_braces (default)

# The `no_braces` style checks that the last parameter doesn't
# have braces around it.

# bad
some_method(x, y, {a: 1, b: 2})

# good
some_method(x, y, a: 1, b: 2)

Example: EnforcedStyle: context_dependent

# The `context_dependent` style checks that the last parameter
# doesn't have braces around it, but requires braces if the
# second to last parameter is also a hash literal.

# bad
some_method(x, y, {a: 1, b: 2})
some_method(x, y, {a: 1, b: 2}, a: 1, b: 2)

# good
some_method(x, y, a: 1, b: 2)
some_method(x, y, {a: 1, b: 2}, {a: 1, b: 2})

Line is too long. [101/80]
Open

    expect(interface.associated_problem_identifiers).to eq(@interface.associated_problem_identifiers)
Severity: Minor
Found in spec/requests/interface_types/update_spec.rb by rubocop

Line is too long. [88/80]
Open

    it 'creates multiple annotation documents for list of valid annotation documents' do
Severity: Minor
Found in spec/requests/api/v1/annotation_documents_spec.rb by rubocop

Line is too long. [136/80]
Open

                 'payload' => JSON.parse("{\"label\":\"testlabel\",\"options\":[\"option1\",\"option2\"],\"content\":\"testcontent\"}"),
Severity: Minor
Found in spec/requests/api/v1/annotation_documents_spec.rb by rubocop

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

          'payload' => JSON.parse("{\"label\":\"testlabel\",\"options\":[\"option1\",\"option2\"],\"content\":\"testcontent\"}"),
Severity: Minor
Found in spec/requests/api/v1/annotation_documents_spec.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Use normalcase for variable numbers.
Open

      statistic_2 = Statistic.second
Severity: Minor
Found in spec/requests/api/v1/statistics_spec.rb by rubocop

This cop makes sure that all numbered variables use the configured style, snakecase, normalcase or noninteger, for their numbering.

Example: EnforcedStyle: snake_case

# bad

variable1 = 1

# good

variable_1 = 1

Example: EnforcedStyle: normalcase (default)

# bad

variable_1 = 1

# good

variable1 = 1

Example: EnforcedStyle: non_integer

# bad

variable1 = 1

variable_1 = 1

# good

variableone = 1

variable_one = 1

Redundant curly braces around a hash parameter.
Open

      {
        'id' => statistic.id,
        'key' => statistic.key,
        'value' => statistic.value,
        'iteration_index' => statistic.iteration_index,
Severity: Minor
Found in spec/requests/api/v1/statistics_spec.rb by rubocop

This cop checks for braces around the last parameter in a method call if the last parameter is a hash. It supports braces, no_braces and context_dependent styles.

Example: EnforcedStyle: braces

# The `braces` style enforces braces around all method
# parameters that are hashes.

# bad
some_method(x, y, a: 1, b: 2)

# good
some_method(x, y, {a: 1, b: 2})

Example: EnforcedStyle: no_braces (default)

# The `no_braces` style checks that the last parameter doesn't
# have braces around it.

# bad
some_method(x, y, {a: 1, b: 2})

# good
some_method(x, y, a: 1, b: 2)

Example: EnforcedStyle: context_dependent

# The `context_dependent` style checks that the last parameter
# doesn't have braces around it, but requires braces if the
# second to last parameter is also a hash literal.

# bad
some_method(x, y, {a: 1, b: 2})
some_method(x, y, {a: 1, b: 2}, a: 1, b: 2)

# good
some_method(x, y, a: 1, b: 2)
some_method(x, y, {a: 1, b: 2}, {a: 1, b: 2})

Line is too long. [86/80]
Open

      statistic_1 = FactoryGirl.build(:statistic, key: 'compliance', project: project)
Severity: Minor
Found in spec/requests/api/v1/statistics_spec.rb by rubocop

Avoid comma after the last item of an array.
Open

          },
Severity: Minor
Found in spec/requests/api/v1/statistics_spec.rb by rubocop

This cop checks for trailing comma in array and hash literals.

Example: EnforcedStyleForMultiline: consistent_comma

# bad
a = [1, 2,]

# good
a = [
  1, 2,
  3,
]

# good
a = [
  1,
  2,
]

Example: EnforcedStyleForMultiline: comma

# bad
a = [1, 2,]

# good
a = [
  1,
  2,
]

Example: EnforcedStyleForMultiline: no_comma (default)

# bad
a = [1, 2,]

# good
a = [
  1,
  2
]

Line is too long. [82/80]
Open

        'data' => Base64.encode64(Paperclip.io_adapters.for(raw_datum.data).read),
Severity: Minor
Found in spec/requests/api/v1/raw_data_spec.rb by rubocop

Line is too long. [88/80]
Open

    patch api_v1_annotation_document_path(annotation_document, auth_token: @auth_token),
Severity: Minor
Found in spec/requests/api/v1/annotation_documents_spec.rb by rubocop

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

            'payload' => JSON.parse("{\"label\":\"anotherlabel\",\"options\":[\"option1\",\"option2\",\"option3\"],\"content\":\"othercontent\"}"),
Severity: Minor
Found in spec/requests/api/v1/annotation_documents_spec.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Use normalcase for variable numbers.
Open

      statistic_1 = FactoryGirl.build(:statistic, key: 'compliance', project: project)
Severity: Minor
Found in spec/requests/api/v1/statistics_spec.rb by rubocop

This cop makes sure that all numbered variables use the configured style, snakecase, normalcase or noninteger, for their numbering.

Example: EnforcedStyle: snake_case

# bad

variable1 = 1

# good

variable_1 = 1

Example: EnforcedStyle: normalcase (default)

# bad

variable_1 = 1

# good

variable1 = 1

Example: EnforcedStyle: non_integer

# bad

variable1 = 1

variable_1 = 1

# good

variableone = 1

variable_one = 1
Severity
Category
Status
Source
Language