Sign upLogin

Dalphi/dalphi

View on GitHub
Star

Showing 1,441 of 1,441 total issues

Line is too long. [103/80]
Open

             'data' => fixture_file_upload("#{Rails.root}/spec/fixtures/text/valid2.md", 'text/plain'),
Severity: Minor
Found in spec/requests/api/v1/raw_data_spec.rb by rubocop

Redundant curly braces around a hash parameter.
Open

        {
          success: ['valid.md'],
          error: ['invalid.bin']
        }
Severity: Minor
Found in spec/models/raw_datum_spec.rb by rubocop

This cop checks for braces around the last parameter in a method call if the last parameter is a hash. It supports braces, no_braces and context_dependent styles.

Example: EnforcedStyle: braces

# The `braces` style enforces braces around all method
# parameters that are hashes.

# bad
some_method(x, y, a: 1, b: 2)

# good
some_method(x, y, {a: 1, b: 2})

Example: EnforcedStyle: no_braces (default)

# The `no_braces` style checks that the last parameter doesn't
# have braces around it.

# bad
some_method(x, y, {a: 1, b: 2})

# good
some_method(x, y, a: 1, b: 2)

Example: EnforcedStyle: context_dependent

# The `context_dependent` style checks that the last parameter
# doesn't have braces around it, but requires braces if the
# second to last parameter is also a hash literal.

# bad
some_method(x, y, {a: 1, b: 2})
some_method(x, y, {a: 1, b: 2}, a: 1, b: 2)

# good
some_method(x, y, a: 1, b: 2)
some_method(x, y, {a: 1, b: 2}, {a: 1, b: 2})

Line is too long. [87/80]
Open

                                    interface_type: @annotation_document.interface_type
Severity: Minor
Found in spec/requests/annotation_documents_spec.rb by rubocop

Line is too long. [104/80]
Open

    expect(response.header['Location'].gsub(/\?.*/, '')).to eq(edit_interface_type_url(@interface_type))
Severity: Minor
Found in spec/requests/interface_types/update_spec.rb by rubocop

Line is too long. [121/80]
Open

    expect(Paperclip.io_adapters.for(interface.template).read).to eq(Paperclip.io_adapters.for(@interface.template).read)
Severity: Minor
Found in spec/requests/interface_types/update_spec.rb by rubocop

Line is too long. [87/80]
Open

    expect(interface.associated_problem_identifiers.sort).to eq(%w(ner super_ner).sort)
Severity: Minor
Found in spec/requests/interfaces/create_spec.rb by rubocop

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

RSpec.describe "Redirection", type: :request do
Severity: Minor
Found in spec/requests/api/redirect_spec.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Line is too long. [129/80]
Open

          'payload' => JSON.parse("{\"label\":\"testlabel\",\"options\":[\"option1\",\"option2\"],\"content\":\"testcontent\"}"),
Severity: Minor
Found in spec/requests/api/v1/annotation_documents_spec.rb by rubocop

Use 2 spaces for indentation in a hash, relative to the start of the line where the left curly brace is.
Open

                'key' => statistic_1.key,
Severity: Minor
Found in spec/requests/api/v1/statistics_spec.rb by rubocop

This cops checks the indentation of the first key in a hash literal where the opening brace and the first key are on separate lines. The other keys' indentations are handled by the AlignHash cop.

By default, Hash literals that are arguments in a method call with parentheses, and where the opening curly brace of the hash is on the same line as the opening parenthesis of the method call, shall have their first key indented one step (two spaces) more than the position inside the opening parenthesis.

Other hash literals shall have their first key indented one step more than the start of the line where the opening curly brace is.

This default style is called 'specialinsideparentheses'. Alternative styles are 'consistent' and 'align_braces'. Here are examples:

Example: EnforcedStyle: specialinsideparentheses (default)

# The `special_inside_parentheses` style enforces that the first key
# in a hash literal where the opening brace and the first key are on
# separate lines is indented one step (two spaces) more than the
# position inside the opening parentheses.

# bad
hash = {
  key: :value
}
and_in_a_method_call({
  no: :difference
                     })

# good
special_inside_parentheses
hash = {
  key: :value
}
but_in_a_method_call({
                       its_like: :this
                     })

Example: EnforcedStyle: consistent

# The `consistent` style enforces that the first key in a hash
# literal where the opening brace and the first key are on
# seprate lines is indented the same as a hash literal which is not
# defined inside a method call.

# bad
hash = {
  key: :value
}
but_in_a_method_call({
                       its_like: :this
                      })

# good
hash = {
  key: :value
}
and_in_a_method_call({
  no: :difference
})

Example: EnforcedStyle: align_braces

# The `align_brackets` style enforces that the opening and closing
# braces are indented to the same position.

# bad
and_now_for_something = {
                          completely: :different
}

# good
and_now_for_something = {
                          completely: :different
                        }

Line is too long. [85/80]
Open

      statistic_2 = FactoryGirl.build(:statistic, key: 'precision', project: project)
Severity: Minor
Found in spec/requests/api/v1/statistics_spec.rb by rubocop

Use normalcase for variable numbers.
Open

      statistic_1 = Statistic.first
Severity: Minor
Found in spec/requests/api/v1/statistics_spec.rb by rubocop

This cop makes sure that all numbered variables use the configured style, snakecase, normalcase or noninteger, for their numbering.

Example: EnforcedStyle: snake_case

# bad

variable1 = 1

# good

variable_1 = 1

Example: EnforcedStyle: normalcase (default)

# bad

variable_1 = 1

# good

variable1 = 1

Example: EnforcedStyle: non_integer

# bad

variable1 = 1

variable_1 = 1

# good

variableone = 1

variable_one = 1

Redundant curly braces around a hash parameter.
Open

      {
        'id' => statistic.id,
        'key' => statistic.key,
        'value' => statistic.value,
        'iteration_index' => statistic.iteration_index,
Severity: Minor
Found in spec/requests/api/v1/statistics_spec.rb by rubocop

This cop checks for braces around the last parameter in a method call if the last parameter is a hash. It supports braces, no_braces and context_dependent styles.

Example: EnforcedStyle: braces

# The `braces` style enforces braces around all method
# parameters that are hashes.

# bad
some_method(x, y, a: 1, b: 2)

# good
some_method(x, y, {a: 1, b: 2})

Example: EnforcedStyle: no_braces (default)

# The `no_braces` style checks that the last parameter doesn't
# have braces around it.

# bad
some_method(x, y, {a: 1, b: 2})

# good
some_method(x, y, a: 1, b: 2)

Example: EnforcedStyle: context_dependent

# The `context_dependent` style checks that the last parameter
# doesn't have braces around it, but requires braces if the
# second to last parameter is also a hash literal.

# bad
some_method(x, y, {a: 1, b: 2})
some_method(x, y, {a: 1, b: 2}, a: 1, b: 2)

# good
some_method(x, y, a: 1, b: 2)
some_method(x, y, {a: 1, b: 2}, {a: 1, b: 2})

Line is too long. [91/80]
Open

        'data' => Base64.encode64(File.read("#{Rails.root}/spec/fixtures/text/valid2.md")),
Severity: Minor
Found in spec/requests/api/v1/raw_data_spec.rb by rubocop

Redundant curly braces around a hash parameter.
Open

      {
        'id' => raw_datum.id,
        'shape' => raw_datum.shape,
        'data' => Base64.encode64(File.read("#{Rails.root}/spec/fixtures/text/valid2.md")),
        'filename' => raw_datum.filename,
Severity: Minor
Found in spec/requests/api/v1/raw_data_spec.rb by rubocop

This cop checks for braces around the last parameter in a method call if the last parameter is a hash. It supports braces, no_braces and context_dependent styles.

Example: EnforcedStyle: braces

# The `braces` style enforces braces around all method
# parameters that are hashes.

# bad
some_method(x, y, a: 1, b: 2)

# good
some_method(x, y, {a: 1, b: 2})

Example: EnforcedStyle: no_braces (default)

# The `no_braces` style checks that the last parameter doesn't
# have braces around it.

# bad
some_method(x, y, {a: 1, b: 2})

# good
some_method(x, y, a: 1, b: 2)

Example: EnforcedStyle: context_dependent

# The `context_dependent` style checks that the last parameter
# doesn't have braces around it, but requires braces if the
# second to last parameter is also a hash literal.

# bad
some_method(x, y, {a: 1, b: 2})
some_method(x, y, {a: 1, b: 2}, a: 1, b: 2)

# good
some_method(x, y, a: 1, b: 2)
some_method(x, y, {a: 1, b: 2}, {a: 1, b: 2})

Align the parameters of a method call if they span more than one line.
Open

                       raw_datum: raw_datum,
                       interface_type: arbitrary_interface_type,
                       rank: 2,
                       payload: {
                         options: ['Enthält Personennamen', 'Enthält keine Personennamen'],
Severity: Minor
Found in spec/requests/projects/merge_spec.rb by rubocop

Here we check if the parameters on a multi-line method call or definition are aligned.

Example: EnforcedStyle: withfirstparameter (default)

# good

foo :bar,
    :baz

# bad

foo :bar,
  :baz

Example: EnforcedStyle: withfixedindentation

# good

foo :bar,
  :baz

# bad

foo :bar,
    :baz

Prefer single-quoted strings when you don't need string interpolation or special symbols.
Open

                         content: "par2",
Severity: Minor
Found in spec/requests/projects/merge_spec.rb by rubocop

Checks if uses of quotes match the configured preference.

Example: EnforcedStyle: single_quotes (default)

# bad
"No special symbols"
"No string interpolation"
"Just text"

# good
'No special symbols'
'No string interpolation'
'Just text'
"Wait! What's #{this}!"

Example: EnforcedStyle: double_quotes

# bad
'Just some text'
'No special chars or interpolation'

# good
"Just some text"
"No special chars or interpolation"
"Every string in #{project} uses double_quotes"

Line is too long. [84/80]
Open

      expect(project.description).to eq('A test project for testing purposes only.')
Severity: Minor
Found in spec/requests/projects/setup_spec.rb by rubocop

Line is too long. [89/80]
Open

    it 'should only connect thoses services where exactly one service per type exists' do
Severity: Minor
Found in spec/requests/projects/setup_spec.rb by rubocop

Use normalcase for variable numbers.
Open

      raw_datum_1 = FactoryGirl.build(:raw_datum, project: project)
Severity: Minor
Found in spec/requests/api/v1/raw_data_spec.rb by rubocop

This cop makes sure that all numbered variables use the configured style, snakecase, normalcase or noninteger, for their numbering.

Example: EnforcedStyle: snake_case

# bad

variable1 = 1

# good

variable_1 = 1

Example: EnforcedStyle: normalcase (default)

# bad

variable_1 = 1

# good

variable1 = 1

Example: EnforcedStyle: non_integer

# bad

variable1 = 1

variable_1 = 1

# good

variableone = 1

variable_one = 1

Redundant curly braces around a hash parameter.
Open

    expect(json).to eq({ 'serviceIsAvailable' => true })
Severity: Minor
Found in spec/requests/services/check_connectivity_spec.rb by rubocop

This cop checks for braces around the last parameter in a method call if the last parameter is a hash. It supports braces, no_braces and context_dependent styles.

Example: EnforcedStyle: braces

# The `braces` style enforces braces around all method
# parameters that are hashes.

# bad
some_method(x, y, a: 1, b: 2)

# good
some_method(x, y, {a: 1, b: 2})

Example: EnforcedStyle: no_braces (default)

# The `no_braces` style checks that the last parameter doesn't
# have braces around it.

# bad
some_method(x, y, {a: 1, b: 2})

# good
some_method(x, y, a: 1, b: 2)

Example: EnforcedStyle: context_dependent

# The `context_dependent` style checks that the last parameter
# doesn't have braces around it, but requires braces if the
# second to last parameter is also a hash literal.

# bad
some_method(x, y, {a: 1, b: 2})
some_method(x, y, {a: 1, b: 2}, a: 1, b: 2)

# good
some_method(x, y, a: 1, b: 2)
some_method(x, y, {a: 1, b: 2}, {a: 1, b: 2})
Severity
Category
Status
Source
Language