DeFiCh/jellyfish

Similar blocks of code found in 3 locations. Consider refactoring.

Open

function validateScript (script: Script): boolean {
  return script.stack.length === 2 &&
    script.stack[0].type === OP_CODES.OP_16.type &&
    script.stack[1].type === 'OP_PUSHDATA' && (script.stack[1] as OP_PUSHDATA).length() === 20
}

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

function isScriptP2WSH (script: Script): boolean {
  return script.stack.length === 2 &&
    script.stack[0].type === OP_CODES.OP_0.type &&
    script.stack[1].type === 'OP_PUSHDATA' && (script.stack[1] as OP_PUSHDATA).length() === 32
}

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  static compactSize (getter: () => number, setter: (data: number) => void): BufferComposer {
    return {
      fromBuffer: (buffer: SmartBuffer): void => {
        setter(readCompactSize(buffer))
      },

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  static varInt (getter: () => number, setter: (data: number) => void): BufferComposer {
    return {
      fromBuffer: (buffer: SmartBuffer): void => {
        setter(readVarInt(buffer))
      },

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  static to (net: NetworkName | Network, h160: string): P2SH {
    if (h160.length !== Base58Address.DATA_HEX_LENGTH) {
      throw new Error('InvalidDataLength')
    }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  static to (net: NetworkName | Network, h160: string): P2PKH {
    if (h160.length !== Base58Address.DATA_HEX_LENGTH) {
      throw new Error('InvalidDataLength')
    }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  async index (block: RawBlock): Promise<void> {
    if (block.masternode !== undefined) {
      const mn = await this.masternodeMapper.get(block.masternode)
      if (mn !== undefined) {
        await this.masternodeMapper.put({ ...mn, mintedBlocks: mn.mintedBlocks + 1 })

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  async invalidate (block: RawBlock): Promise<void> {
    if (block.masternode !== undefined) {
      const mn = await this.masternodeMapper.get(block.masternode)
      if (mn !== undefined) {
        await this.masternodeMapper.put({ ...mn, mintedBlocks: mn.mintedBlocks - 1 })

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

export class CTokenPayback extends ComposableBuffer<TokenPayback> {
  composers (tp: TokenPayback): BufferComposer[] {
    return [
      ComposableBuffer.varInt(() => tp.dToken, v => tp.dToken = v),
      ComposableBuffer.compactSizeArray(() => tp.amounts, v => tp.amounts = v, v => new CTokenBalance(v))

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  composers (tm: TokenMint): BufferComposer[] {
    return [
      ComposableBuffer.compactSizeArray(() => tm.balances, v => tm.balances = v, v => new CTokenBalance(v)),
      ComposableBuffer.single<Script>(() => tm.to, v => tm.to = v, v => new CScript(v))
    ]

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  composers (p: PoolAddLiquidity): BufferComposer[] {
    return [
      ComposableBuffer.compactSizeArray(() => p.from, v => p.from = v, v => new CScriptBalances(v)),
      ComposableBuffer.single<Script>(() => p.shareAddress, v => p.shareAddress = v, v => new CScript(v))
    ]

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

export class CTokenPrice extends ComposableBuffer<TokenPrice> {
  composers (sb: TokenPrice): BufferComposer[] {
    return [
      ComposableBuffer.compactSizeUtf8BE(() => sb.token, v => sb.token = v),
      ComposableBuffer.compactSizeArray(() => sb.prices, v => sb.prices = v, v => new CTokenAmount(v))

• Read up
  Read up

File place.auction.bid.spec.ts has 258 lines of code (exceeds 250 allowed). Consider refactoring.

Open

import { NestFastifyApplication } from '@nestjs/platform-fastify'
import { TestingGroup, Testing } from '@defichain/jellyfish-testing'
import { MasterNodeRegTestContainer } from '@defichain/testcontainers'
import { createTestingApp, stopTestingApp, waitForIndexedHeight } from '../../../e2e.module'
import { VaultAuctionHistoryMapper } from '../../../module.model/vault.auction.batch.history'

Blockchain has 21 functions (exceeds 20 allowed). Consider refactoring.

Open

export class Blockchain {
  private readonly client: ApiClient

  constructor (client: ApiClient) {
    this.client = client

StatsController has 21 functions (exceeds 20 allowed). Consider refactoring.

Open

@Controller('/stats')
export class StatsController {
  constructor (
    protected readonly blockMapper: BlockMapper,
    protected readonly priceTickerMapper: PriceTickerMapper,

Account has 21 functions (exceeds 20 allowed). Consider refactoring.

Open

export class Account {
  private readonly client: ApiClient

  constructor (client: ApiClient) {
    this.client = client

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  async getCachedEvmRpcUrl (): Promise<string> {
    if (this.cachedEvmRpcUrl === undefined) {
      const port = await this.getEvmRpcPort()
      const user = this.startOptions!.user!
      const password = this.startOptions!.password!

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  async getCachedRpcUrl (): Promise<string> {
    if (this.cachedRpcUrl === undefined) {
      const port = await this.getRpcPort()
      const user = this.startOptions!.user!
      const password = this.startOptions!.password!

• Read up
  Read up

File loan.ts has 255 lines of code (exceeds 250 allowed). Consider refactoring.

Open

import { ApiClient, token } from '..'
import {
  AuctionPagination,
  CloseVault,
  CreateVault,

Function update has 53 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  async update (
    updateMasternode: UpdateMasternode,
    changeScript: Script,
    collateral?: {
      txid: string