DeFiCh/jellyfish

Similar blocks of code found in 2 locations. Consider refactoring.

Open

export function fromScriptP2WPKH (script: Script, network: NetworkName): string | undefined {
  if (!isScriptP2WPKH(script)) {
    return undefined
  }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  @Get('listpoolpairs')
  async listPoolPairs (
    @Query('network', NetworkValidationPipe) network: SupportedNetwork = 'mainnet'
  ): Promise<{ [key: string]: LegacyPoolPairData }> {
    const api = this.whaleApiClientProvider.getClient(network)

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

  static uInt16 (getter: () => number, setter: (data: number) => void): BufferComposer {
    return {
      fromBuffer: (buffer: SmartBuffer): void => {
        setter(buffer.readUInt16LE())
      },

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

  static int32 (getter: () => number, setter: (data: number) => void): BufferComposer {
    return {
      fromBuffer: (buffer: SmartBuffer): void => {
        setter(buffer.readInt32LE())
      },

• Read up
  Read up

Similar blocks of code found in 3 locations. Consider refactoring.

Open

  static uInt32 (getter: () => number, setter: (data: number) => void): BufferComposer {
    return {
      fromBuffer: (buffer: SmartBuffer): void => {
        setter(buffer.readUInt32LE())
      },

• Read up
  Read up

File update.masternode.spec.ts has 272 lines of code (exceeds 250 allowed). Consider refactoring.

Open

import {
  createTestingApp,
  DelayedEunosPayaTestContainer,
  invalidateFromHeight,
  stopTestingApp,

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  composers (cs: CompositeSwap): BufferComposer[] {
    return [
      ComposableBuffer.single<PoolSwap>(() => cs.poolSwap, v => cs.poolSwap = v, v => new CPoolSwap(v)),
      ComposableBuffer.compactSizeArray<PoolId>(() => cs.pools, v => cs.pools = v, v => new CPoolId(v))
    ]

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  composers (tdi: TransferDomainPair): BufferComposer[] {
    return [
      ComposableBuffer.single<TransferDomainItem>(() => tdi.src, v => tdi.src = v, v => new CTransferDomainItem(v)),
      ComposableBuffer.single<TransferDomainItem>(() => tdi.dst, v => tdi.dst = v, v => new CTransferDomainItem(v))
    ]

• Read up
  Read up

Function getSwapsHistory has 62 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  async getSwapsHistory (
    network: NetworkName,
    limit: number,
    nextToken: NextToken
  ): Promise<{ swaps: LegacySubgraphSwap[], next: NextToken }> {

Function setup has 61 lines of code (exceeds 25 allowed). Consider refactoring.

Open

async function setup (): Promise<void> {
  accountAlice = await alice.generateAddress()
  accountBob = await bob.generateAddress()

  await alice.token.create({

Function mapPoolPair has 60 lines of code (exceeds 25 allowed). Consider refactoring.

Open

  async mapPoolPair (
    id: string,
    info: PoolPairInfo,
    totalLiquidityUsd?: BigNumber,
    apr?: PoolPairData['apr'],

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    return latest.map(x => ({
      ...x,
      count: x.weeks === lockStats.weeks ? (x.count + lockStats.count) : x.count,
      tvl: x.weeks === lockStats.weeks ? new BigNumber(x.tvl).plus(lockStats.tvl).toFixed(8) : x.tvl
    }))

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

    return latest.map(x => ({
      ...x,
      count: x.weeks === lockStats.weeks ? (x.count - lockStats.count) : x.count,
      tvl: x.weeks === lockStats.weeks ? new BigNumber(x.tvl).minus(lockStats.tvl).toFixed(8) : x.tvl
    }))

• Read up
  Read up

Function setupLoanToken has 59 lines of code (exceeds 25 allowed). Consider refactoring.

Open

async function setupLoanToken (): Promise<void> {
  const oracleId = await testing.rpc.oracle.appointOracle(await testing.generateAddress(), [
    { token: 'DFI', currency: 'USD' },
    { token: 'LOAN', currency: 'USD' }
  ], { weightage: 1 })

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    {
      provide: WhaleApiClient,
      useFactory: (configService: ConfigService): WhaleApiClient => {
        return new WhaleApiClient({
          version: 'v0',

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

export function fromScriptP2PKH (script: Script, network: NetworkName): string | undefined {
  if (!isScriptP2PKH(script)) {
    return undefined
  }

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

export function fromScriptP2SH (script: Script, network: NetworkName): string | undefined {
  if (!isScriptP2SH(script)) {
    return undefined
  }

• Read up
  Read up

Identical blocks of code found in 2 locations. Consider refactoring.

Open

    {
      provide: WhaleApiClient,
      useFactory: (configService: ConfigService): WhaleApiClient => {
        return new WhaleApiClient({
          version: 'v0',

• Read up
  Read up

PoolPairService has 22 functions (exceeds 20 allowed). Consider refactoring.

Open

@Injectable()
export class PoolPairService {
  constructor (
    @Inject('NETWORK') protected readonly network: NetworkName,
    private readonly poolSwapPathfindingService: PoolSwapPathFindingService,

Similar blocks of code found in 3 locations. Consider refactoring.

Open

function isScriptP2WPKH (script: Script): boolean {
  return script.stack.length === 2 &&
    script.stack[0].type === OP_CODES.OP_0.type &&
    script.stack[1].type === 'OP_PUSHDATA' && (script.stack[1] as OP_PUSHDATA).length() === 20
}

• Read up
  Read up