Sign upLogin

DeFiCh/wallet

View on GitHub
Star
mobile-app/app/screens/AppNavigator/screens/Dex/DexAddLiquidity.tsx

Summary

Maintainability
F
4 days
Test Coverage

Function AddLiquidityScreen has 556 lines of code (exceeds 100 allowed). Consider refactoring.
Open

export function AddLiquidityScreen(props: Props): JSX.Element {
  const logger = useLogger();
  const navigation = useNavigation<NavigationProp<DexParamList>>();
  const dispatch = useAppDispatch();
  const DFIToken = useSelector((state: RootState) =>
Severity: Major
Found in mobile-app/app/screens/AppNavigator/screens/Dex/DexAddLiquidity.tsx - About 2 days to fix

    File DexAddLiquidity.tsx has 642 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import { PoolPairData } from "@defichain/whale-api-client/dist/api/poolpairs";
import { NavigationProp, useNavigation } from "@react-navigation/native";
import { StackScreenProps } from "@react-navigation/stack";
import BigNumber from "bignumber.js";
import { useCallback, useEffect, useMemo, useState } from "react";
    Severity: Major
    Found in mobile-app/app/screens/AppNavigator/screens/Dex/DexAddLiquidity.tsx - About 1 day to fix

      Function AddLiquidityScreen has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
      Open

      export function AddLiquidityScreen(props: Props): JSX.Element {
  const logger = useLogger();
  const navigation = useNavigation<NavigationProp<DexParamList>>();
  const dispatch = useAppDispatch();
  const DFIToken = useSelector((state: RootState) =>
      Severity: Minor
      Found in mobile-app/app/screens/AppNavigator/screens/Dex/DexAddLiquidity.tsx - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function canAddLiquidity has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        pair: ExtPoolPairData,
  tokenAAmount: BigNumber,
  tokenBAmount: BigNumber,
  balanceA: BigNumber | undefined,
  balanceB: BigNumber | undefined,
      Severity: Minor
      Found in mobile-app/app/screens/AppNavigator/screens/Dex/DexAddLiquidity.tsx - About 35 mins to fix

        There are no issues that match your filters.

        Category
        Status