Sign upLogin

DevelopingCoder/cs61a_hintr

View on GitHub
Star

Showing 456 of 456 total issues

Method cross_check_diffs has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def self.cross_check_diffs(file_t2c)
        #Returns a hash of additions and deletions.
        #Note the instances are in json form
        additions = []
        deletions = []
Severity: Minor
Found in app/models/tag2concept.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method seed_db has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

  def seed_db(qset_json)
    # seed db with qsets in json, expect it to be in same format as question.json
    # also assumes an empty database except for tags (doesn't check for new questions, qsets, or was)
    # so all tags in the seed json should be within tag1-tag10
    qset_json.each do |qset_name, question_json|
Severity: Minor
Found in features/support/seed_helper.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method import has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def self.import(csv_path)
        rows = CSV.read(csv_path)
        if not self.verify_first_line(rows[0])
            return false
        end
Severity: Minor
Found in app/models/tag2concept.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method aggregate_changes has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def aggregate_changes
    changes = {}
    confirmed_additions = params[:confirmed_additions]
    additions = []
    if confirmed_additions
Severity: Minor
Found in app/controllers/application_controller.rb - About 1 hr to fix

    Method sort_messages has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def sort_messages(sort_type, messages, is_hint)
    message_upvotes = {}
    message_downvotes = {}
    messages.each do |message|
        upvotes = 0
    Severity: Minor
    Found in app/controllers/application_controller.rb - About 1 hr to fix

      Method sort_messages has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        def sort_messages(sort_type, messages, is_hint)
    message_upvotes = {}
    message_downvotes = {}
    messages.each do |message|
        upvotes = 0
      Severity: Minor
      Found in app/controllers/application_controller.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File Content Disclosure in Action View
      Open

          actionview (4.2.6)
      Severity: Critical
      Found in Gemfile.lock by bundler-audit

      Advisory: CVE-2019-5418

      Criticality: High

      URL: https://groups.google.com/forum/#!topic/rubyonrails-security/pFRKI96Sm8Q

      Solution: upgrade to >= 4.2.11.1, ~> 4.2.11, >= 5.0.7.2, ~> 5.0.7, >= 5.1.6.2, ~> 5.1.6, >= 5.2.2.1, ~> 5.2.2, >= 6.0.0.beta3

      Possible information leak / session hijack vulnerability
      Open

          rack (1.6.4)
      Severity: Minor
      Found in Gemfile.lock by bundler-audit

      Advisory: CVE-2019-16782

      Criticality: Medium

      URL: https://github.com/rack/rack/security/advisories/GHSA-hrqr-hxpp-chr3

      Solution: upgrade to ~> 1.6.12, >= 2.0.8

      Broken Access Control vulnerability in Active Job
      Open

          activejob (4.2.6)
      Severity: Critical
      Found in Gemfile.lock by bundler-audit

      Advisory: CVE-2018-16476

      Criticality: High

      URL: https://groups.google.com/forum/#!topic/rubyonrails-security/FL4dSdzr2zw

      Solution: upgrade to ~> 4.2.11, ~> 5.0.7.1, ~> 5.1.6.1, ~> 5.1.7, >= 5.2.1.1

      Regular Expression Denial of Service in websocket-extensions (RubyGem)
      Open

          websocket-extensions (0.1.2)
      Severity: Critical
      Found in Gemfile.lock by bundler-audit

      Advisory: CVE-2020-7663

      Criticality: High

      URL: https://github.com/faye/websocket-extensions-ruby/security/advisories/GHSA-g6wq-qcwm-j5g2

      Solution: upgrade to >= 0.1.5

      Unsafe Query Generation Risk in Active Record
      Open

          activerecord (4.2.6)
      Severity: Critical
      Found in Gemfile.lock by bundler-audit

      Advisory: CVE-2016-6317

      Criticality: High

      URL: https://groups.google.com/forum/#!topic/rubyonrails-security/rgO20zYW33s

      Solution: upgrade to >= 4.2.7.1

      Denial of Service Vulnerability in Action View
      Open

          actionview (4.2.6)
      Severity: Critical
      Found in Gemfile.lock by bundler-audit

      Advisory: CVE-2019-5419

      Criticality: High

      URL: https://groups.google.com/forum/#!topic/rubyonrails-security/GN7w9fFAQeI

      Solution: upgrade to >= 6.0.0.beta3, >= 5.2.2.1, ~> 5.2.2, >= 5.1.6.2, ~> 5.1.6, >= 5.0.7.2, ~> 5.0.7, >= 4.2.11.1, ~> 4.2.11

      Path Traversal in Sprockets
      Open

          sprockets (3.7.0)
      Severity: Critical
      Found in Gemfile.lock by bundler-audit

      Advisory: CVE-2018-3760

      Criticality: High

      URL: https://groups.google.com/forum/#!topic/ruby-security-ann/2S9Pwz2i16k

      Solution: upgrade to < 3.0.0, >= 2.12.5, < 4.0.0, >= 3.7.2, >= 4.0.0.beta8

      Possible XSS Vulnerability in Action View
      Open

          actionview (4.2.6)
      Severity: Minor
      Found in Gemfile.lock by bundler-audit

      Advisory: CVE-2016-6316

      Criticality: Medium

      URL: https://groups.google.com/forum/#!topic/rubyonrails-security/I-VWr034ouk

      Solution: upgrade to ~> 4.2.7.1, ~> 4.2.8, >= 5.0.0.1

      Possible XSS vulnerability in Rack
      Open

          rack (1.6.4)
      Severity: Minor
      Found in Gemfile.lock by bundler-audit

      Advisory: CVE-2018-16471

      URL: https://groups.google.com/forum/#!topic/ruby-security-ann/NAalCee8n6o

      Solution: upgrade to ~> 1.6.11, >= 2.0.6

      Potential remote code execution of user-provided local names in ActionView
      Open

          actionview (4.2.6)
      Severity: Critical
      Found in Gemfile.lock by bundler-audit

      Advisory: CVE-2020-8163

      Criticality: High

      URL: https://groups.google.com/forum/#!topic/rubyonrails-security/hWuKcHyoKh0

      Solution: upgrade to >= 4.2.11.2

      XSS vulnerability in rails-html-sanitizer
      Open

          rails-html-sanitizer (1.0.3)
      Severity: Minor
      Found in Gemfile.lock by bundler-audit

      Advisory: CVE-2018-3741

      URL: https://groups.google.com/d/msg/rubyonrails-security/tP7W3kLc5u4/uDy2Br7xBgAJ

      Solution: upgrade to >= 1.0.4

      TZInfo relative path traversal vulnerability allows loading of arbitrary files
      Open

          tzinfo (1.2.2)
      Severity: Critical
      Found in Gemfile.lock by bundler-audit

      Advisory: CVE-2022-31163

      Criticality: High

      URL: https://github.com/tzinfo/tzinfo/security/advisories/GHSA-5cm2-9h8c-rvfx

      Solution: upgrade to ~> 0.3.61, >= 1.2.10

      Method import has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def self.import(csv_path)
        rows = CSV.read(csv_path)
        if not self.verify_first_line(rows[0])
            return false
        end
      Severity: Minor
      Found in app/models/concept.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method cross_check_diffs has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def self.cross_check_diffs(file_concepts)
        #Returns a hash of answers, edits, deletions. Answers and edits contains 
        #a message, which may be an empty string if we do not want to create a new message
        #Note the instances are in json form
        edits = []
      Severity: Minor
      Found in app/models/concept.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language