Method _invokeCallable has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected function _invokeCallable($callable, $args)
{
if (!is_callable($callable)) {
throw $this->_createInvalidArgumentException($this->__('Callable is not callable'), null, null, $callable);
}Function _invokeCallable has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
protected function _invokeCallable($callable, $args)
{
if (!is_callable($callable)) {
throw $this->_createInvalidArgumentException($this->__('Callable is not callable'), null, null, $callable);
}- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method _createInvocationException has 5 arguments (exceeds 4 allowed). Consider refactoring. Invalid
$message = null,
$code = null,
RootException $previous = null,
callable $callable = null,
$args = nullThe method _invokeCallable uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
return call_user_func_array($callable, $args);
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
The method _invokeCallable uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$target = is_object($callable[0])
? $callable[0]
: null;
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid using short method names like InvokeCallableCapableTrait::__(). The configured minimum method name length is 3. Open
abstract protected function __($string, $args = array(), $context = null);- Read upRead up
- Exclude checks
ShortMethodName
Since: 0.2
Detects when very short method names are used.
Example
class ShortMethod {
public function a( $index ) { // Violation
}
}Source https://phpmd.org/rules/naming.html#shortmethodname
The method _normalizeArray is not named in camelCase. Open
abstract protected function _normalizeArray($value);- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}Source
The method _invokeCallable is not named in camelCase. Open
protected function _invokeCallable($callable, $args)
{
if (!is_callable($callable)) {
throw $this->_createInvalidArgumentException($this->__('Callable is not callable'), null, null, $callable);
}- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}Source
The method __ is not named in camelCase. Open
abstract protected function __($string, $args = array(), $context = null);- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}Source
The method _createInvocationException is not named in camelCase. Open
abstract protected function _createInvocationException(
$message = null,
$code = null,
RootException $previous = null,
callable $callable = null,- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}Source
The method _createInternalException is not named in camelCase. Open
abstract protected function _createInternalException(
$message = null,
$code = null,
RootException $previous = null
);- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}Source
The method _createInvalidArgumentException is not named in camelCase. Open
abstract protected function _createInvalidArgumentException(
$message = null,
$code = null,
RootException $previous = null,
$argument = null- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}Source
The method _validateParams is not named in camelCase. Open
abstract protected function _validateParams($args, $spec);- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}Source
The method _createReflectionForCallable is not named in camelCase. Open
abstract protected function _createReflectionForCallable($callable);- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}