Dhii/callback-abstract

View on GitHub
src/NormalizeCallableCapableTrait.php

Summary

Maintainability
A
35 mins
Test Coverage

Function _normalizeCallable has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    public function _normalizeCallable($callable)
    {
        // Closure remains as such
        if ($callable instanceof Closure) {
            return $callable;
Severity: Minor
Found in src/NormalizeCallableCapableTrait.php - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

The method _normalizeCallable is not named in camelCase.
Open

    public function _normalizeCallable($callable)
    {
        // Closure remains as such
        if ($callable instanceof Closure) {
            return $callable;
Severity: Minor
Found in src/NormalizeCallableCapableTrait.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _normalizeMethodCallable is not named in camelCase.
Open

    abstract protected function _normalizeMethodCallable($callable);
Severity: Minor
Found in src/NormalizeCallableCapableTrait.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

The method _normalizeString is not named in camelCase.
Open

    abstract protected function _normalizeString($subject);
Severity: Minor
Found in src/NormalizeCallableCapableTrait.php by phpmd

CamelCaseMethodName

Since: 0.2

It is considered best practice to use the camelCase notation to name methods.

Example

class ClassName {
    public function get_name() {
    }
}

Source

There are no issues that match your filters.

Category
Status