Sign upLogin

Discord-InterChat/InterChat

View on GitHub
Star

Showing 82 of 97 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

  async getHubByName(name: string) {
    return await this.db.hub.findFirst({ where: { name } });
  }
Severity: Minor
Found in src/services/HubService.ts and 2 other locations - About 35 mins to fix
src/services/HubService.ts on lines 20..22
src/services/HubService.ts on lines 52..54

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 46.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid too many return statements within this function.
Open

          return;
Severity: Major
Found in src/commands/slash/Main/hub/invite.ts - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

              return;
    Severity: Major
    Found in src/commands/slash/Main/hub/invite.ts - About 30 mins to fix

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          if (!channelId || !connection) {
      await interaction.reply({
        content: t('connection.channelNotFound', locale, { emoji: emojis.no }),
        ephemeral: true,
      });
      Severity: Major
      Found in src/commands/slash/Main/connection/edit.ts and 3 other locations - About 30 mins to fix
      src/commands/slash/Main/connection/edit.ts on lines 93..99
      src/commands/slash/Main/connection/edit.ts on lines 111..117
      src/commands/slash/Main/hub/invite.ts on lines 91..97

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 45.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Avoid too many return statements within this function.
      Open

          return { isValid: true };
      Severity: Major
      Found in src/modules/HubValidator.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            if (Object.keys(dbReactions).length >= 10) return;
        Severity: Major
        Found in src/events/messageReactionAdd.ts - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return;
          Severity: Major
          Found in src/core/BasePrefixCommand.ts - About 30 mins to fix

            Similar blocks of code found in 4 locations. Consider refactoring.
            Open

                  if (!Constants.Regex.Hexcode.test(embedColor)) {
        await interaction.reply({
          content: t('connection.emColorInvalid', locale, { emoji: emojis.no }),
          ephemeral: true,
        });
            Severity: Major
            Found in src/commands/slash/Main/connection/edit.ts and 3 other locations - About 30 mins to fix
            src/commands/slash/Main/connection/edit.ts on lines 93..99
            src/commands/slash/Main/connection/edit.ts on lines 165..171
            src/commands/slash/Main/hub/invite.ts on lines 91..97

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Avoid too many return statements within this function.
            Open

                return null;
            Severity: Major
            Found in src/commands/slash/Main/hub/logging.ts - About 30 mins to fix

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                    if (fetchedInvite?.guild?.id !== interaction.guildId) {
        await interaction.followUp({
          content: t('connection.inviteInvalid', locale, { emoji: emojis.no }),
          ephemeral: true,
        });
              Severity: Major
              Found in src/commands/slash/Main/connection/edit.ts and 3 other locations - About 30 mins to fix
              src/commands/slash/Main/connection/edit.ts on lines 111..117
              src/commands/slash/Main/connection/edit.ts on lines 165..171
              src/commands/slash/Main/hub/invite.ts on lines 91..97

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 45.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Avoid too many return statements within this function.
              Open

                  return true;
              Severity: Major
              Found in src/commands/slash/Main/blacklist/user.ts - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                    return true;
                Severity: Major
                Found in src/services/HubJoinService.ts - About 30 mins to fix

                  Similar blocks of code found in 4 locations. Consider refactoring.
                  Open

                          if (!inviteInDb) {
          await interaction.reply({
            content: t('hub.invite.revoke.invalidCode', locale, { emoji: emojis.no }),
            ephemeral: true,
          });
                  Severity: Major
                  Found in src/commands/slash/Main/hub/invite.ts and 3 other locations - About 30 mins to fix
                  src/commands/slash/Main/connection/edit.ts on lines 93..99
                  src/commands/slash/Main/connection/edit.ts on lines 111..117
                  src/commands/slash/Main/connection/edit.ts on lines 165..171

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 45.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Function run has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                    protected async run(message: Message<true>, args: string[]) {
    const msgId = message.reference?.messageId ?? getMessageIdFromStr(args[0]);
    const originalMessage = msgId
      ? ((await this.getOriginalMessage(msgId)) ?? (await findOriginalMessage(msgId)))
      : null;
                  Severity: Minor
                  Found in src/commands/prefix/modpanel.ts - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function format has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                    format(
    message: Message<true>,
    connection: connectedList,
    opts: DefaultFormaterOpts,
  ): WebhookMessageCreateOptions {
                  Severity: Minor
                  Found in src/services/formatters/CompactMsgFormatter.ts - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function handleHubSetupButton has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                    @RegisterInteractionHandler('setupHub')
  public async handleHubSetupButton(interaction: ButtonInteraction) {
    if (!interaction.inCachedGuild()) return;

    const hubJoinService = new HubJoinService(interaction, await this.getLocale(interaction));
                  Severity: Minor
                  Found in src/commands/slash/Main/setup.ts - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function cacheConnectionHubId has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                  const cacheConnectionHubId = async (...connections: connectedList[]) => {
  const keysToDelete: string[] = [];
  const cachePromises: Promise<void>[] = [];

  // Single pass through the data
                  Severity: Minor
                  Found in src/utils/ConnectedListUtils.ts - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function runChecks has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                  export const runChecks = async (
  message: Message<true>,
  hub: Hub & { msgBlockList: MessageBlockList[] },
  opts: {
    userData: UserData;
                  Severity: Minor
                  Found in src/utils/network/runChecks.ts - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function handleSetLogConfig has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                    private async handleSetLogConfig({
    hubId,
    logType,
    target,
    setType,
                  Severity: Minor
                  Found in src/commands/slash/Main/hub/logging.ts - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function hasExceededLimit has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                  Open

                    public async hasExceededLimit() {
    const { usesLeft, fromCache } = await this.getRemainingUses();

    if (!fromCache) {
      const dbUser = await this.userManager.getUser(this.userId);
                  Severity: Minor
                  Found in src/modules/VoteBasedLimiter.ts - About 25 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Severity
                  Category
                  Status
                  Source
                  Language