DrFelder/ppr

View on GitHub

Showing 62 of 62 total issues

Method equals has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    @Override
    public boolean equals(Object o) {
        if (this == o) return true;
        if (o == null || getClass() != o.getClass()) return false;

Severity: Minor
Found in src/main/java/is/surreal/ppr/model/Notificationread.java - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function cssLoaders has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

exports.cssLoaders = function (options) {
  options = options || {}

  const cssLoader = {
    loader: 'css-loader',
Severity: Minor
Found in frontend/build/utils.js - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

        if (password != null ? !password.equals(user.password) : user.password != null) return false;
Severity: Major
Found in src/main/java/is/surreal/ppr/model/User.java - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

            if (operationId != null ? !operationId.equals(helper.operationId) : helper.operationId != null) return false;
    Severity: Major
    Found in src/main/java/is/surreal/ppr/model/Helper.java - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                  return false;
      Severity: Major
      Found in src/main/java/is/surreal/ppr/model/Operation.java - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                if (city != null ? !city.equals(address.city) : address.city != null) return false;
        Severity: Major
        Found in src/main/java/is/surreal/ppr/model/Address.java - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  return true;
          Severity: Major
          Found in src/main/java/is/surreal/ppr/model/User.java - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    return true;
            Severity: Major
            Found in src/main/java/is/surreal/ppr/model/Helper.java - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                      if (declined != null ? !declined.equals(that.declined) : that.declined != null) return false;
              Severity: Major
              Found in src/main/java/is/surreal/ppr/model/Operationparticipation.java - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                        if (userdataId != null ? !userdataId.equals(user.userdataId) : user.userdataId != null) return false;
                Severity: Major
                Found in src/main/java/is/surreal/ppr/model/User.java - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                          if (addressId != null ? !addressId.equals(userdata.addressId) : userdata.addressId != null) return false;
                  Severity: Major
                  Found in src/main/java/is/surreal/ppr/model/Userdata.java - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                            return true;
                    Severity: Major
                    Found in src/main/java/is/surreal/ppr/model/Notificationread.java - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                  return false;
                      Severity: Major
                      Found in src/main/java/is/surreal/ppr/model/Address.java - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                if (accepted != null ? !accepted.equals(that.accepted) : that.accepted != null) return false;
                        Severity: Major
                        Found in src/main/java/is/surreal/ppr/model/Operationparticipation.java - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                  if (roles != null ? !roles.equals(user.roles) : user.roles != null) return false;
                          Severity: Major
                          Found in src/main/java/is/surreal/ppr/model/User.java - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                        return false;
                            Severity: Major
                            Found in src/main/java/is/surreal/ppr/model/Equipment.java - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                      if (email != null ? !email.equals(user.email) : user.email != null) return false;
                              Severity: Major
                              Found in src/main/java/is/surreal/ppr/model/User.java - About 30 mins to fix

                                Avoid too many return statements within this method.
                                Open

                                        return "WATCHER";

                                  Avoid too many return statements within this method.
                                  Open

                                          if (date != null ? !date.equals(operation.date) : operation.date != null) return false;
                                  Severity: Major
                                  Found in src/main/java/is/surreal/ppr/model/Operation.java - About 30 mins to fix

                                    Avoid too many return statements within this method.
                                    Open

                                            if (state != null ? !state.equals(address.state) : address.state != null) return false;
                                    Severity: Major
                                    Found in src/main/java/is/surreal/ppr/model/Address.java - About 30 mins to fix
                                      Severity
                                      Category
                                      Status
                                      Source
                                      Language