DrFelder/ppr

View on GitHub
src/main/java/is/surreal/ppr/model/User.java

Summary

Maintainability
C
1 day
Test Coverage

Method equals has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

    @Override
    public boolean equals(Object o) {
        if (this == o) return true;
        if (o == null || getClass() != o.getClass()) return false;

Severity: Minor
Found in src/main/java/is/surreal/ppr/model/User.java - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

User has 21 methods (exceeds 20 allowed). Consider refactoring.
Open

@Entity
public class User {
    private Long id;
    private String username;
    private String password;
Severity: Minor
Found in src/main/java/is/surreal/ppr/model/User.java - About 2 hrs to fix

    Avoid too many return statements within this method.
    Open

            if (password != null ? !password.equals(user.password) : user.password != null) return false;
    Severity: Major
    Found in src/main/java/is/surreal/ppr/model/User.java - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              return true;
      Severity: Major
      Found in src/main/java/is/surreal/ppr/model/User.java - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                if (userdataId != null ? !userdataId.equals(user.userdataId) : user.userdataId != null) return false;
        Severity: Major
        Found in src/main/java/is/surreal/ppr/model/User.java - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  if (roles != null ? !roles.equals(user.roles) : user.roles != null) return false;
          Severity: Major
          Found in src/main/java/is/surreal/ppr/model/User.java - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    if (email != null ? !email.equals(user.email) : user.email != null) return false;
            Severity: Major
            Found in src/main/java/is/surreal/ppr/model/User.java - About 30 mins to fix

              There are no issues that match your filters.

              Category
              Status