Sign upLogin

EscolaLMS/Auth

View on GitHub
Star

Showing 33 of 33 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public function updateUserInterests(UserInterestsUpdateRequest $request): JsonResponse
    {
        $user = $this->fetchRequestedUser($request);
        $dto = UserUpdateInterestsDto::instantiateFromRequest($request);
        try {
Severity: Major
Found in src/Http/Controllers/Admin/UserInterestsController.php and 2 other locations - About 55 mins to fix
src/Http/Controllers/Admin/UserSettingsController.php on lines 22..32
src/Http/Controllers/Admin/UserSettingsController.php on lines 34..44

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 99.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public function putUserSettings(UserSettingsUpdateRequest $request): JsonResponse
    {
        $user = $this->fetchRequestedUser($request);
        $dto = UserUpdateSettingsDto::instantiateFromRequest($request);
        try {
Severity: Major
Found in src/Http/Controllers/Admin/UserSettingsController.php and 2 other locations - About 55 mins to fix
src/Http/Controllers/Admin/UserInterestsController.php on lines 24..34
src/Http/Controllers/Admin/UserSettingsController.php on lines 22..32

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 99.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function deleteUserInterest(UserInterestDeleteRequest $request): JsonResponse
    {
        $user = $this->fetchRequestedUser($request);
        $interest_id = $request->validated()['interest_id'];
        try {
Severity: Minor
Found in src/Http/Controllers/Admin/UserInterestsController.php and 1 other location - About 55 mins to fix
src/Http/Controllers/Admin/UserInterestsController.php on lines 36..46

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 99.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method searchAndPaginate has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

        CriteriaDto $criteriaDto,
        ?array $columns = [],
        ?array $with = [],
        ?array $appends = [],
        ?int $perPage = null,
Severity: Major
Found in src/Services/Contracts/UserServiceContract.php - About 50 mins to fix

    Method searchAndPaginate has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            CriteriaDto $criteriaDto,
        ?array $columns = [],
        ?array $with = [],
        ?array $appends = [],
        ?int $perPage = null,
    Severity: Major
    Found in src/Services/UserService.php - About 50 mins to fix

      Function instantiateFromRequest has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function instantiateFromRequest(Request $request, bool $tree = false): self
    {
        $criteria = new Collection();

        if (
      Severity: Minor
      Found in src/Dtos/UserGroupFilterCriteriaDto.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function askUserPassword has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function askUserPassword(bool $required = false)
    {
        $default = $required ? Str::random() : '';
        while (1) {
            $password = $this->ask('Password', $default);
      Severity: Minor
      Found in src/Console/Commands/CreateAdminCommand.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method searchAndPaginate has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          public function searchAndPaginate(CriteriaDto $criteriaDto, array $appends = [], int $perPage = null, int $page = null, ?OrderDto $orderDto = null): LengthAwarePaginator;
      Severity: Minor
      Found in src/Services/Contracts/UserGroupServiceContract.php - About 35 mins to fix

        Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

                AuthServiceContract $authService,
        UserServiceContract $userService,
        SocialAccountRepositoryContract $socialAccountRepository,
        UserRepositoryContract $userRepository,
        PreUserRepositoryContract $preUserRepository
        Severity: Minor
        Found in src/Services/SocialAccountService.php - About 35 mins to fix

          Method searchAndPaginate has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public function searchAndPaginate(CriteriaDto $criteriaDto, array $appends = [], int $perPage = null, int $page = null, ?OrderDto $orderDto = null): LengthAwarePaginator
          Severity: Minor
          Found in src/Services/UserGroupService.php - About 35 mins to fix

            Function handle has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                public function handle(AccountDeleted $event): void
    {
        $user = $event->getUser();
        
        $columns = $this->getProcessableColumns($user);
            Severity: Minor
            Found in src/Listeners/MaskUserData.php - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function searchNameWithBreadcrumbs has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                private function searchNameWithBreadcrumbs(Builder $q, string $driver, string $like): Builder
    {
        $cast = 'name::varchar';
        // check mysql version
        if ($driver !== 'pgsql') {
            Severity: Minor
            Found in src/Repositories/Criteria/UserGroupSearchCriterion.php - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function login has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                public function login(string $email, string $password): User
    {

        $user = $this->userRepository->findByEmail($email);
            Severity: Minor
            Found in src/Services/UserService.php - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language