Sign upLogin

EscolaLMS/Auth

View on GitHub
Star
src/Services/UserService.php

Summary

Maintainability
B
6 hrs
Test Coverage
B
88%

UserService has 22 functions (exceeds 20 allowed). Consider refactoring.
Open

class UserService implements UserServiceContract
{
    private UserRepositoryContract $userRepository;

    /**
Severity: Minor
Found in src/Services/UserService.php - About 2 hrs to fix

    Function patchUsingDto has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        public function patchUsingDto(UserUpdateDto $dto, UserUpdateKeysDto $keysDto, int $id): User
    {
        $data = $dto->toArray();

        $user = $this->userRepository->update($data, $id);
    Severity: Minor
    Found in src/Services/UserService.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function putUsingDto has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        public function putUsingDto(UserUpdateDto $dto, int $id): User
    {
        $data = $dto->toArray();

        $user = $this->userRepository->update($data, $id);
    Severity: Minor
    Found in src/Services/UserService.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method searchAndPaginate has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            CriteriaDto $criteriaDto,
        ?array $columns = [],
        ?array $with = [],
        ?array $appends = [],
        ?int $perPage = null,
    Severity: Major
    Found in src/Services/UserService.php - About 50 mins to fix

      Function login has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public function login(string $email, string $password): User
    {

        $user = $this->userRepository->findByEmail($email);
      Severity: Minor
      Found in src/Services/UserService.php - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status