Sign upLogin

EscolaLMS/H5P

View on GitHub
Star
src/Services/H5PCoreService.php

Summary

Maintainability
C
7 hrs
Test Coverage
F
52%

Function filterParameters has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

    public function filterParameters(&$content)
    {
        if (!empty($content['filtered']) &&
            (!$this->exportEnabled ||
                ($content['slug'] &&
Severity: Minor
Found in src/Services/H5PCoreService.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method filterParameters has 51 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function filterParameters(&$content)
    {
        if (!empty($content['filtered']) &&
            (!$this->exportEnabled ||
                ($content['slug'] &&
Severity: Major
Found in src/Services/H5PCoreService.php - About 2 hrs to fix

    Function textAddonMatches has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        private function textAddonMatches($params, $pattern, $found = false) {
        $type = gettype($params);
        if ($type === 'string') {
            if (preg_match($pattern, $params) === 1) {
                return true;
    Severity: Minor
    Found in src/Services/H5PCoreService.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function __construct(H5PFrameworkInterface $H5PFramework, $path, $url, $language = 'en', $export = FALSE)
    Severity: Minor
    Found in src/Services/H5PCoreService.php - About 35 mins to fix

      Function generateContentSlug has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          private function generateContentSlug($content) {
        $slug = H5PCore::slugify($content['title']);

        $available = NULL;
        while (!$available) {
      Severity: Minor
      Found in src/Services/H5PCoreService.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status