Sign upLogin

FabrizioBrancati/BFKit-Swift

View on GitHub
Star
Sources/BFKit/Apple/BFKit/BFBiometrics.swift

Summary

Maintainability
C
7 hrs
Test Coverage

Function handleErrorOS9 has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    @available(iOS 9.0, *)
    private static func handleErrorOS9(_ error: NSError) -> Result {
        if #available(iOS 11.0, *) {
            return handleErrorOS11(error)
        } else {
Severity: Minor
Found in Sources/BFKit/Apple/BFKit/BFBiometrics.swift - About 1 hr to fix

    Function handleErrorOS11 has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        @available(iOS 11.0, *)
    private static func handleErrorOS11(_ error: NSError) -> Result {
        switch error {
        case LAError.authenticationFailed:
            return .authenticationFailed
    Severity: Minor
    Found in Sources/BFKit/Apple/BFKit/BFBiometrics.swift - About 1 hr to fix

      Function useBiometric has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          public static func useBiometric(localizedReason: String, fallbackTitle: String? = nil, completion: @escaping (_ result: Result) -> Void) {
        let context = LAContext()
        
        context.localizedFallbackTitle = fallbackTitle
      Severity: Minor
      Found in Sources/BFKit/Apple/BFKit/BFBiometrics.swift - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function should have complexity 10 or less: currently complexity equals 12
      Open

          private static func handleErrorOS11(_ error: NSError) -> Result {
      Severity: Minor
      Found in Sources/BFKit/Apple/BFKit/BFBiometrics.swift by swiftlint

      Function should have complexity 10 or less: currently complexity equals 13
      Open

          private static func handleErrorOS9(_ error: NSError) -> Result {
      Severity: Minor
      Found in Sources/BFKit/Apple/BFKit/BFBiometrics.swift by swiftlint

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          private static func handleErrorOS11(_ error: NSError) -> Result {
        switch error {
        case LAError.authenticationFailed:
            return .authenticationFailed
      Severity: Major
      Found in Sources/BFKit/Apple/BFKit/BFBiometrics.swift and 1 other location - About 2 hrs to fix
      Sources/BFKit/Apple/BFKit/BFBiometrics.swift on lines 173..211

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 154.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              } else {
            switch error {
            case LAError.authenticationFailed:
                return .authenticationFailed
      Severity: Major
      Found in Sources/BFKit/Apple/BFKit/BFBiometrics.swift and 1 other location - About 2 hrs to fix
      Sources/BFKit/Apple/BFKit/BFBiometrics.swift on lines 125..163

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 154.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status