Fantom-foundation/go-lachesis

View on GitHub
kvdb/flushable/flushable.go

Summary

Maintainability
B
6 hrs
Test Coverage

Method iterator.Next has a Cognitive Complexity of 46 (exceeds 20 allowed). Consider refactoring.
Open

func (it *iterator) Next() bool {
    it.lock.Lock()
    defer it.lock.Unlock()

    if it.Error() != nil {
Severity: Minor
Found in kvdb/flushable/flushable.go - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method iterator.Next has 61 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (it *iterator) Next() bool {
    it.lock.Lock()
    defer it.lock.Unlock()

    if it.Error() != nil {
Severity: Minor
Found in kvdb/flushable/flushable.go - About 1 hr to fix

    Method iterator.Next has 6 return statements (exceeds 4 allowed).
    Open

    func (it *iterator) Next() bool {
        it.lock.Lock()
        defer it.lock.Unlock()
    
        if it.Error() != nil {
    Severity: Major
    Found in kvdb/flushable/flushable.go - About 40 mins to fix

      There are no issues that match your filters.

      Category
      Status