FezVrasta/popper.js

View on GitHub

Showing 329 of 329 total issues

Function Composite has a Cognitive Complexity of 56 (exceeds 5 allowed). Consider refactoring.
Open

>(function Composite(props, forwardedRef) {
  const {
    render,
    orientation = 'both',
    loop = true,
Severity: Minor
Found in packages/react/src/components/Composite.tsx - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

export type {
  AlignedPlacement,
  Alignment,
  ArrowOptions,
  AutoPlacementOptions,
Severity: Major
Found in packages/react/src/types.ts and 1 other location - About 1 day to fix
packages/react-dom/src/types.ts on lines 11..52

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 204.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

export type {
  AlignedPlacement,
  Alignment,
  AutoPlacementOptions,
  AutoUpdateOptions,
Severity: Major
Found in packages/react-dom/src/types.ts and 1 other location - About 1 day to fix
packages/react/src/types.ts on lines 39..80

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 204.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

File PositioningDemos.js has 506 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import {
  getOverflowAncestors,
  offset,
  shift,
  useFloating,
Severity: Major
Found in website/lib/components/Home/PositioningDemos.js - About 1 day to fix

Function PackageSelect has 187 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function PackageSelect() {
  const {
    packageContext,
    isPackageTooltipTouched,
    setIsPackageTooltipTouched,
Severity: Major
Found in website/lib/components/PackageSelect.js - About 7 hrs to fix

Function commonOnKeyDown has 172 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  const commonOnKeyDown = useEffectEvent((event: React.KeyboardEvent) => {
    isPointerModalityRef.current = false;
    forceSyncFocus.current = true;

    // When composing a character, Chrome fires ArrowDown twice. Firefox/Safari
Severity: Major
Found in packages/react/src/hooks/useListNavigation.ts - About 6 hrs to fix

Function Composite has 167 lines of code (exceeds 25 allowed). Consider refactoring.
Open

>(function Composite(props, forwardedRef) {
  const {
    render,
    orientation = 'both',
    loop = true,
Severity: Major
Found in packages/react/src/components/Composite.tsx - About 6 hrs to fix

File PackageSelect.js has 440 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import {
  Composite,
  CompositeItem,
  FloatingArrow,
  FloatingFocusManager,
Severity: Minor
Found in website/lib/components/PackageSelect.js - About 6 hrs to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      {Object.entries({
        strategy,
        coords: {x, y},
        initialPlacement,
        placement,
extension/src/views/floating-ui/FloatingUIMiddleware.tsx on lines 36..62

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 162.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

      {Object.entries({
        initialPlacement,
        middlewareData,
        y,
        x,
Severity: Major
Found in extension/src/views/floating-ui/FloatingUIMiddleware.tsx and 1 other location - About 6 hrs to fix
extension/src/views/fluentui/components/FluentUIMiddleware.tsx on lines 80..106

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 162.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function useTypeahead has a Cognitive Complexity of 41 (exceeds 5 allowed). Consider refactoring.
Open

export function useTypeahead(
  context: FloatingRootContext,
  props: UseTypeaheadProps,
): ElementProps {
  const {open, dataRef} = context;
Severity: Minor
Found in packages/react/src/hooks/useTypeahead.ts - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function useFocus has a Cognitive Complexity of 41 (exceeds 5 allowed). Consider refactoring.
Open

export function useFocus(
  context: FloatingRootContext,
  props: UseFocusProps = {},
): ElementProps {
  const {open, onOpenChange, events, dataRef, elements} = context;
Severity: Minor
Found in packages/react/src/hooks/useFocus.ts - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  return {
    name: 'arrow',
    options,
    fn(state) {
      const {element, padding} =
Severity: Major
Found in packages/react-dom/src/arrow.ts and 1 other location - About 6 hrs to fix
packages/react-native/src/arrow.ts on lines 18..39

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 158.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

  return {
    name: 'arrow',
    options,
    fn(state) {
      const {element, padding} =
Severity: Major
Found in packages/react-native/src/arrow.ts and 1 other location - About 6 hrs to fix
packages/react-dom/src/arrow.ts on lines 32..53

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 158.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function getPolygon has 150 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      function getPolygon([x, y]: Point): Array<Point> {
        switch (side) {
          case 'top': {
            const cursorPointOne: Point = [
              isFloatingWider
Severity: Major
Found in packages/react/src/safePolygon.ts - About 6 hrs to fix

Function useFloating has 148 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function useFloating<RT extends ReferenceType = ReferenceType>(
  options: UseFloatingOptions = {},
): UseFloatingReturn<RT> {
  const {
    placement = 'bottom',
Severity: Major
Found in packages/react-dom/src/useFloating.ts - About 5 hrs to fix

Function flip has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
Open

export const flip = (
  options: FlipOptions | Derivable<FlipOptions> = {},
): Middleware => ({
  name: 'flip',
  options,
Severity: Minor
Found in packages/core/src/middleware/flip.ts - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function useFloating has 147 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function useFloating(
  options: UseFloatingOptions = {},
): UseFloatingReturn {
  const {
    placement = 'bottom',
Severity: Major
Found in packages/react-native/src/useFloating.ts - About 5 hrs to fix

Function ComboboxDemo has 145 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function ComboboxDemo() {
  const [open, setOpen] = useState(false);
  const [inputValue, setInputValue] = useState('');
  const [activeIndex, setActiveIndex] = useState(null);
  const [padding, setPadding] = useState(25);
Severity: Major
Found in website/lib/components/Home/Combobox.js - About 5 hrs to fix

Function Placement has 144 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function Placement() {
  const [placement, setPlacement] = useState('top');

  return (
    <GridItem
Severity: Major
Found in website/lib/components/Home/PositioningDemos.js - About 5 hrs to fix
Severity
Category
Status
Source
Language