Sign upLogin

FezVrasta/popper.js

View on GitHub
Star
packages/react/src/hooks/useDismiss.ts

Summary

Maintainability
F
4 days
Test Coverage

Function useDismiss has 282 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function useDismiss<RT extends ReferenceType = ReferenceType>(
  context: FloatingContext<RT>,
  props: UseDismissProps = {},
): ElementProps {
  const {
Severity: Major
Found in packages/react/src/hooks/useDismiss.ts - About 1 day to fix

Function useDismiss has a Cognitive Complexity of 60 (exceeds 5 allowed). Consider refactoring.
Open

export function useDismiss<RT extends ReferenceType = ReferenceType>(
  context: FloatingContext<RT>,
  props: UseDismissProps = {},
): ElementProps {
  const {
Severity: Minor
Found in packages/react/src/hooks/useDismiss.ts - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File useDismiss.ts has 344 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import {
  contains,
  getDocument,
  getTarget,
  isEventTargetWithin,
Severity: Minor
Found in packages/react/src/hooks/useDismiss.ts - About 4 hrs to fix

Function closeOnPressOutside has 80 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  const closeOnPressOutside = useEffectEvent((event: MouseEvent) => {
    // Given developers can stop the propagation of the synthetic event,
    // we can only be confident with a positive value.
    const insideReactTree = insideReactTreeRef.current;
    insideReactTreeRef.current = false;
Severity: Major
Found in packages/react/src/hooks/useDismiss.ts - About 3 hrs to fix

Function closeOnEscapeKeyDown has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    (event: React.KeyboardEvent<Element> | KeyboardEvent) => {
      if (!open || !enabled || !escapeKey || event.key !== 'Escape') {
        return;
      }
Severity: Minor
Found in packages/react/src/hooks/useDismiss.ts - About 1 hr to fix

Avoid too many return statements within this function.
Open

      return;
Severity: Major
Found in packages/react/src/hooks/useDismiss.ts - About 30 mins to fix

Avoid too many return statements within this function.
Open

        return;
Severity: Major
Found in packages/react/src/hooks/useDismiss.ts - About 30 mins to fix

Avoid too many return statements within this function.
Open

        return;
Severity: Major
Found in packages/react/src/hooks/useDismiss.ts - About 30 mins to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if (children.length > 0) {
          let shouldDismiss = true;

          children.forEach((child) => {
            if (
Severity: Major
Found in packages/react/src/hooks/useDismiss.ts and 1 other location - About 2 hrs to fix
packages/react/src/hooks/useDismiss.ts on lines 308..324

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 94.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    if (children.length > 0) {
      let shouldDismiss = true;

      children.forEach((child) => {
        if (
Severity: Major
Found in packages/react/src/hooks/useDismiss.ts and 1 other location - About 2 hrs to fix
packages/react/src/hooks/useDismiss.ts on lines 174..190

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 94.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status