Sign upLogin

FezVrasta/popper.js

View on GitHub
Star
packages/react/src/hooks/useListNavigation.ts

Summary

Maintainability
F
1 wk
Test Coverage

Function useListNavigation has 587 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function useListNavigation<RT extends ReferenceType = ReferenceType>(
  context: FloatingContext<RT>,
  props: UseListNavigationProps,
): ElementProps {
  const {
Severity: Major
Found in packages/react/src/hooks/useListNavigation.ts - About 2 days to fix

File useListNavigation.ts has 712 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import {
  activeElement,
  contains,
  getDocument,
  isMac,
Severity: Major
Found in packages/react/src/hooks/useListNavigation.ts - About 1 day to fix

Function useListNavigation has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
Open

export function useListNavigation<RT extends ReferenceType = ReferenceType>(
  context: FloatingContext<RT>,
  props: UseListNavigationProps,
): ElementProps {
  const {
Severity: Minor
Found in packages/react/src/hooks/useListNavigation.ts - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function onKeyDown has 152 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function onKeyDown(event: React.KeyboardEvent) {
      isPointerModalityRef.current = false;
      forceSyncFocus.current = true;

      // If the floating element is animating out, ignore navigation. Otherwise,
Severity: Major
Found in packages/react/src/hooks/useListNavigation.ts - About 6 hrs to fix

Function onKeyDown has 95 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        onKeyDown(event) {
          isPointerModalityRef.current = false;

          const isArrowKey = event.key.indexOf('Arrow') === 0;
          const isCrossOpenKey = isCrossOrientationOpenKey(
Severity: Major
Found in packages/react/src/hooks/useListNavigation.ts - About 3 hrs to fix

Function focusItem has 31 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    (
      listRef: React.MutableRefObject<Array<HTMLElement | null>>,
      indexRef: React.MutableRefObject<number>,
      forceScrollIntoView = false,
    ) => {
Severity: Minor
Found in packages/react/src/hooks/useListNavigation.ts - About 1 hr to fix

Function item has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  const item = React.useMemo(() => {
    function syncCurrentTarget(currentTarget: HTMLElement | null) {
      if (!open) return;
      const index = listRef.current.indexOf(currentTarget);
      if (index !== -1) {
Severity: Minor
Found in packages/react/src/hooks/useListNavigation.ts - About 1 hr to fix

Avoid deeply nested control flow statements.
Open

              if (runs < 2) {
                const scheduler = runs ? requestAnimationFrame : queueMicrotask;
                scheduler(waitForListPopulated);
              }
Severity: Major
Found in packages/react/src/hooks/useListNavigation.ts - About 45 mins to fix

Similar blocks of code found in 2 locations. Consider refactoring.
Open

function isCrossOrientationCloseKey(
  key: string,
  orientation: UseListNavigationProps['orientation'],
  rtl: boolean,
) {
Severity: Major
Found in packages/react/src/hooks/useListNavigation.ts and 1 other location - About 1 hr to fix
packages/react/src/hooks/useListNavigation.ts on lines 87..95

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 72.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

function isCrossOrientationOpenKey(
  key: string,
  orientation: UseListNavigationProps['orientation'],
  rtl: boolean,
) {
Severity: Major
Found in packages/react/src/hooks/useListNavigation.ts and 1 other location - About 1 hr to fix
packages/react/src/hooks/useListNavigation.ts on lines 97..105

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 72.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        const maxGridIndex = cellMap.reduce(
          (foundIndex: number, index, cellIndex) =>
            index != null && !disabledIndices?.includes(index)
              ? cellIndex
              : foundIndex,
Severity: Minor
Found in packages/react/src/hooks/useListNavigation.ts and 1 other location - About 55 mins to fix
packages/react/src/components/Composite.tsx on lines 163..169

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        const sizes =
          itemSizes ||
          Array.from({length: listRef.current.length}, () => ({
            width: 1,
            height: 1,
Severity: Minor
Found in packages/react/src/hooks/useListNavigation.ts and 1 other location - About 50 mins to fix
packages/react/src/components/Composite.tsx on lines 150..155

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 51.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status