Sign upLogin

FitnessKeeper/leeroy

View on GitHub
Star

Showing 89 of 89 total issues

Unused method argument - env. If it's necessary, use _ or _env as an argument name to indicate that it won't be used.
Open

      def _resolveResources(state = self.state, env = self.env, ec2 = self.ec2, options = self.options)
Severity: Minor
Found in lib/leeroy/task/instantiate.rb by rubocop

This cop checks for unused method arguments.

Example:

# bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

Example:

# good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

Unused method argument - ec2. If it's necessary, use _ or _ec2 as an argument name to indicate that it won't be used.
Open

      def _genInstanceParams(state = self.state, env = self.env, ec2 = self.ec2, options = self.options)
Severity: Minor
Found in lib/leeroy/task/instantiate.rb by rubocop

This cop checks for unused method arguments.

Example:

# bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

Example:

# good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

Unused method argument - env. If it's necessary, use _ or _env as an argument name to indicate that it won't be used.
Open

      def _genImageParams(phase, state = self.state, env = self.env, ec2 = self.ec2, options = self.options)
Severity: Minor
Found in lib/leeroy/task/image.rb by rubocop

This cop checks for unused method arguments.

Example:

# bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

Example:

# good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

Unused block argument - options. You can omit all the arguments if you don't care about them.
Open

      c.action do |global_options,options,args|
Severity: Minor
Found in lib/leeroy/app.rb by rubocop

This cop checks for unused block arguments.

Example:

# bad

do_something do |used, unused|
  puts used
end

do_something do |bar|
  puts :foo
end

define_method(:foo) do |bar|
  puts :baz
end

Example:

#good

do_something do |used, _unused|
  puts used
end

do_something do
  puts :foo
end

define_method(:foo) do |_bar|
  puts :baz
end

Unused block argument - args. You can omit all the arguments if you don't care about them.
Open

      c.action do |global_options,options,args|
Severity: Minor
Found in lib/leeroy/app.rb by rubocop

This cop checks for unused block arguments.

Example:

# bad

do_something do |used, unused|
  puts used
end

do_something do |bar|
  puts :foo
end

define_method(:foo) do |bar|
  puts :baz
end

Example:

#good

do_something do |used, _unused|
  puts used
end

do_something do
  puts :foo
end

define_method(:foo) do |_bar|
  puts :baz
end

Redundant use of Object#to_s in interpolation.
Open

          "DRYRUN_DUMMY_VALUE: #{self.class.to_s}"
Severity: Minor
Found in lib/leeroy/helpers/aws.rb by rubocop

This cop checks for string conversion in string interpolation, which is redundant.

Example:

# bad

"result is #{something.to_s}"

Example:

# good

"result is #{something}"

Unused block argument - global_options. You can omit all the arguments if you don't care about them.
Open

      c.action do |global_options,options,args|
Severity: Minor
Found in lib/leeroy/app.rb by rubocop

This cop checks for unused block arguments.

Example:

# bad

do_something do |used, unused|
  puts used
end

do_something do |bar|
  puts :foo
end

define_method(:foo) do |bar|
  puts :baz
end

Example:

#good

do_something do |used, _unused|
  puts used
end

do_something do
  puts :foo
end

define_method(:foo) do |_bar|
  puts :baz
end

Unused method argument - env. If it's necessary, use _ or _env as an argument name to indicate that it won't be used.
Open

      def destroyInstance(state = self.state, env = self.env, ec2 = self.ec2, options = self.options)
Severity: Minor
Found in lib/leeroy/helpers/aws.rb by rubocop

This cop checks for unused method arguments.

Example:

# bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

Example:

# good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

Redundant use of Object#to_s in interpolation.
Open

            logger.debug "dumping property '#{property.to_s}'"
Severity: Minor
Found in lib/leeroy/helpers/dumpable.rb by rubocop

This cop checks for string conversion in string interpolation, which is redundant.

Example:

# bad

"result is #{something.to_s}"

Example:

# good

"result is #{something}"

Unused method argument - ec2. If it's necessary, use _ or _ec2 as an argument name to indicate that it won't be used.
Open

      def _resolveResources(state = self.state, env = self.env, ec2 = self.ec2, options = self.options)
Severity: Minor
Found in lib/leeroy/task/instantiate.rb by rubocop

This cop checks for unused method arguments.

Example:

# bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

Example:

# good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

Unused method argument - ec2. If it's necessary, use _ or _ec2 as an argument name to indicate that it won't be used.
Open

      def destroyInstance(state = self.state, env = self.env, ec2 = self.ec2, options = self.options)
Severity: Minor
Found in lib/leeroy/helpers/aws.rb by rubocop

This cop checks for unused method arguments.

Example:

# bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

Example:

# good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

Unused method argument - env. If it's necessary, use _ or _env as an argument name to indicate that it won't be used.
Open

      def _getPackerParams(state = self.state, env = self.env, options = self.options)
Severity: Minor
Found in lib/leeroy/task/packer.rb by rubocop

This cop checks for unused method arguments.

Example:

# bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

Example:

# good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

Useless assignment to variable - resp.
Open

            resp = ec2Request(:describe_instances, run_params)
Severity: Minor
Found in lib/leeroy/task/instantiate.rb by rubocop

This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

assigned but unused variable - foo

Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

Example:

# bad

def some_method
  some_var = 1
  do_something
end

Example:

# good

def some_method
  some_var = 1
  do_something(some_var)
end

Unused method argument - ec2. If it's necessary, use _ or _ec2 as an argument name to indicate that it won't be used.
Open

      def _genImageParams(phase, state = self.state, env = self.env, ec2 = self.ec2, options = self.options)
Severity: Minor
Found in lib/leeroy/task/image.rb by rubocop

This cop checks for unused method arguments.

Example:

# bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

Example:

# good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

Unused block argument - args. If it's necessary, use _ or _args as an argument name to indicate that it won't be used.
Open

      c.action do |global_options,options,args|
Severity: Minor
Found in lib/leeroy/app.rb by rubocop

This cop checks for unused block arguments.

Example:

# bad

do_something do |used, unused|
  puts used
end

do_something do |bar|
  puts :foo
end

define_method(:foo) do |bar|
  puts :baz
end

Example:

#good

do_something do |used, _unused|
  puts used
end

do_something do
  puts :foo
end

define_method(:foo) do |_bar|
  puts :baz
end

Unused method argument - env. If it's necessary, use _ or _env as an argument name to indicate that it won't be used.
Open

      def genImageIndex(state = self.state, env = self.env, ec2 = self.ec2, options = self.options)
Severity: Minor
Found in lib/leeroy/helpers/inventory.rb by rubocop

This cop checks for unused method arguments.

Example:

# bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

Example:

# good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

Unused method argument - env. If it's necessary, use _ or _env as an argument name to indicate that it won't be used.
Open

      def createTags(tags = {}, resourceids = [], state = self.state, env = self.env, options = self.options)
Severity: Minor
Found in lib/leeroy/helpers/aws.rb by rubocop

This cop checks for unused method arguments.

Example:

# bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

Example:

# good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

Unused method argument - options. If it's necessary, use _ or _options as an argument name to indicate that it won't be used.
Open

      def filterImages(selector, collector = lambda { |x| x }, state = self.state, env = self.env, ec2 = self.ec2, options = self.options)
Severity: Minor
Found in lib/leeroy/helpers/aws.rb by rubocop

This cop checks for unused method arguments.

Example:

# bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

Example:

# good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

Useless assignment to variable - resp.
Open

          resp = s3Request(:put_object, run_params)
Severity: Minor
Found in lib/leeroy/helpers/aws.rb by rubocop

This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

assigned but unused variable - foo

Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

Example:

# bad

def some_method
  some_var = 1
  do_something
end

Example:

# good

def some_method
  some_var = 1
  do_something(some_var)
end

Useless assignment to variable - resp.
Open

          resp = checkSemaphore(semaphore)
Severity: Minor
Found in lib/leeroy/helpers/aws.rb by rubocop

This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

assigned but unused variable - foo

Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

Example:

# bad

def some_method
  some_var = 1
  do_something
end

Example:

# good

def some_method
  some_var = 1
  do_something(some_var)
end
Severity
Category
Status
Source
Language