FitnessKeeper/leeroy

View on GitHub

Showing 89 of 89 total issues

Useless assignment to variable - e.
Open

        rescue NoMethodError => e
Severity: Minor
Found in lib/leeroy/app.rb by rubocop

This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

assigned but unused variable - foo

Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

Example:

# bad

def some_method
  some_var = 1
  do_something
end

Example:

# good

def some_method
  some_var = 1
  do_something(some_var)
end

Redundant use of Object#to_s in interpolation.
Open

          "DRYRUN_DUMMY_VALUE: #{self.class.to_s}"
Severity: Minor
Found in lib/leeroy/helpers/aws.rb by rubocop

This cop checks for string conversion in string interpolation, which is redundant.

Example:

# bad

"result is #{something.to_s}"

Example:

# good

"result is #{something}"

Unused method argument - global_options. If it's necessary, use _ or _global_options as an argument name to indicate that it won't be used.
Open

      def state_from_pipe(state = {}, global_options = self.global_options)
Severity: Minor
Found in lib/leeroy/helpers/state.rb by rubocop

This cop checks for unused method arguments.

Example:

# bad

def some_method(used, unused, _unused_but_allowed)
  puts used
end

Example:

# good

def some_method(used, _unused, _unused_but_allowed)
  puts used
end

Useless assignment to variable - resp.
Open

            resp = s3Request(:delete_object, run_params)
Severity: Minor
Found in lib/leeroy/helpers/aws.rb by rubocop

This cop checks for every useless assignment to local variable in every scope. The basic idea for this cop was from the warning of ruby -cw:

assigned but unused variable - foo

Currently this cop has advanced logic that detects unreferenced reassignments and properly handles varied cases such as branch, loop, rescue, ensure, etc.

Example:

# bad

def some_method
  some_var = 1
  do_something
end

Example:

# good

def some_method
  some_var = 1
  do_something(some_var)
end

FIXME found
Open

FIXME not implemented yet
Severity: Minor
Found in README.md by fixme

FIXME found
Open

      new :S3, 'FIXME S3 not implemented yet'
Severity: Minor
Found in lib/leeroy/types/fixture.rb by fixme

FIXME found
Open

        # FIXME raise some more appropriate type of error
Severity: Minor
Found in lib/leeroy/types/enum.rb by fixme

FIXME found
Open

          # FIXME i should do this with URI
Severity: Minor
Found in lib/leeroy/helpers/aws.rb by fixme

FIXME found
Open

      new :CLOUDANT, 'FIXME Cloudant not implemented yet'
Severity: Minor
Found in lib/leeroy/types/fixture.rb by fixme
Severity
Category
Status
Source
Language