Sign upLogin

Forge-Media/teamspeak-bot

View on GitHub
Star

Showing 26 of 75 total issues

Function run has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Confirmed

exports.run = (helpers, jarvis) => {
    async.forever(function (next) {
        setTimeout(function () {
            jarvis.steam
                .getAllRegisterdUsers()
Severity: Minor
Found in plugins/registerCSGO.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function updateUsersTeamspeakGroups has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

function updateUsersTeamspeakGroups(invoker, newRankIndex, notify) {
    // Make sure existing rank is instantiated as an array, to avoid undefined when no existing server group is found!
    let existingTier = [];
    try {
        // Get all the user's existing LOL Teamseak Server Group IDs (Could be multiple, but should not be)
Severity: Minor
Found in plugins/registerLOL.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function onMessage has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Confirmed

exports.onMessage = function (msg, jarvis) {
    const items = msg.split(" <");
    const command = items.shift();
    const invoker = jarvis.invoker;
Severity: Minor
Found in plugins/registerCSGO.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getAuthentication has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Confirmed

    getAuthentication() {
        let loginDetails = this.config;

        // Check SteamLogin details exist
        if (loginDetails.account_name && loginDetails.password) {
Severity: Minor
Found in helpers/steamHelper.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function onRelationshipChange has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    onRelationshipChange(steam64id, relationshipStatus) {
        // console.log(`${this.name}: New relationship event from ${steam64id} (relationship=${relationshipStatus})`);

        //Null check
        if (steam64id === undefined || relationshipStatus === undefined) {
Severity: Minor
Found in helpers/steamHelper.js - About 1 hr to fix

    Function getSummoner has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        async getSummoner(id, name, region) {
        if (!name && !id) {
            return new Error("No Summoner Name or ID provided");
        }
    Severity: Minor
    Found in helpers/riotHelper.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getSummoner has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        async getSummoner(id, name, region) {
        if (!name && !id) {
            return new Error("No Summoner Name or ID provided");
        }
    Severity: Minor
    Found in helpers/riotHelper.js - About 1 hr to fix

      Function updateUsersTeamspeakGroups has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function updateUsersTeamspeakGroups(invoker, newRankIndex, notify) {
    // Make sure existing rank is instantiated as an array, to avoid undefined when no existing server group is found!
    let existingTier = [];
    try {
        // Get all the user's existing LOL Teamseak Server Group IDs (Could be multiple, but should not be)
      Severity: Minor
      Found in plugins/registerLOL.js - About 1 hr to fix

        Function purgeVerified has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

        async function purgeVerified(invoker, jarvis) {
    let counter = 0;
    // Loop through all users in the Verified Server Group
    for (let element of verified_group) {
        // Store Teamspeak Client details
        Severity: Minor
        Found in plugins/purgeVerified.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid deeply nested control flow statements.
        Confirmed

                if (msg.length > 4 || msg.length < 2) {
            client.message(jarvis.error_message.sanitation);
            return;
        }
        Severity: Major
        Found in plugins/createClan.js - About 45 mins to fix

          Function updateAllUsers has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

          async function updateAllUsers(jarvis) {
    try {
        // Get all registered members in the League Firebase database
        const members = await jarvis.riot.getAllRegisterdUsers();
          Severity: Minor
          Found in plugins/registerLOL.js - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this function.
          Open

                      return;
          Severity: Major
          Found in plugins/registerCSGO.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                            return;
            Severity: Major
            Found in plugins/registerLOL.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                              return;
              Severity: Major
              Found in plugins/registerLOL.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                                return null;
                Severity: Major
                Found in helpers/riotHelper.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                              return;
                  Severity: Major
                  Found in plugins/registerLOL.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                return;
                    Severity: Major
                    Found in plugins/registerLOL.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                      return null;
                      Severity: Major
                      Found in helpers/riotHelper.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                        return; // Is regsitered already
                        Severity: Major
                        Found in plugins/registerLOL.js - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                          return; // Summoner name already registered
                          Severity: Major
                          Found in plugins/registerLOL.js - About 30 mins to fix
                            Severity
                            Category
                            Status
                            Source
                            Language