Sign upLogin

Forge-Media/teamspeak-bot

View on GitHub
Star

Showing 38 of 75 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Confirmed

                if (doc.exists) {
                    console.info(`${invoker.nickname} used steamID belonging to someone else`);
                    invoker.message(`Hi, [color=#0069ff][b]${invoker.nickname}[/b][/color] looks like that steamID belongs to someone else!`);
                    return true;
                } else {
Severity: Minor
Found in helpers/steamHelper.js and 1 other location - About 55 mins to fix
helpers/steamHelper.js on lines 441..445

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 54.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid deeply nested control flow statements.
Confirmed

        if (msg.length > 4 || msg.length < 2) {
            client.message(jarvis.error_message.sanitation);
            return;
        }
Severity: Major
Found in plugins/createClan.js - About 45 mins to fix

    Function updateAllUsers has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    async function updateAllUsers(jarvis) {
    try {
        // Get all registered members in the League Firebase database
        const members = await jarvis.riot.getAllRegisterdUsers();
    Severity: Minor
    Found in plugins/registerLOL.js - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid too many return statements within this function.
    Open

                return;
    Severity: Major
    Found in plugins/registerCSGO.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                      return;
      Severity: Major
      Found in plugins/registerLOL.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                        return;
        Severity: Major
        Found in plugins/registerLOL.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                          return null;
          Severity: Major
          Found in helpers/riotHelper.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                        return;
            Severity: Major
            Found in plugins/registerLOL.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                          return;
              Severity: Major
              Found in plugins/registerLOL.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                                return null;
                Severity: Major
                Found in helpers/riotHelper.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                                  return; // Is regsitered already
                  Severity: Major
                  Found in plugins/registerLOL.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                    return; // Summoner name already registered
                    Severity: Major
                    Found in plugins/registerLOL.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                      return;
                      Severity: Major
                      Found in plugins/registerLOL.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                        return null;
                        Severity: Major
                        Found in helpers/riotHelper.js - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                      return;
                          Severity: Major
                          Found in plugins/registerLOL.js - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                            return;
                            Severity: Major
                            Found in plugins/registerLOL.js - About 30 mins to fix

                              Avoid too many return statements within this function.
                              Open

                                          return;
                              Severity: Major
                              Found in plugins/registerLOL.js - About 30 mins to fix

                                Function getSummonerLeagues has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                                Open

                                    async getSummonerLeagues(id, region) {
        if (!id && !region) {
            return new Error("No Summoner ID or region");
        }
                                Severity: Minor
                                Found in helpers/riotHelper.js - About 25 mins to fix

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Severity
                                Category
                                Status
                                Source
                                Language