Showing 95 of 131 total issues
GameUnit
has 31 functions (exceeds 20 allowed). Consider refactoring. Open
class GameUnit
{
private ?int $id;
private string $name;
private string $nameMulti;
Method buildForm
has 80 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function buildForm(FormBuilderInterface $builder, array $options): void
{
$builder
->add(
'name',
Method buildForm
has 71 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function buildForm(FormBuilderInterface $builder, array $options): void
{
$builder
->add(
'name',
Function constructGameUnits
has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring. Open
public function constructGameUnits(
WorldRegion $region,
Player $player,
GameUnitType $gameUnitType,
array $constructionData
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Research
has 23 functions (exceeds 20 allowed). Consider refactoring. Open
class Research
{
private ?int $id;
private string $name;
private string $image;
Topic
has 23 functions (exceeds 20 allowed). Consider refactoring. Open
class Topic
{
private ?int $id;
private string $title = '';
private string $posterIp;
Operation
has 22 functions (exceeds 20 allowed). Consider refactoring. Open
class Operation
{
private ?int $id;
private string $name;
private string $image;
Method buildForm
has 56 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function buildForm(FormBuilderInterface $builder, array $options): void
{
$builder
->add(
'seed',
Federation
has 21 functions (exceeds 20 allowed). Consider refactoring. Open
class Federation
{
private ?int $id;
private string $name = '';
private Player $founder;
Method buildForm
has 54 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function buildForm(FormBuilderInterface $builder, array $options): void
{
$builder
->add(
'name',
Method constructGameUnits
has 51 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function constructGameUnits(
WorldRegion $region,
Player $player,
GameUnitType $gameUnitType,
array $constructionData
Method buildForm
has 51 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function buildForm(FormBuilderInterface $builder, array $options): void
{
$builder
->add(
'email',
Function processSuccess
has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring. Open
public function processSuccess(): void
{
$totalBuildings = 0;
foreach ($this->region->getWorldRegionUnits() as $worldRegionUnit) {
if ($worldRegionUnit->getGameUnit()->getGameUnitType()->getId() == GameUnitType::GAME_UNIT_TYPE_BUILDINGS) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function sendAid
has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring. Open
public function sendAid(Player $player, int $playerId, array $resources): void
{
$this->ensureFederationEnabled($player);
if ($player->getId() === $playerId) {
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method sendAid
has 45 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function sendAid(Player $player, int $playerId, array $resources): void
{
$this->ensureFederationEnabled($player);
if ($player->getId() === $playerId) {
Method sendGameUnits
has 44 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function sendGameUnits(Request $request, int $regionId): Response
{
$player = $this->getPlayer();
try {
Function requestPasswordReset
has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open
public function requestPasswordReset(Request $request): Response
{
$email = (string) $request->request->get('email');
if ($email !== '') {
$user = $this->userRepository->findByEmail($email);
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method buildForm
has 43 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function buildForm(FormBuilderInterface $builder, array $options): void
{
$builder
->add(
'health',
Method processPlayerIncome
has 43 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function processPlayerIncome(Player $player, int $timestamp): bool
{
// Don't update player income more than once every minute...
if ($player->getTimestampUpdate() + 60 > $timestamp) {
return true;
Method attackSelectGameUnits
has 43 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function attackSelectGameUnits(Request $request, int $regionId, int $playerRegionId): Response
{
$player = $this->getPlayer();
try {