Sign upLogin

GEANT/CAT

View on GitHub
Star
core/User.php

Summary

Maintainability
C
1 day
Test Coverage

Function findLoginIdPByEmail has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

    public static function findLoginIdPByEmail($mail, $lang)
    {
        $loggerInstance = new common\Logging();
        $listOfProviders = [];
        $matchedProviders = [];
Severity: Minor
Found in core/User.php - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method findLoginIdPByEmail has 68 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public static function findLoginIdPByEmail($mail, $lang)
    {
        $loggerInstance = new common\Logging();
        $listOfProviders = [];
        $matchedProviders = [];
Severity: Major
Found in core/User.php - About 2 hrs to fix

    Function __construct has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        public function __construct($userId)
    {
        $this->databaseType = "USER";
        parent::__construct(); // database handle is now available
        $this->attributes = [];
    Severity: Minor
    Found in core/User.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method __construct has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function __construct($userId)
    {
        $this->databaseType = "USER";
        parent::__construct(); // database handle is now available
        $this->attributes = [];
    Severity: Minor
    Found in core/User.php - About 1 hr to fix

      Avoid deeply nested control flow statements.
      Open

                                  if ($ch === FALSE) {
                                $loggerInstance->debug(2, "Unable ask eduGAIN about IdP - CURL init failed!");
                                break;
                            }
      Severity: Major
      Found in core/User.php - About 45 mins to fix

        There are no issues that match your filters.

        Category
        Status