Sign upLogin

GEANT/CAT

View on GitHub
Star

Showing 599 of 599 total issues

Method findResourceUrl has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function findResourceUrl($resourcetype, $filename, $submodule = '') {
        switch ($resourcetype) {
            case "CSS":
                $path = "/resources/css/";
                break;
Severity: Minor
Found in web/lib/user/Skinjob.php - About 1 hr to fix

    Method realm has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function realm($input)
    {
        \core\common\Entity::intoThePotatoes();
        if (strlen($input) == 0) {
            echo $this->inputValidationError(_("Realm is empty!"));
    Severity: Minor
    Found in web/lib/common/InputValidation.php - About 1 hr to fix

      Method sanityTestResultHTML has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function sanityTestResultHTML($test) {
        $out = '';
        switch ($test->test_result['global']) {
            case \core\common\Entity::L_OK:
                $message = "Your configuration appears to be fine.";
      Severity: Minor
      Found in web/lib/admin/UIElements.php - About 1 hr to fix

        Method writeDeviceInfo has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function writeDeviceInfo()
    {
        \core\common\Entity::intoThePotatoes();
        $ssidCount = 0;
        $oiCount = 0;
        Severity: Minor
        Found in devices/apple_mobileconfig/MobileconfigSuperclass.php - About 1 hr to fix

          Method writeMainNSH has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              private function writeMainNSH($eap, $attr) {
        $this->loggerInstance->debug(4, "writeMainNSH");
        $this->loggerInstance->debug(4, $attr);
        $this->loggerInstance->debug(4, "MYLANG=" . $this->lang . "\n");
          Severity: Minor
          Found in devices/ms/DeviceVista7.php - About 1 hr to fix

            Method getExternalDBSyncCandidates has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function getExternalDBSyncCandidates($type)
    {
        $usedarray = [];
        $matchingCandidates = [];
        $syncstate = self::EXTERNAL_DB_SYNCSTATE_SYNCED;
            Severity: Minor
            Found in core/IdP.php - About 1 hr to fix

              Method testNSISmodules has 27 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private function testNSISmodules()
    {
        $tmp_dir = \core\common\Entity::createTemporaryDirectory('installer', 0)['dir'];
        if (!chdir($tmp_dir)) {
            $this->loggerInstance->debug(2, "Cannot chdir to $tmp_dir\n");
              Severity: Minor
              Found in core/SanityTests.php - About 1 hr to fix

                Method initialise has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    private function initialise()
    {
        // find out where the admin is located approximately
        $ourLocation = ['lon' => 0, 'lat' => 0];
        $geoip = DeviceLocation::locateDevice();
                Severity: Minor
                Found in core/DeploymentManaged.php - About 1 hr to fix

                  Method __construct has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      public function __construct()
    {
        $this->loggerInstance = new Logging();
        $this->loggerInstance->debug(4, "--- BEGIN constructing class " . get_class($this) . " .\n");
        $this->languageInstance = new Language();
                  Severity: Minor
                  Found in core/common/Entity.php - About 1 hr to fix

                    Method sendToRADIUS has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        private function sendToRADIUS(int $idx, $post)
    {

        $hostname = "radius_hostname_$idx";
        $ch = curl_init("http://" . $this->$hostname);
                    Severity: Minor
                    Found in core/DeploymentManaged.php - About 1 hr to fix

                      Method packetCountEvaluation has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                          private function packetCountEvaluation(&$testresults, $packetcount) {
        $reqs = $packetcount[1] ?? 0;
        $accepts = $packetcount[2] ?? 0;
        $rejects = $packetcount[3] ?? 0;
        $challenges = $packetcount[11] ?? 0;
                      Severity: Minor
                      Found in core/diag/RADIUSTests.php - About 1 hr to fix

                        Method __construct has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            public function __construct($profileIdRaw, $idpObject = NULL)
    {
        $this->databaseType = "INST";
        parent::__construct(); // we now have access to our INST database handle and logging
        $handle = DBConnection::handle("FRONTEND");
                        Severity: Minor
                        Found in core/AbstractProfile.php - About 1 hr to fix

                          Method existingIdPInt has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                              public function existingIdPInt($input, $owner = NULL, $claimedFedBinding = NULL)
    {
        $clean = $this->integer($input);
        if ($clean === FALSE) {
            throw new Exception($this->inputValidationError("Value for IdP is not an integer!"));
                          Severity: Minor
                          Found in web/lib/common/InputValidation.php - About 1 hr to fix

                            Method printMenu has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                public function printMenu($menu = NULL, $id = NULL) {
        $menu = $menu ?? $this->menu;
        if (count($menu) == 0) {
            return;
        }
                            Severity: Minor
                            Found in web/skins/modern/Menu.php - About 1 hr to fix

                              Method writeDeviceInfo has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                                  public function writeDeviceInfo()
    {
        \core\common\Entity::intoThePotatoes();
        $networkList = [];
        foreach (array_keys($this->getAttribute('internal:networks')) as $networkName) {
                              Severity: Minor
                              Found in devices/ms/WindowsCommon.php - About 1 hr to fix

                                Method defaultPagePrelude has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                                Open

                                    public function defaultPagePrelude($pagetitle = \config\Master::APPEARANCE['productname_long']) {
        $ourlocale = $this->languageInstance->getLang();
        $direction = $this->languageInstance->rtl;
        header("Content-Type:text/html;charset=utf-8");
        ?>
                                Severity: Minor
                                Found in web/lib/user/Gui.php - About 1 hr to fix

                                  Method handle has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                                  Open

                                      public static function handle($database)
    {
        $theDb = strtoupper($database);
        switch ($theDb) {
            case "INST":
                                  Severity: Minor
                                  Found in core/DBConnection.php - About 1 hr to fix

                                    Method revaluate has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                                    Open

                                        public function revaluate($questionNumber, $answer)
    {
        if ($questionNumber == "") {
            throw new Exception("We really need a question number!");
        }
                                    Severity: Minor
                                    Found in core/diag/Sociopath.php - About 1 hr to fix

                                      Method generateCompatibleCsr has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                                      Open

                                          public function generateCompatibleCsr($privateKey, $fed, $username): array
    {
        $tempdirArray = \core\common\Entity::createTemporaryDirectory("test");
        $tempdir = $tempdirArray['dir'];
        // dump private key into directory
                                      Severity: Minor
                                      Found in core/CertificationAuthorityEduPkiServer.php - About 1 hr to fix

                                        Method checkFedEtlrUplink has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                                        Open

                                            private function checkFedEtlrUplink($whichSide)
    {
        // TODO: we always check the European TLRs even though the connection in question might go via others and/or this one
        // needs a table to determine what goes where :-(
        switch ($whichSide) {
                                        Severity: Minor
                                        Found in core/diag/Telepath.php - About 1 hr to fix
                                          Severity
                                          Category
                                          Status
                                          Source
                                          Language