Sign upLogin

GUSCRAWFORD/fpm

View on GitHub
Star
src/install-command.ts

Summary

Maintainability
C
1 day
Test Coverage

Function installCommand has 100 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function installCommand(args, options, logger) {
    args.packagePaths.push(args.packagePath);
    args.packagePaths.forEach(packagePath=>copyPackage(packagePath));

    function copyPackage(packagePath:string) {
Severity: Major
Found in src/install-command.ts - About 4 hrs to fix

    Function copy has 43 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function copy(src:string, dest:string) {
        const absNodeModulesPath = path.join(process.cwd(), 'node_modules/');
        fs.lstat(src, (err,info)=>{
            if (err) {
                logger.error(`❌  Couldn't lstat ${src}:\n\t${err}`);
    Severity: Minor
    Found in src/install-command.ts - About 1 hr to fix

      Function copyPackage has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          function copyPackage(packagePath:string) {
        const absPackagePath = path.join(process.cwd(),packagePath),
            absNodeModulesPath = path.join(process.cwd(),'node_modules');
        if (options.dry) logger.info(`ℹ️  Looking for package.json in ${absPackagePath}`);
        fs.readFile(
      Severity: Minor
      Found in src/install-command.ts - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        function captureVariants() {
    const REAL_ADD = 'add';
    let commandIndex = 2, command = process.argv[commandIndex];
    if (command === 'help') {
        commandIndex = 3;
        Severity: Major
        Found in src/install-command.ts and 1 other location - About 3 hrs to fix
        src/transform-command.ts on lines 7..20

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 102.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status