File FieldMaintenanceModel.php
has 374 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
/**
*
* @package Gems
The class FieldMaintenanceModel has an overall complexity of 51 which is very high. The configured complexity threshold is 50. Open
class FieldMaintenanceModel extends \MUtil_Model_UnionModel
{
/**
* Constant name to id appointment items
*/
- Exclude checks
Method applyBrowseSettings
has 76 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function applyBrowseSettings($detailed = false)
{
$this->resetOrder();
$yesNo = $this->util->getTranslated()->getYesNo();
Method applyEditSettings
has 43 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function applyEditSettings()
{
$this->applyDetailSettings();
$this->set('gtf_id_field', 'elementClass', 'Hidden');
Method loadCalculationSources
has 5 arguments (exceeds 4 allowed). Consider refactoring. Open
protected function loadCalculationSources($value, $isNew = false, $name = null, array $context = array(), $isPost = false)
Function loadCalculationSources
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
protected function loadCalculationSources($value, $isNew = false, $name = null, array $context = array(), $isPost = false)
{
if ($isPost) {
return $value;
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return
statements within this method. Open
return $value;
Function _processRowAfterLoad
has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
public function _processRowAfterLoad(array $row, $new = false, $isPost = false, &$transformColumns = array())
{
if ($this->_addLoadDependency && !empty($row['gtf_field_type'])) {
// Display of data field
// Next line puts default field dependency on other types too when creating a new field
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
The class FieldMaintenanceModel has a coupling between objects value of 17. Consider to reduce the number of dependencies under 13. Open
class FieldMaintenanceModel extends \MUtil_Model_UnionModel
{
/**
* Constant name to id appointment items
*/
- Read upRead up
- Exclude checks
CouplingBetweenObjects
Since: 1.1.0
A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability
Example
class Foo {
/**
* @var \foo\bar\X
*/
private $x = null;
/**
* @var \foo\bar\Y
*/
private $y = null;
/**
* @var \foo\bar\Z
*/
private $z = null;
public function setFoo(\Foo $foo) {}
public function setBar(\Bar $bar) {}
public function setBaz(\Baz $baz) {}
/**
* @return \SplObjectStorage
* @throws \OutOfRangeException
* @throws \InvalidArgumentException
* @throws \ErrorException
*/
public function process(\Iterator $it) {}
// ...
}
Source https://phpmd.org/rules/design.html#couplingbetweenobjects
Avoid unused parameters such as '$isNew'. Open
protected function loadCalculationSources($value, $isNew = false, $name = null, array $context = array(), $isPost = false)
- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Avoid unused parameters such as '$name'. Open
protected function loadCalculationSources($value, $isNew = false, $name = null, array $context = array(), $isPost = false)
- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Avoid unused parameters such as '$locale'. Open
public function plural($singular, $plural, $number, $locale = null)
- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Avoid unused parameters such as '$number'. Open
public function plural($singular, $plural, $number, $locale = null)
- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Avoid unused parameters such as '$singular'. Open
public function plural($singular, $plural, $number, $locale = null)
- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Avoid unused parameters such as '$plural'. Open
public function plural($singular, $plural, $number, $locale = null)
- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}
Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Avoid using short method names like FieldMaintenanceModel::_(). The configured minimum method name length is 3. Open
public function _($text, $locale = null)
{
return $this->translateAdapter->_($text, $locale);
}
- Read upRead up
- Exclude checks
ShortMethodName
Since: 0.2
Detects when very short method names are used.
Example
class ShortMethod {
public function a( $index ) { // Violation
}
}
Source https://phpmd.org/rules/naming.html#shortmethodname
Avoid variables with short names like $db. Configured minimum length is 3. Open
protected $db;
- Read upRead up
- Exclude checks
ShortVariable
Since: 0.2
Detects when a field, local, or parameter has a very short name.
Example
class Something {
private $q = 15; // VIOLATION - Field
public static function main( array $as ) { // VIOLATION - Formal
$r = 20 + $this->q; // VIOLATION - Local
for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
$r += $this->q;
}
}
}
Source https://phpmd.org/rules/naming.html#shortvariable
The method _ is not named in camelCase. Open
public function _($text, $locale = null)
{
return $this->translateAdapter->_($text, $locale);
}
- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}