Sign upLogin

Graudusk/callurl

View on GitHub
Star
src/CallUrlModel/WeatherModelTrait.php

Summary

Maintainability
C
1 day
Test Coverage

File WeatherModelTrait.php has 302 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php
/**
 * Showing off a standard class with methods and properties.
 */
namespace Erjh17\CallUrlModel;
Severity: Minor
Found in src/CallUrlModel/WeatherModelTrait.php - About 3 hrs to fix

    Function fetchWeatherInfo has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

        public function fetchWeatherInfo()
    {
        if ($this->latitude && $this->latitude) {
            $cUrl = $this->di->get("callurl");
            $args = $this->buildArgs();
    Severity: Minor
    Found in src/CallUrlModel/WeatherModelTrait.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method fetchWeatherInfo has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function fetchWeatherInfo()
    {
        if ($this->latitude && $this->latitude) {
            $cUrl = $this->di->get("callurl");
            $args = $this->buildArgs();
    Severity: Minor
    Found in src/CallUrlModel/WeatherModelTrait.php - About 1 hr to fix

      Method buildArgs has 31 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function buildArgs()
    {
        $time = $this->calculateTimeMachine();

        $urls = array($this->darkSkyUrl);
      Severity: Minor
      Found in src/CallUrlModel/WeatherModelTrait.php - About 1 hr to fix

        Method hourly has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function hourly()
    {
        $hourly = [];
        if ($this->hourly && isset($this->hourly["data"])) {
            $this->hourly["data"] = array_slice($this->hourly["data"], 0, 12);
        Severity: Minor
        Found in src/CallUrlModel/WeatherModelTrait.php - About 1 hr to fix

          Method currently has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function currently()
    {
        $currently = [];
        setlocale(LC_ALL, 'sv_SV');
        if ($this->currently && $this->currently["time"]) {
          Severity: Minor
          Found in src/CallUrlModel/WeatherModelTrait.php - About 1 hr to fix

            Method pastDays has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public function pastDays()
    {
        $pastDays = [];

        if ($this->pastDays["data"]) {
            Severity: Minor
            Found in src/CallUrlModel/WeatherModelTrait.php - About 1 hr to fix

              Function hourly has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function hourly()
    {
        $hourly = [];
        if ($this->hourly && isset($this->hourly["data"])) {
            $this->hourly["data"] = array_slice($this->hourly["data"], 0, 12);
              Severity: Minor
              Found in src/CallUrlModel/WeatherModelTrait.php - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function daily has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function daily()
    {
        $days = [];
        if ($this->daily) {
            setlocale(LC_ALL, 'sv_SV');
              Severity: Minor
              Found in src/CallUrlModel/WeatherModelTrait.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function pastDays has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function pastDays()
    {
        $pastDays = [];

        if ($this->pastDays["data"]) {
              Severity: Minor
              Found in src/CallUrlModel/WeatherModelTrait.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              The method getWeatherInfo uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
              Open

                      } else {
            return array_merge(
                $this->getInfo(),
                array(
                    "pos" => $this->ipAddress
              Severity: Minor
              Found in src/CallUrlModel/WeatherModelTrait.php by phpmd

              ElseExpression

              Since: 1.4.0

              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

              Example

              class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

              Source https://phpmd.org/rules/cleancode.html#elseexpression

              The method fetchWeatherInfo uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
              Open

                          } else {
                $this->setErrorMessage("DarkSkyError: daily usage limit exceeded");
            }
              Severity: Minor
              Found in src/CallUrlModel/WeatherModelTrait.php by phpmd

              ElseExpression

              Since: 1.4.0

              An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

              Example

              class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

              Source https://phpmd.org/rules/cleancode.html#elseexpression

              Avoid variables with short names like $i. Configured minimum length is 3.
              Open

                  public function parseDate($arr, $i, $time)
              Severity: Minor
              Found in src/CallUrlModel/WeatherModelTrait.php by phpmd

              ShortVariable

              Since: 0.2

              Detects when a field, local, or parameter has a very short name.

              Example

              class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

              Source https://phpmd.org/rules/naming.html#shortvariable

              There are no issues that match your filters.

              Category
              Status