GuilhermeStracini/TCC-SENAC

View on GitHub

Showing 605 of 605 total issues

Avoid deeply nested control flow statements.
Open

                for (j = 0; j < token.children.length; j++)
                {
                    var child = token.children[j];
                    if (child.tokenType == Spry.Data.Region.Token.PROCESSING_INSTRUCTION_TOKEN)
                    {
Severity: Major
Found in Src/scripts/sprydata.js - About 45 mins to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

            $('loadingLink').observe('click', (function(event) { event.stop(); this.end(); }).bind(this));
    Severity: Minor
    Found in Src/scripts/lightbox.js and 1 other location - About 45 mins to fix
    Src/scripts/lightbox.js on lines 171..171

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 50.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Avoid deeply nested control flow statements.
    Open

                        if (pdsc) pdsc.addChild(dsc);
    Severity: Major
    Found in Src/scripts/sprydata.js - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                          if (tagAttrs.charAt(endIndex) == tagAttrs.charAt(savedIndex))
                          {
                              endIndex++;
                              break;
                          }
      Severity: Major
      Found in Src/scripts/sprydata.js - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                            if (hashStr)
                                hashStr += ",";
        Severity: Major
        Found in Src/scripts/sprydata.js - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                              if (dsName && ds)
                              {
                                  // The dataSetsForDataRefStrings array serves as both an
                                  // array of data sets and a hash lookup by name.
          
          
          Severity: Major
          Found in Src/scripts/sprydata.js - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                    if (token.data.jsExpr)
                                        testVal = this.evaluateExpression(token.data.jsExpr, processContext);
            Severity: Major
            Found in Src/scripts/sprydata.js - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                  if (a_l_c > b_l_c)
                                      return -1;
                                  else if (a_l_c < b_l_c)
                                      return 1;
                                  else if (a_c > b_c)
              Severity: Major
              Found in Src/scripts/sprydata.js - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                        if (testVal)
                                            this.processTokenChildren(outputArr, token, processContext);
                Severity: Major
                Found in Src/scripts/sprydata.js - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                              if (bAttrValue != undefined)
                                              {
                                                  hasBehaviorAttributes = true;
                                                  if (bAttrs[behaviorAttrName].setup)
                                                      bAttrs[behaviorAttrName].setup(node, bAttrValue);
                  Severity: Major
                  Found in Src/scripts/sprydata.js - About 45 mins to fix

                    Avoid deeply nested control flow statements.
                    Open

                                        for (var l = 0; l < numRSRows; l++)
                                        {
                                            // Create a new row that will house the join result.
                    
                                            var newRowObj = new Object;
                    Severity: Major
                    Found in Src/scripts/sprydata.js - About 45 mins to fix

                      Avoid deeply nested control flow statements.
                      Open

                                      if (tokenStack[tokenStack.length - 1].tokenType != Spry.Data.Region.Token.PROCESSING_INSTRUCTION_TOKEN)
                                      {
                                          Spry.Debug.reportError("Invalid processing instruction close tag: " + piName + " -- " + results[0] + "\n");
                                          return null;
                                      }
                      Severity: Major
                      Found in Src/scripts/sprydata.js - About 45 mins to fix

                        Similar blocks of code found in 2 locations. Consider refactoring.
                        Open

                                $('bottomNavClose').observe('click', (function(event) { event.stop(); this.end(); }).bind(this));
                        Severity: Minor
                        Found in Src/scripts/lightbox.js and 1 other location - About 45 mins to fix
                        Src/scripts/lightbox.js on lines 170..170

                        Duplicated Code

                        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                        Tuning

                        This issue has a mass of 50.

                        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                        Refactorings

                        Further Reading

                        Avoid deeply nested control flow statements.
                        Open

                                        if (!childToProcess && defaultChild)
                                            childToProcess = defaultChild;
                        Severity: Major
                        Found in Src/scripts/sprydata.js - About 45 mins to fix

                          Avoid deeply nested control flow statements.
                          Open

                                              if (spType == "string")
                                                  sp = [ sp ];
                                              else if (spType == "object" && spType.constructor == Object)
                                                  sp = [ sp ];
                          Severity: Major
                          Found in Src/scripts/sprydata.js - About 45 mins to fix

                            Avoid deeply nested control flow statements.
                            Open

                                            if (piDesc)
                                            {
                                                var dataSet = null;
                            
                                                var selectedDataSetName = "";
                            Severity: Major
                            Found in Src/scripts/sprydata.js - About 45 mins to fix

                              Avoid deeply nested control flow statements.
                              Open

                                          else if (token.data.name == "spry:state")
                                          {
                                              var testVal = true;
                              
                                              if (!token.data.regionState || token.data.regionState == this.currentState)
                              Severity: Major
                              Found in Src/scripts/sprydata.js - About 45 mins to fix

                                Avoid deeply nested control flow statements.
                                Open

                                                    if (ctype == "number")
                                                        row[cname] = new Number(val);
                                                    else if (ctype == "html")
                                                        row[cname] = Spry.Utils.decodeEntities(val);
                                Severity: Major
                                Found in Src/scripts/sprydata.js - About 45 mins to fix

                                  Function sessionExpiredChecker has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                                  Open

                                  Spry.Data.XMLDataSet.prototype.sessionExpiredChecker = function(req)
                                  {
                                      if (req.xhRequest.responseText == 'session expired')
                                          return true;
                                      else
                                  Severity: Minor
                                  Found in Src/scripts/sprydata.js - About 45 mins to fix

                                  Cognitive Complexity

                                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                  A method's cognitive complexity is based on a few simple rules:

                                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                  • Code is considered more complex for each "break in the linear flow of the code"
                                  • Code is considered more complex when "flow breaking structures are nested"

                                  Further reading

                                  Avoid deeply nested control flow statements.
                                  Open

                                                                  if (!lastStartComment)
                                                                      node.insertBefore(oComment, node.firstChild);
                                                                  else
                                                                      node.insertBefore(oComment, lastStartComment.nextSibling);
                                  Severity: Major
                                  Found in Src/scripts/sprydata.js - About 45 mins to fix
                                    Severity
                                    Category
                                    Status
                                    Source
                                    Language