Sign upLogin

HR/Crypter

View on GitHub
Star
app/core/crypto.js

Summary

Maintainability
B
6 hrs
Test Coverage

Function decrypt has 85 lines of code (exceeds 25 allowed). Consider refactoring.
Invalid

exports.decrypt = (origpath, mpkey) => {
  // Decrypts a crypto format file passed with the pass
  return new Promise((resolve, reject) => {
    logger.verbose(`Decrypting ${origpath}...`)
    // Extract a directory
Severity: Major
Found in app/core/crypto.js - About 3 hrs to fix

    Function encrypt has 69 lines of code (exceeds 25 allowed). Consider refactoring.
    Invalid

    exports.encrypt = (origpath, mpkey) => {
  // Encrypts any arbitrary data passed with the pass
  return new Promise((resolve, reject) => {
    // derive the encryption key
    exports
    Severity: Major
    Found in app/core/crypto.js - About 2 hrs to fix

      File crypto.js has 254 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      'use strict'
/**
 * crypto.js
 * Provides the crypto functionality required
 ******************************/
      Severity: Minor
      Found in app/core/crypto.js - About 2 hrs to fix

        Function deriveKey has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        exports.deriveKey = (pass, psalt) => {
  return new Promise((resolve, reject) => {
    // reject with error if pass not provided
    if (!pass) reject(new Error('Pass to derive key from not provided'))
        Severity: Minor
        Found in app/core/crypto.js - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                          dataOrig
                    .on('error', err => reject(err))
                    .pipe(decipher)
                    .on('error', err => reject(err))
                    .pipe(dataDest)
        Severity: Major
        Found in app/core/crypto.js and 1 other location - About 1 hr to fix
        app/core/crypto.js on lines 89..107

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 73.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                  origin
            .on('error', err => reject(err))
            .pipe(cipher)
            .on('error', err => reject(err))
            .pipe(dataDest)
        Severity: Major
        Found in app/core/crypto.js and 1 other location - About 1 hr to fix
        app/core/crypto.js on lines 206..229

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 73.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Invalid

              const hash = scrypto
        .createHash(CRYPTO.DEFAULTS.HASH_ALG)
        .update(`${pass}${salt}`)
        .digest('hex')
        Severity: Major
        Found in app/core/crypto.js and 1 other location - About 1 hr to fix
        app/core/crypto.js on lines 287..290

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 55.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Invalid

              const hash = scrypto
        .createHash(CRYPTO.DEFAULTS.HASH_ALG)
        .update(`${pass}${salt}`)
        .digest('hex')
        Severity: Major
        Found in app/core/crypto.js and 1 other location - About 1 hr to fix
        app/core/crypto.js on lines 299..302

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 55.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status