Sign upLogin

Halyul/hexo-theme-mdui

View on GitHub
Star

Showing 125 of 125 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                if (_this.s.loop) {
                    _this.index = _this.items.length - 1;
                    _lgUtils2.default.trigger(_this.el, 'onBeforePrevSlide', {
                        index: _this.index,
                        fromTouch: fromTouch
Severity: Major
Found in source/js/_files/lightgallery.js and 1 other location - About 1 hr to fix
source/js/_files/lightgallery.js on lines 1143..1154

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 69.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

                if (_this.s.loop) {
                    _this.index = 0;
                    _lgUtils2.default.trigger(_this.el, 'onBeforeNextSlide', {
                        index: _this.index
                    });
Severity: Major
Found in source/js/_files/lightgallery.js and 1 other location - About 1 hr to fix
source/js/_files/lightgallery.js on lines 1174..1186

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 69.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function itemHightlight has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function itemHightlight() {
  themeRuntime.router.currentStatus.pathname = window.location.pathname
  var drawerContent = document.querySelector('.theme-drawer__warpper__content')
  var currentNamespace = Barba.HistoryManager.currentStatus().namespace
  if (Barba.HistoryManager.prevStatus() === null) {
Severity: Minor
Found in source/js/_files/js.barba.js - About 1 hr to fix

    Function escapeCharacters has 42 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        var escapeCharacters = function (id) {

        // Remove leading hash
        if (id.charAt(0) === '#') {
            id = id.substr(1);
    Severity: Minor
    Found in source/js/_files/smooth-scroll.js - About 1 hr to fix

      Consider simplifying this complex logical expression.
      Open

                  if (
                codeUnit >= 0x0080 ||
                codeUnit === 0x002D ||
                codeUnit === 0x005F ||
                codeUnit >= 0x0030 && codeUnit <= 0x0039 ||
      Severity: Critical
      Found in source/js/_files/smooth-scroll.js - About 1 hr to fix

        Function addHtml has 41 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            Plugin.prototype.addHtml = function (index) {
        var subHtml = null;
        var currentEle;
        if (this.s.dynamic) {
            subHtml = this.s.dynamicEl[index].subHtml;
        Severity: Minor
        Found in source/js/_files/lightgallery.js - About 1 hr to fix

          Function touchendZoom has 41 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  Zoom.prototype.touchendZoom = function(startCoords, endCoords, allowX, allowY) {

          var _this = this;
          var _el = _this.core.___slide[_this.core.index].querySelector('.lg-img-wrap');
          var image = _this.core.___slide[_this.core.index].querySelector('.lg-object');
          Severity: Minor
          Found in source/js/_files/lg-zoom.js - About 1 hr to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                      var maxY = Math.abs(image.offsetHeight * Math.abs(image.getAttribute('data-scale')) - _this.core.outer.querySelector('.lg').clientHeight + minY);
            Severity: Major
            Found in source/js/_files/lg-zoom.js and 1 other location - About 1 hr to fix
            source/js/_files/lg-zoom.js on lines 552..552

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 67.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                      var maxX = Math.abs(image.offsetWidth * Math.abs(image.getAttribute('data-scale')) - _this.core.outer.querySelector('.lg').clientWidth + minX);
            Severity: Major
            Found in source/js/_files/lg-zoom.js and 1 other location - About 1 hr to fix
            source/js/_files/lg-zoom.js on lines 550..550

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 67.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Function itemHightlight has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
            Open

            function itemHightlight() {
  themeRuntime.router.currentStatus.pathname = window.location.pathname
  var drawerContent = document.querySelector('.theme-drawer__warpper__content')
  var currentNamespace = Barba.HistoryManager.currentStatus().namespace
  if (Barba.HistoryManager.prevStatus() === null) {
            Severity: Minor
            Found in source/js/_files/js.barba.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function sassRenderer has 39 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            var sassRenderer = function(data, options, callback) {

    var self = this;
    var themeCfg = self.theme.config || {};
            Severity: Minor
            Found in scripts/lib/style_renderer.js - About 1 hr to fix

              Function init has 39 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  Plugin.prototype.init = function () {

        var _this = this;

        // s.preload should not be more than $item.length
              Severity: Minor
              Found in source/js/_files/lightgallery.js - About 1 hr to fix

                Function enableSwipe has 37 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    Plugin.prototype.enableSwipe = function () {
        var _this = this;
        var startCoords = 0;
        var endCoords = 0;
        var isMoved = false;
                Severity: Minor
                Found in source/js/_files/lightgallery.js - About 1 hr to fix

                  Function isVideo has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                      Plugin.prototype.isVideo = function (src, index) {

        if (!src) {
            throw new Error("Make sure that slide " + index + " has an image/video src");
        }
                  Severity: Minor
                  Found in source/js/_files/lightgallery.js - About 1 hr to fix

                    Function xhr has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                          xhr: function(url) {
        var deferred = this.deferred();
        var req = new XMLHttpRequest();
        const errorPageUrl = this.errorPageUrl
                    Severity: Minor
                    Found in source/js/_files/barba.js - About 1 hr to fix

                      Function Request has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                        function Request(input, options) {
    options = options || {};
    var body = options.body;

    if (input instanceof Request) {
                      Severity: Minor
                      Found in source/js/_files/fetch.js - About 1 hr to fix

                        Function Plugin has 33 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                            function Plugin(element, options) {

        // Current lightGallery element
        this.el = element;
                        Severity: Minor
                        Found in source/js/_files/lightgallery.js - About 1 hr to fix

                          Function invokeCallback has 32 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                          function invokeCallback(settled, promise, callback, detail) {
  var hasCallback = isFunction(callback),
      value = void 0,
      error = void 0,
      succeeded = void 0,
                          Severity: Minor
                          Found in source/js/_files/es6-promise.js - About 1 hr to fix

                            Function build has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                            Open

                                Plugin.prototype.build = function (index) {

        var _this = this;

        _this.structure();
                            Severity: Minor
                            Found in source/js/_files/lightgallery.js - About 1 hr to fix

                              Function exports has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                              Open

                              module.exports = function(locals){
  var config = this.config;
  var searchConfig = config.search;
  var template = searchTmpl;
  var searchfield = searchConfig.field;
                              Severity: Minor
                              Found in scripts/lib/search/json_generator.js - About 1 hr to fix
                                Severity
                                Category
                                Status
                                Source
                                Language