Sign upLogin

Hawatel/hawatel_ps

View on GitHub
Star
lib/hawatel_ps/windows/proc_table.rb

Summary

Maintainability
B
6 hrs
Test Coverage

Method search_by_condition has a Cognitive Complexity of 26 (exceeds 5 allowed). Consider refactoring.
Open

        def search_by_condition(args)
          find_all

          attrs = args[:attr]
          oper  = args[:oper]
Severity: Minor
Found in lib/hawatel_ps/windows/proc_table.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Cyclomatic complexity for search_by_condition is too high. [14/10]
Open

        def search_by_condition(args)
          find_all

          attrs = args[:attr]
          oper  = args[:oper]
Severity: Minor
Found in lib/hawatel_ps/windows/proc_table.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Method search_by_name has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

        def search_by_name(process_name)
          if process_name =~ /^\/.*\/$/
            process_name.slice!(0)
            process_name = Regexp.new(/#{process_name.chop}/)
            find_all
Severity: Minor
Found in lib/hawatel_ps/windows/proc_table.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

              process_list << process if process[:"#{attrs}"] <= value
Severity: Major
Found in lib/hawatel_ps/windows/proc_table.rb - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                elsif oper == '=='
              process_list << process if process[:"#{attrs}"] == value
            elsif oper == '!='
              process_list << process if process[:"#{attrs}"] != value
    Severity: Major
    Found in lib/hawatel_ps/windows/proc_table.rb - About 45 mins to fix

      There are no issues that match your filters.

      Category
      Status