HuasoFoundries/jpgraph

View on GitHub
src/graph/GanttActivityInfo.php

Summary

Maintainability
B
5 hrs
Test Coverage

Method Stroke has 58 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function Stroke($aImg, $aXLeft, $aYTop, $aXRight, $aYBottom, $aUseTextHeight = false)
    {
        if (!$this->iShow) {
            return;
        }
Severity: Major
Found in src/graph/GanttActivityInfo.php - About 2 hrs to fix

    Function Stroke has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

        public function Stroke($aImg, $aXLeft, $aYTop, $aXRight, $aYBottom, $aUseTextHeight = false)
        {
            if (!$this->iShow) {
                return;
            }
    Severity: Minor
    Found in src/graph/GanttActivityInfo.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    The class GanttActivityInfo has 18 fields. Consider redesigning GanttActivityInfo to keep the number of fields under 15.
    Open

    class GanttActivityInfo
    {
        public $iShow            = true;
        public $iLeftColMargin   = 4;
        public $iRightColMargin  = 1;
    Severity: Minor
    Found in src/graph/GanttActivityInfo.php by phpmd

    TooManyFields

    Since: 0.1

    Classes that have too many fields could be redesigned to have fewer fields, possibly through some nested object grouping of some of the information. For example, a class with city/state/zip fields could instead have one Address field.

    Example

    class Person {
       protected $one;
       private $two;
       private $three;
       [... many more fields ...]
    }

    Source https://phpmd.org/rules/codesize.html#toomanyfields

    Method Stroke has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function Stroke($aImg, $aXLeft, $aYTop, $aXRight, $aYBottom, $aUseTextHeight = false)
    Severity: Minor
    Found in src/graph/GanttActivityInfo.php - About 45 mins to fix

      Function SetMinColWidth has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public function SetMinColWidth($aWidths)
          {
              $n = min(safe_count($this->iTitles), safe_count($aWidths));
              for ($i = 0; $i < $n; ++$i) {
                  if (!empty($aWidths[$i])) {
      Severity: Minor
      Found in src/graph/GanttActivityInfo.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      The method Stroke() has an NPath complexity of 832. The configured NPath complexity threshold is 200.
      Open

          public function Stroke($aImg, $aXLeft, $aYTop, $aXRight, $aYBottom, $aUseTextHeight = false)
          {
              if (!$this->iShow) {
                  return;
              }
      Severity: Minor
      Found in src/graph/GanttActivityInfo.php by phpmd

      NPathComplexity

      Since: 0.1

      The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

      Example

      class Foo {
          function bar() {
              // lots of complicated code
          }
      }

      Source https://phpmd.org/rules/codesize.html#npathcomplexity

      The method Stroke() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10.
      Open

          public function Stroke($aImg, $aXLeft, $aYTop, $aXRight, $aYBottom, $aUseTextHeight = false)
          {
              if (!$this->iShow) {
                  return;
              }
      Severity: Minor
      Found in src/graph/GanttActivityInfo.php by phpmd

      CyclomaticComplexity

      Since: 0.1

      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

      Example

      // Cyclomatic Complexity = 11
      class Foo {
      1   public function example() {
      2       if ($a == $b) {
      3           if ($a1 == $b1) {
                      fiddle();
      4           } elseif ($a2 == $b2) {
                      fiddle();
                  } else {
                      fiddle();
                  }
      5       } elseif ($c == $d) {
      6           while ($c == $d) {
                      fiddle();
                  }
      7        } elseif ($e == $f) {
      8           for ($n = 0; $n < $h; $n++) {
                      fiddle();
                  }
              } else {
                  switch ($z) {
      9               case 1:
                          fiddle();
                          break;
      10              case 2:
                          fiddle();
                          break;
      11              case 3:
                          fiddle();
                          break;
                      default:
                          fiddle();
                          break;
                  }
              }
          }
      }

      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

      The method Show has a boolean flag argument $aF, which is a certain sign of a Single Responsibility Principle violation.
      Open

          public function Show($aF = true)
      Severity: Minor
      Found in src/graph/GanttActivityInfo.php by phpmd

      BooleanArgumentFlag

      Since: 1.4.0

      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

      Example

      class Foo {
          public function bar($flag = true) {
          }
      }

      Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

      The method Stroke has a boolean flag argument $aUseTextHeight, which is a certain sign of a Single Responsibility Principle violation.
      Open

          public function Stroke($aImg, $aXLeft, $aYTop, $aXRight, $aYBottom, $aUseTextHeight = false)
      Severity: Minor
      Found in src/graph/GanttActivityInfo.php by phpmd

      BooleanArgumentFlag

      Since: 1.4.0

      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

      Example

      class Foo {
          public function bar($flag = true) {
          }
      }

      Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

      The method GetColStart has a boolean flag argument $aAddLeftMargin, which is a certain sign of a Single Responsibility Principle violation.
      Open

          public function GetColStart($aImg, &$aStart, $aAddLeftMargin = false)
      Severity: Minor
      Found in src/graph/GanttActivityInfo.php by phpmd

      BooleanArgumentFlag

      Since: 1.4.0

      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

      Example

      class Foo {
          public function bar($flag = true) {
          }
      }

      Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

      The method Hide has a boolean flag argument $aF, which is a certain sign of a Single Responsibility Principle violation.
      Open

          public function Hide($aF = true)
      Severity: Minor
      Found in src/graph/GanttActivityInfo.php by phpmd

      BooleanArgumentFlag

      Since: 1.4.0

      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

      Example

      class Foo {
          public function bar($flag = true) {
          }
      }

      Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

      The method SetMinColWidth uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

                      } else {
                          $this->iWidth[$i] = max($this->iWidth[$i], $aWidths[$i]);
                      }
      Severity: Minor
      Found in src/graph/GanttActivityInfo.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
      {
          public function bar($flag)
          {
              if ($flag) {
                  // one branch
              } else {
                  // another branch
              }
          }
      }

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      The method GetWidth uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

                  } else {
                      $w1 = $txt->GetWidth($aImg) + $rm;
                  }
      Severity: Minor
      Found in src/graph/GanttActivityInfo.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
      {
          public function bar($flag)
          {
              if ($flag) {
                  // one branch
              } else {
                  // another branch
              }
          }
      }

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      Avoid using static access to class '\Amenadiel\JpGraph\Util\JpGraphError' in method 'Stroke'.
      Open

                  Util\JpGraphError::RaiseL(6001);
      Severity: Minor
      Found in src/graph/GanttActivityInfo.php by phpmd

      StaticAccess

      Since: 1.4.0

      Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

      Example

      class Foo
      {
          public function bar()
          {
              Bar::baz();
          }
      }

      Source https://phpmd.org/rules/cleancode.html#staticaccess

      Avoid variables with short names like $n. Configured minimum length is 3.
      Open

              $n = safe_count($this->iTitles);
      Severity: Minor
      Found in src/graph/GanttActivityInfo.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
          private $q = 15; // VIOLATION - Field
          public static function main( array $as ) { // VIOLATION - Formal
              $r = 20 + $this->q; // VIOLATION - Local
              for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                  $r += $this->q;
              }
          }
      }

      Source https://phpmd.org/rules/naming.html#shortvariable

      Avoid variables with short names like $aF. Configured minimum length is 3.
      Open

          public function Hide($aF = true)
      Severity: Minor
      Found in src/graph/GanttActivityInfo.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
          private $q = 15; // VIOLATION - Field
          public static function main( array $as ) { // VIOLATION - Formal
              $r = 20 + $this->q; // VIOLATION - Local
              for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                  $r += $this->q;
              }
          }
      }

      Source https://phpmd.org/rules/naming.html#shortvariable

      Avoid variables with short names like $x. Configured minimum length is 3.
      Open

              $x    = $aXLeft;
      Severity: Minor
      Found in src/graph/GanttActivityInfo.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
          private $q = 15; // VIOLATION - Field
          public static function main( array $as ) { // VIOLATION - Formal
              $r = 20 + $this->q; // VIOLATION - Local
              for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                  $r += $this->q;
              }
          }
      }

      Source https://phpmd.org/rules/naming.html#shortvariable

      Avoid variables with short names like $n. Configured minimum length is 3.
      Open

              $n  = safe_count($this->iTitles);
      Severity: Minor
      Found in src/graph/GanttActivityInfo.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
          private $q = 15; // VIOLATION - Field
          public static function main( array $as ) { // VIOLATION - Formal
              $r = 20 + $this->q; // VIOLATION - Local
              for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                  $r += $this->q;
              }
          }
      }

      Source https://phpmd.org/rules/naming.html#shortvariable

      Avoid variables with short names like $h. Configured minimum length is 3.
      Open

              $h    = $this->iHeight;
      Severity: Minor
      Found in src/graph/GanttActivityInfo.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
          private $q = 15; // VIOLATION - Field
          public static function main( array $as ) { // VIOLATION - Formal
              $r = 20 + $this->q; // VIOLATION - Local
              for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                  $r += $this->q;
              }
          }
      }

      Source https://phpmd.org/rules/naming.html#shortvariable

      Avoid variables with short names like $n. Configured minimum length is 3.
      Open

              $n = min(safe_count($this->iTitles), safe_count($aWidths));
      Severity: Minor
      Found in src/graph/GanttActivityInfo.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
          private $q = 15; // VIOLATION - Field
          public static function main( array $as ) { // VIOLATION - Formal
              $r = 20 + $this->q; // VIOLATION - Local
              for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                  $r += $this->q;
              }
          }
      }

      Source https://phpmd.org/rules/naming.html#shortvariable

      Avoid variables with short names like $w. Configured minimum length is 3.
      Open

              $w  = 0;
      Severity: Minor
      Found in src/graph/GanttActivityInfo.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
          private $q = 15; // VIOLATION - Field
          public static function main( array $as ) { // VIOLATION - Formal
              $r = 20 + $this->q; // VIOLATION - Local
              for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                  $r += $this->q;
              }
          }
      }

      Source https://phpmd.org/rules/naming.html#shortvariable

      Avoid variables with short names like $n. Configured minimum length is 3.
      Open

              $n      = safe_count($this->iTitles);
      Severity: Minor
      Found in src/graph/GanttActivityInfo.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
          private $q = 15; // VIOLATION - Field
          public static function main( array $as ) { // VIOLATION - Formal
              $r = 20 + $this->q; // VIOLATION - Local
              for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                  $r += $this->q;
              }
          }
      }

      Source https://phpmd.org/rules/naming.html#shortvariable

      Avoid variables with short names like $aF. Configured minimum length is 3.
      Open

          public function Show($aF = true)
      Severity: Minor
      Found in src/graph/GanttActivityInfo.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
          private $q = 15; // VIOLATION - Field
          public static function main( array $as ) { // VIOLATION - Formal
              $r = 20 + $this->q; // VIOLATION - Local
              for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                  $r += $this->q;
              }
          }
      }

      Source https://phpmd.org/rules/naming.html#shortvariable

      Avoid variables with short names like $xp. Configured minimum length is 3.
      Open

                  $xp = $x;
      Severity: Minor
      Found in src/graph/GanttActivityInfo.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
          private $q = 15; // VIOLATION - Field
          public static function main( array $as ) { // VIOLATION - Formal
              $r = 20 + $this->q; // VIOLATION - Local
              for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                  $r += $this->q;
              }
          }
      }

      Source https://phpmd.org/rules/naming.html#shortvariable

      Avoid variables with short names like $rm. Configured minimum length is 3.
      Open

              $rm = $this->iRightColMargin;
      Severity: Minor
      Found in src/graph/GanttActivityInfo.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
          private $q = 15; // VIOLATION - Field
          public static function main( array $as ) { // VIOLATION - Formal
              $r = 20 + $this->q; // VIOLATION - Local
              for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                  $r += $this->q;
              }
          }
      }

      Source https://phpmd.org/rules/naming.html#shortvariable

      Avoid variables with short names like $w1. Configured minimum length is 3.
      Open

                      $w1 = max($txt->GetWidth($aImg) + $rm, $this->iWidth[$i]);
      Severity: Minor
      Found in src/graph/GanttActivityInfo.php by phpmd

      ShortVariable

      Since: 0.2

      Detects when a field, local, or parameter has a very short name.

      Example

      class Something {
          private $q = 15; // VIOLATION - Field
          public static function main( array $as ) { // VIOLATION - Formal
              $r = 20 + $this->q; // VIOLATION - Local
              for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
                  $r += $this->q;
              }
          }
      }

      Source https://phpmd.org/rules/naming.html#shortvariable

      Method name "GanttActivityInfo::SetColumnMargin" is not in camel caps format
      Open

          public function SetColumnMargin($aLeft, $aRight)

      Method name "GanttActivityInfo::SetColTitles" is not in camel caps format
      Open

          public function SetColTitles($aTitles, $aWidth = null)

      Method name "GanttActivityInfo::SetFont" is not in camel caps format
      Open

          public function SetFont($aFFamily, $aFStyle = FS_NORMAL, $aFSize = 10)

      Method name "GanttActivityInfo::SetHeaderAlign" is not in camel caps format
      Open

          public function SetHeaderAlign($aAlign)

      Method name "GanttActivityInfo::SetStyle" is not in camel caps format
      Open

          public function SetStyle($aStyle)

      Method name "GanttActivityInfo::SetFontColor" is not in camel caps format
      Open

          public function SetFontColor($aFontColor)

      Method name "GanttActivityInfo::SetColor" is not in camel caps format
      Open

          public function SetColor($aColor)

      Method name "GanttActivityInfo::Hide" is not in camel caps format
      Open

          public function Hide($aF = true)

      Method name "GanttActivityInfo::Stroke" is not in camel caps format
      Open

          public function Stroke($aImg, $aXLeft, $aYTop, $aXRight, $aYBottom, $aUseTextHeight = false)

      Method name "GanttActivityInfo::Show" is not in camel caps format
      Open

          public function Show($aF = true)

      Method name "GanttActivityInfo::GetColStart" is not in camel caps format
      Open

          public function GetColStart($aImg, &$aStart, $aAddLeftMargin = false)

      Method name "GanttActivityInfo::SetBackgroundColor" is not in camel caps format
      Open

          public function SetBackgroundColor($aColor)

      Method name "GanttActivityInfo::SetMinColWidth" is not in camel caps format
      Open

          public function SetMinColWidth($aWidths)

      Method name "GanttActivityInfo::GetWidth" is not in camel caps format
      Open

          public function GetWidth($aImg)

      There are no issues that match your filters.

      Category
      Status