Sign upLogin

HuasoFoundries/jpgraph

View on GitHub
Star
src/plot/ContourPlot.php

Summary

Maintainability
A
1 hr
Test Coverage

Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public function __construct($aDataMatrix, $aIsobar = 10, $aFactor = 1, $aInvert = false, $aIsobarColors = [])
Severity: Minor
Found in src/plot/ContourPlot.php - About 35 mins to fix

    Function Legend has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public function Legend($aGraph)
    {
        if (!$this->showLegend) {
            return;
        }
    Severity: Minor
    Found in src/plot/ContourPlot.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function Stroke has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        public function Stroke($img, $xscale, $yscale)
    {
        if (safe_count($this->manualIsobarColors) > 0) {
            $this->contourColor = $this->manualIsobarColors;
            if (safe_count($this->manualIsobarColors) != $this->nbrContours) {
    Severity: Minor
    Found in src/plot/ContourPlot.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    The method ShowLegend has a boolean flag argument $aFlg, which is a certain sign of a Single Responsibility Principle violation.
    Open

        public function ShowLegend($aFlg = true)
    Severity: Minor
    Found in src/plot/ContourPlot.php by phpmd

    BooleanArgumentFlag

    Since: 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example

    class Foo {
    public function bar($flag = true) {
    }
}

    Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

    The method __construct has a boolean flag argument $aInvert, which is a certain sign of a Single Responsibility Principle violation.
    Open

        public function __construct($aDataMatrix, $aIsobar = 10, $aFactor = 1, $aInvert = false, $aIsobarColors = [])
    Severity: Minor
    Found in src/plot/ContourPlot.php by phpmd

    BooleanArgumentFlag

    Since: 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example

    class Foo {
    public function bar($flag = true) {
    }
}

    Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

    The method SetInvert has a boolean flag argument $aFlg, which is a certain sign of a Single Responsibility Principle violation.
    Open

        public function SetInvert($aFlg = true)
    Severity: Minor
    Found in src/plot/ContourPlot.php by phpmd

    BooleanArgumentFlag

    Since: 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example

    class Foo {
    public function bar($flag = true) {
    }
}

    Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

    The method Invertlegend has a boolean flag argument $aFlg, which is a certain sign of a Single Responsibility Principle violation.
    Open

        public function Invertlegend($aFlg = true)
    Severity: Minor
    Found in src/plot/ContourPlot.php by phpmd

    BooleanArgumentFlag

    Since: 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example

    class Foo {
    public function bar($flag = true) {
    }
}

    Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

    The method UseHighContrastColor has a boolean flag argument $aFlg, which is a certain sign of a Single Responsibility Principle violation.
    Open

        public function UseHighContrastColor($aFlg = true, $aBW = false)
    Severity: Minor
    Found in src/plot/ContourPlot.php by phpmd

    BooleanArgumentFlag

    Since: 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example

    class Foo {
    public function bar($flag = true) {
    }
}

    Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

    The method UseHighContrastColor has a boolean flag argument $aBW, which is a certain sign of a Single Responsibility Principle violation.
    Open

        public function UseHighContrastColor($aFlg = true, $aBW = false)
    Severity: Minor
    Found in src/plot/ContourPlot.php by phpmd

    BooleanArgumentFlag

    Since: 1.4.0

    A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

    Example

    class Foo {
    public function bar($flag = true) {
    }
}

    Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

    The method Legend uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

            } else {
            for ($i = $this->nbrContours - 1; $i >= 0; --$i) {
                $aGraph->legend->Add(sprintf('%.1f', $this->contourVal[$i]), $this->contourColor[$i]);
            }
        }
    Severity: Minor
    Found in src/plot/ContourPlot.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Avoid using static access to class 'Amenadiel\JpGraph\Plot\Util\JpGraphError' in method '__construct'.
    Open

                    Util\JpGraphError::RaiseL(28007); // ContourPlot interpolation factor is too large (>5)
    Severity: Minor
    Found in src/plot/ContourPlot.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'Amenadiel\JpGraph\Plot\Util\JpGraphError' in method 'Stroke'.
    Open

                    Util\JpGraphError::RaiseL(28002);
    Severity: Minor
    Found in src/plot/ContourPlot.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    The method __construct uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

            } else {
            $this->nbrContours = $aIsobar;
        }
    Severity: Minor
    Found in src/plot/ContourPlot.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    Avoid unused private fields such as '$nbrCountours'.
    Open

        private $nbrCountours       = 0;
    Severity: Minor
    Found in src/plot/ContourPlot.php by phpmd

    UnusedPrivateField

    Since: 0.2

    Detects when a private field is declared and/or assigned a value, but not used.

    Example

    class Something
{
    private static $FOO = 2; // Unused
    private $i = 5; // Unused
    private $j = 6;
    public function addOne()
    {
        return $this->j++;
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedprivatefield

    Avoid variables with short names like $x1. Configured minimum length is 3.
    Open

                    list($x1, $y1) = $this->contourCoord[$c][$i][0];
    Severity: Minor
    Found in src/plot/ContourPlot.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $x2. Configured minimum length is 3.
    Open

                    list($x2, $y2) = $this->contourCoord[$c][$i++][1];
    Severity: Minor
    Found in src/plot/ContourPlot.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $n. Configured minimum length is 3.
    Open

                $n = safe_count($this->contourCoord[$c]);
    Severity: Minor
    Found in src/plot/ContourPlot.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $y2. Configured minimum length is 3.
    Open

                    list($x2, $y2) = $this->contourCoord[$c][$i++][1];
    Severity: Minor
    Found in src/plot/ContourPlot.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $i. Configured minimum length is 3.
    Open

                $i = 0;
    Severity: Minor
    Found in src/plot/ContourPlot.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $ip. Configured minimum length is 3.
    Open

                $ip               = new MeshInterpolate();
    Severity: Minor
    Found in src/plot/ContourPlot.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $y1. Configured minimum length is 3.
    Open

                    list($x1, $y1) = $this->contourCoord[$c][$i][0];
    Severity: Minor
    Found in src/plot/ContourPlot.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $xn. Configured minimum length is 3.
    Open

            $xn = safe_count($this->dataMatrix[0]) - 1;
    Severity: Minor
    Found in src/plot/ContourPlot.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Avoid variables with short names like $yn. Configured minimum length is 3.
    Open

            $yn = safe_count($this->dataMatrix) - 1;
    Severity: Minor
    Found in src/plot/ContourPlot.php by phpmd

    ShortVariable

    Since: 0.2

    Detects when a field, local, or parameter has a very short name.

    Example

    class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

    Source https://phpmd.org/rules/naming.html#shortvariable

    Method name "ContourPlot::Invertlegend" is not in camel caps format
    Open

        public function Invertlegend($aFlg = true)
    Severity: Minor
    Found in src/plot/ContourPlot.php by phpcodesniffer

    Method name "ContourPlot::Min" is not in camel caps format
    Open

        public function Min()
    Severity: Minor
    Found in src/plot/ContourPlot.php by phpcodesniffer

    Method name "ContourPlot::Max" is not in camel caps format
    Open

        public function Max()
    Severity: Minor
    Found in src/plot/ContourPlot.php by phpcodesniffer

    Method name "ContourPlot::SetInvert" is not in camel caps format
    Open

        public function SetInvert($aFlg = true)
    Severity: Minor
    Found in src/plot/ContourPlot.php by phpcodesniffer

    Method name "ContourPlot::UseHighContrastColor" is not in camel caps format
    Open

        public function UseHighContrastColor($aFlg = true, $aBW = false)
    Severity: Minor
    Found in src/plot/ContourPlot.php by phpcodesniffer

    Method name "ContourPlot::Stroke" is not in camel caps format
    Open

        public function Stroke($img, $xscale, $yscale)
    Severity: Minor
    Found in src/plot/ContourPlot.php by phpcodesniffer

    Method name "ContourPlot::Legend" is not in camel caps format
    Open

        public function Legend($aGraph)
    Severity: Minor
    Found in src/plot/ContourPlot.php by phpcodesniffer

    Method name "ContourPlot::ShowLegend" is not in camel caps format
    Open

        public function ShowLegend($aFlg = true)
    Severity: Minor
    Found in src/plot/ContourPlot.php by phpcodesniffer

    Method name "ContourPlot::SetIsobarColors" is not in camel caps format
    Open

        public function SetIsobarColors($aColorArray)
    Severity: Minor
    Found in src/plot/ContourPlot.php by phpcodesniffer

    Method name "ContourPlot::PreScaleSetup" is not in camel caps format
    Open

        public function PreScaleSetup($aGraph)
    Severity: Minor
    Found in src/plot/ContourPlot.php by phpcodesniffer

    There are no issues that match your filters.

    Category
    Status