Sign upLogin

IlyaGusev/rulm

View on GitHub
Star

Showing 260 of 260 total issues

Function main has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

def main(
    input_path,
    output_path,
    template_path,
    model_name="gpt-3.5-turbo",
Severity: Minor
Found in self_instruct/src/sbs/eval_gpt.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                    if host in record.url:
                        is_bad_host = True
                if is_bad_host:
Severity: Major
Found in data_processing/create_ru_news.py - About 45 mins to fix

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

            if tokenizer.pad_token_id in bad_ids and guessed_pad_token_id is None and "pad" in token:
            guessed_pad_token_id = token_id
    Severity: Major
    Found in self_instruct/src/util/dl.py and 3 other locations - About 45 mins to fix
    self_instruct/src/util/dl.py on lines 40..41
    self_instruct/src/util/dl.py on lines 42..43
    self_instruct/src/util/dl.py on lines 44..45

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 35.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def __init__(self, posts_path, users_path, comments_path, output_path, min_score=-1000, max_responses=1000):
    Severity: Minor
    Found in data_processing/create_stackoverflow.py - About 45 mins to fix

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

              if tokenizer.eos_token_id in bad_ids and guessed_eos_token_id is None and "</s>" in token:
            guessed_eos_token_id = token_id
      Severity: Major
      Found in self_instruct/src/util/dl.py and 3 other locations - About 45 mins to fix
      self_instruct/src/util/dl.py on lines 38..39
      self_instruct/src/util/dl.py on lines 40..41
      self_instruct/src/util/dl.py on lines 44..45

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 35.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Avoid deeply nested control flow statements.
      Open

                          with connection.cursor() as comments_cursor:
                        comments_cursor.execute("SELECT * FROM pikabu_comments WHERE story_id = {}".format(record["id"]))
                        for row in comments_cursor:
                            header = [desc.name for desc in comments_cursor.description]
                            comment = dict(zip(header, row))
      Severity: Major
      Found in data_processing/convert_pikabu.py - About 45 mins to fix

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

                if tokenizer.bos_token_id in bad_ids and guessed_bos_token_id is None and "<s>" in token:
            guessed_bos_token_id = token_id
        Severity: Major
        Found in self_instruct/src/util/dl.py and 3 other locations - About 45 mins to fix
        self_instruct/src/util/dl.py on lines 38..39
        self_instruct/src/util/dl.py on lines 42..43
        self_instruct/src/util/dl.py on lines 44..45

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 35.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Avoid deeply nested control flow statements.
        Open

                            if clean_section:
                        clean_sections.append(clean_section)
                record["sections"] = clean_sections
        Severity: Major
        Found in data_processing/parse_zip_fb2.py - About 45 mins to fix

          Function main has 6 arguments (exceeds 4 allowed). Consider refactoring.
          Open

          def main(
          Severity: Minor
          Found in data_processing/create_ru_news.py - About 45 mins to fix

            Function split has 6 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            def split(
            Severity: Minor
            Found in data_processing/split.py - About 45 mins to fix

              Function train_tokenizer has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

              def train_tokenizer(
    dataset_path,
    train_path,
    output_dir,
    sample_rate,
              Severity: Minor
              Found in rulm/train_tokenizer.py - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 4 locations. Consider refactoring.
              Open

                      if tokenizer.unk_token_id in bad_ids and guessed_unk_token_id is None and "unk" in token:
            guessed_unk_token_id = token_id
              Severity: Major
              Found in self_instruct/src/util/dl.py and 3 other locations - About 45 mins to fix
              self_instruct/src/util/dl.py on lines 38..39
              self_instruct/src/util/dl.py on lines 40..41
              self_instruct/src/util/dl.py on lines 42..43

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 35.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Function main has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

              def main(
              Severity: Minor
              Found in self_instruct/crowd/aggregate.py - About 35 mins to fix

                Function main has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                def main(
                Severity: Minor
                Found in self_instruct/src/data_processing/generate_char_topics.py - About 35 mins to fix

                  Function train has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                  def train(
                  Severity: Minor
                  Found in self_instruct/src/train_orpo.py - About 35 mins to fix

                    Function train has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                    def train(
                    Severity: Minor
                    Found in self_instruct/src/train_kto.py - About 35 mins to fix

                      Function main has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                      def main(
                      Severity: Minor
                      Found in self_instruct/src/sbs/eval_gpt.py - About 35 mins to fix

                        Function generate has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                        def generate(
                        Severity: Minor
                        Found in self_instruct/src/benchmarks/eval_zs_rsg.py - About 35 mins to fix

                          Function main has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                          def main(
                          Severity: Minor
                          Found in self_instruct/src/data_processing/exec_instructions.py - About 35 mins to fix

                            Function ingest has 5 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                            def ingest(
                            Severity: Minor
                            Found in self_instruct/src/tools/ingest.py - About 35 mins to fix
                              Severity
                              Category
                              Status
                              Source
                              Language