ImpressCMS/impresscms

View on GitHub

Showing 540 of 47,256 total issues

File prototype.js has 5999 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*  Prototype JavaScript framework, version 1.7.3
 *  (c) 2005-2010 Sam Stephenson
 *
 *  Prototype is freely distributable under the terms of an MIT-style license.
 *  For details, see the Prototype web site: http://www.prototypejs.org/
Severity: Major
Found in htdocs/install/prototype.js - About 2 wks to fix

    Function icms_module_update has a Cognitive Complexity of 391 (exceeds 5 allowed). Consider refactoring.
    Open

    function icms_module_update($dirname) {
        global $icmsConfig, $icmsAdminTpl;
    
        $msgs = array();
    
    
    Severity: Minor
    Found in htdocs/modules/system/admin/modulesadmin/modulesadmin.php - About 1 wk to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function icms_module_update has a Cognitive Complexity of 376 (exceeds 5 allowed). Consider refactoring.
    Open

    function icms_module_update($dirname) {
        $dirname = trim($dirname);
        $db =& icms_db_Factory::instance();
        $module_handler = icms::handler('icms_module');
        $module =& $module_handler->getByDirname($dirname);
    Severity: Minor
    Found in htdocs/install/modulesadmin.php - About 1 wk to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function xoops_module_install has a Cognitive Complexity of 360 (exceeds 5 allowed). Consider refactoring.
    Open

    function xoops_module_install($dirname) {
        $dirname = trim($dirname);
        $db =& icms_db_Factory::instance();
        $reservedTables = array('avatar', 'avatar_users_link', 'block_module_link', 'xoopscomments', 'config', 'configcategory', 'configoption', 'image', 'imagebody', 'imagecategory', 'imgset', 'imgset_tplset_link', 'imgsetimg', 'groups','groups_users_link','group_permission', 'online', 'priv_msgs', 'ranks', 'session', 'smiles', 'users', 'newblocks', 'modules', 'tplfile', 'tplset', 'tplsource', 'xoopsnotifications');
        $module_handler = icms::handler('icms_module');
    Severity: Minor
    Found in htdocs/install/modulesadmin.php - About 1 wk to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function xoops_module_install has a Cognitive Complexity of 344 (exceeds 5 allowed). Consider refactoring.
    Open

    function xoops_module_install($dirname) {
        global $icmsConfig, $icmsAdminTpl;
        $dirname = trim($dirname);
        $db = icms_db_Factory::instance();
        $reservedTables = array('avatar',
    Severity: Minor
    Found in htdocs/modules/system/admin/modulesadmin/modulesadmin.php - About 1 wk to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File functions.php has 1340 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    // $Id: functions.php 1032 2007-09-09 13:01:16Z dugris $
    //  ------------------------------------------------------------------------ //
    //                XOOPS - PHP Content Management System                      //
    //                    Copyright (c) 2000 XOOPS.org                           //
    Severity: Major
    Found in htdocs/include/functions.php - About 3 days to fix

      Function xoops_module_uninstall has a Cognitive Complexity of 165 (exceeds 5 allowed). Consider refactoring.
      Open

      function xoops_module_uninstall($dirname) {
          global $icmsConfig, $icmsAdminTpl;
      
          $reservedTables = array('avatar',
              'avatar_users_link',
      Severity: Minor
      Found in htdocs/modules/system/admin/modulesadmin/modulesadmin.php - About 3 days to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function icms_cp_header has a Cognitive Complexity of 161 (exceeds 5 allowed). Consider refactoring.
      Open

      function icms_cp_header() {
          global $icmsConfig, $icmsConfigPlugins, $icmsConfigPersona, $xoopsModule, $xoopsTpl, $xoopsOption, $icmsTheme, $xoTheme, $icmsConfigMultilang, $icmsAdminTpl;
      
          icms::$logger->stopTime('Module init');
          icms::$logger->startTime('ImpressCMS CP Output Init');
      Severity: Minor
      Found in htdocs/include/cp_functions.php - About 3 days to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File modulesadmin.php has 1190 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php
      // $Id: modulesadmin.php 12403 2014-01-26 21:35:08Z skenow $
      // ------------------------------------------------------------------------ //
      // XOOPS - PHP Content Management System //
      // Copyright (c) 2000 XOOPS.org //
      Severity: Major
      Found in htdocs/modules/system/admin/modulesadmin/modulesadmin.php - About 3 days to fix

        Function AdMenu has a Cognitive Complexity of 145 (exceeds 5 allowed). Consider refactoring.
        Open

        function AdMenu(id) { this.type = "horizontal"; this.position = { "level1": { "top": 0, "left": 0}, "levelX": { "top": 0, "left": 0}
        }
        this.zIndex = { "visible": 1, "hidden": -1
        }
        this.arrow1 = null; this.arrow2 = null; this.browser = { "ie": Boolean(document.body.currentStyle), "ie5": (navigator.appVersion.indexOf("MSIE 5.5") != -1 || navigator.appVersion.indexOf("MSIE 5.0") != -1)
        Severity: Minor
        Found in htdocs/include/icms_rtl.js - About 2 days to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        File main.php has 1044 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        <?php
        // $Id: main.php 12399 2014-01-25 17:02:01Z skenow $
        //  ------------------------------------------------------------------------ //
        //                XOOPS - PHP Content Management System                      //
        //                    Copyright (c) 2000 XOOPS.org                           //
        Severity: Major
        Found in htdocs/modules/system/admin/tplsets/main.php - About 2 days to fix

          Method make_data has 490 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function make_data(&$dbm, &$cm, $adminname, $adminlogin_name, $adminpass, $adminmail, $language, $gruops) {
          
              $tables = array();
          
              // data for table 'groups_users_link'
          Severity: Major
          Found in htdocs/install/makedata.php - About 2 days to fix

            Function jdate has a Cognitive Complexity of 119 (exceeds 5 allowed). Consider refactoring.
            Open

            function jdate($type,$maket='now') {
                global $icmsConfig;
                icms_loadLanguageFile('core', 'calendar');
                $result='';
                if ($maket=='now') {
            Severity: Minor
            Found in htdocs/include/jalali.php - About 2 days to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            File main.php has 945 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            <?php
            // $Id: main.php 12460 2014-06-25 03:35:37Z skenow $
            // ------------------------------------------------------------------------ //
            // XOOPS - PHP Content Management System //
            // Copyright (c) 2000 XOOPS.org //
            Severity: Major
            Found in htdocs/modules/system/admin/images/main.php - About 2 days to fix

              Method xoops_module_install has 413 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function xoops_module_install($dirname) {
                  global $icmsConfig, $icmsAdminTpl;
                  $dirname = trim($dirname);
                  $db = icms_db_Factory::instance();
                  $reservedTables = array('avatar',
              Severity: Major
              Found in htdocs/modules/system/admin/modulesadmin/modulesadmin.php - About 2 days to fix

                Method icms_module_update has 406 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                function icms_module_update($dirname) {
                    global $icmsConfig, $icmsAdminTpl;
                
                    $msgs = array();
                
                
                Severity: Major
                Found in htdocs/modules/system/admin/modulesadmin/modulesadmin.php - About 2 days to fix

                  Method icms_module_update has 393 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  function icms_module_update($dirname) {
                      $dirname = trim($dirname);
                      $db =& icms_db_Factory::instance();
                      $module_handler = icms::handler('icms_module');
                      $module =& $module_handler->getByDirname($dirname);
                  Severity: Major
                  Found in htdocs/install/modulesadmin.php - About 1 day to fix

                    Method xoops_module_install has 391 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                    function xoops_module_install($dirname) {
                        $dirname = trim($dirname);
                        $db =& icms_db_Factory::instance();
                        $reservedTables = array('avatar', 'avatar_users_link', 'block_module_link', 'xoopscomments', 'config', 'configcategory', 'configoption', 'image', 'imagebody', 'imagecategory', 'imgset', 'imgset_tplset_link', 'imgsetimg', 'groups','groups_users_link','group_permission', 'online', 'priv_msgs', 'ranks', 'session', 'smiles', 'users', 'newblocks', 'modules', 'tplfile', 'tplset', 'tplsource', 'xoopsnotifications');
                        $module_handler = icms::handler('icms_module');
                    Severity: Major
                    Found in htdocs/install/modulesadmin.php - About 1 day to fix

                      File modulesadmin.php has 811 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      <?php
                      /**
                       * Installer tables creation page
                       *
                       * See the enclosed file license.txt for licensing information.
                      Severity: Major
                      Found in htdocs/install/modulesadmin.php - About 1 day to fix

                        File browser.php has 802 lines of code (exceeds 250 allowed). Consider refactoring.
                        Open

                        <?php
                        /**
                         * Images Manager - Image Browser
                         *
                         * Used to create an instance of the image manager in a popup window to use with the dhmtl textarea object
                        Severity: Major
                        Found in htdocs/modules/system/admin/images/browser.php - About 1 day to fix
                          Severity
                          Category
                          Status
                          Source
                          Language